From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EC0FC282DE for ; Mon, 10 Mar 2025 11:43:43 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZBFQj73VPz2ykX; Mon, 10 Mar 2025 22:43:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:4641:c500::1" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1741607021; cv=none; b=eWY/PJcgAg3Fxw8SPKN9deGwg7hA++oZ38SS+ZUELuESCqrttLaA0ssw21qRz+ur5+52Meyjo9XxSbtlfJQ5Hfor19+2ND6uYBMNLLrdFdJFnML8ABWtVH+F6rnf2hSSj5bFPmddCJoLdJLs3AKF8cLrtD5rpXwKS6eKqrq9+psw8sBndtKEW9O//gki06jbPSdPexrsvA/Z5Jtei/Dv5s1Gchm7SxF6tmCx4P+tY7dhdYYsNuxPqEa7gVUue5F/KdrPftpMkfGFI2dU99CZ+4zitjuETeIOBqYYeLGjn7Av7lg6N648OJiqizBA2g9/PUQ+weWAtxfIrshxb3bXVw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1741607021; c=relaxed/relaxed; bh=/jk1eNce9YdaDO4hTP3Q8VPdC5qG8RIvP2AOzDClGpE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=nXgdZbZc09B7++N1buRM5slFD/6y2DXGMKEMglBHOz+7uHH/OMoQaeb+7dT8OCMX1WH1GE999EkBfe9m5yzSleS4PxfHwbPVIpaWhJVS+5XT6NAleuIj3DHOHcB+Yrm+giRZ1KsDhA26qHSHBO1F9Ch3ciOYqhiY3lIKNIeySVbTTV9vdbBgmZiwt53x6Bo+OJOV9joi13K82tas+PGPNgfFjPdVZVaJ57OI74KbShusNlIpKNjlxyLeL98jynBz+8bSSiHeXDNyBuDyvZuX8XB4pENeDtTZNa9N5ULv2IeCAQvbqkLHeJi02Urq1CpAejGC/ZXifcmcN0sXyZu65w== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Y1fF+ejS; dkim-atps=neutral; spf=pass (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=krzk@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Y1fF+ejS; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=krzk@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZBFQj08Hdz2xy7 for ; Mon, 10 Mar 2025 22:43:41 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 81AD25C5F48; Mon, 10 Mar 2025 11:41:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9FDCC4CEE5; Mon, 10 Mar 2025 11:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741607019; bh=tQwFxFodDyYLTyLCaNMHIBv2+xezKs5dn2xjZoV+LO8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Y1fF+ejSeQjhZG03rGEzTxp4uHwG4FJ88H+cfBpnOWdfhlXWFidYySRC0n7RvTvY8 o78WgeYmEpny+6uUDNOEAM4GBB56bsnkguIYCeaAJDgmdYZ9IbxZiogpahqH2Rtynb UdI36etroRrla+LhumrlCCR1Dmdc2Z/6RdfAp6kv/Lb9F8vKZHT740yXpJXvU04MVJ 0PA/LAXPiuLAr2gmuVNGQ8bQW+RqKEZXJC+pQZdsZbSqBKMStOFVYJO2GSRquFZ9lZ ubOB9bhKTjJ51nuW3AEa8PGsaROhbykS+YoofW9AbNWH485bqFvsdB7lZNOICaiNgL 0zb9KBCim9gnQ== Message-ID: <58466532-3e17-4968-bade-210f478ccc76@kernel.org> Date: Mon, 10 Mar 2025 12:43:29 +0100 X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] soc: aspeed: lpc-pcc: Add PCC controller support To: Kevin Chen , "lee@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "joel@jms.id.au" , "andrew@codeconstruct.com.au" , "derek.kiernan@amd.com" , "dragan.cvetic@amd.com" , "arnd@arndb.de" , "gregkh@linuxfoundation.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20250304104434.481429-1-kevin_chen@aspeedtech.com> <20250304104434.481429-4-kevin_chen@aspeedtech.com> <2fd83d68-7104-4755-a0f0-8ce4a2601e09@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/03/2025 11:05, Kevin Chen wrote: >> On 04/03/2025 11:44, Kevin Chen wrote: >>> + >>> +static int aspeed_pcc_probe(struct platform_device *pdev) { >>> + int rc; >>> + struct aspeed_pcc_ctrl *pcc; >>> + struct device *dev; >>> + uint32_t fifo_size = PAGE_SIZE; >>> + >>> + dev = &pdev->dev; >> >> This goes to declaration. > OK. I will move it to declaration. > >> >>> + >>> + pcc = devm_kzalloc(&pdev->dev, sizeof(*pcc), GFP_KERNEL); >> >> Maybe my previous comment was not clear, but you agreed with it. Anyway >> nothing improved here. > Could I reserve the pcc variable using for the pcc_ctrl data structure? > Pcc_ctrl data include the regmap/irq/io_port/dma/kfifo. > If I change the name to dev, it does not make sense for these data to be. > >> >> If you have 'dev' variable, use it. > Do you mean just use the pdev->dev not local dev variable? What is the point of this: dev = &pdev->dev; if you do not use 'dev'? If you come with a reason, sure. If you do not have such, then everything should use 'dev', not pdev->dev. Best regards, Krzysztof