From: Eddie James <eajames@linux.ibm.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ninad Palsule <ninad@linux.ibm.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-fsi@lists.ozlabs.org
Subject: Re: [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles
Date: Fri, 1 Aug 2025 09:58:40 -0500 [thread overview]
Message-ID: <5e0f216b-377c-4a1d-82a8-ead89ce8f574@linux.ibm.com> (raw)
In-Reply-To: <20250731-dt-fsi-cleanups-v1-3-e7b695a29fc3@kernel.org>
On 7/31/25 17:12, Rob Herring (Arm) wrote:
> The "ibm,spi-fsi" compatible is missing or incorrect in various nodes.
> The incorrect cases used the "ibm,fsi2spi" compatible by mistake which
> is the parent node of the actual SPI controller nodes.
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts | 24 ++++++++++++++--------
> arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi | 12 +++++++----
> arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 12 +++++++----
> 3 files changed, 32 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> index 9961508ee872..52a044b1e454 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> @@ -2808,6 +2808,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam4_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2824,6 +2825,7 @@ eeprom@0 {
> };
>
> cfam4_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2840,8 +2842,8 @@ eeprom@0 {
> };
>
> cfam4_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -2857,8 +2859,8 @@ eeprom@0 {
> };
>
> cfam4_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3181,6 +3183,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam5_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3197,6 +3200,7 @@ eeprom@0 {
> };
>
> cfam5_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3213,8 +3217,8 @@ eeprom@0 {
> };
>
> cfam5_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3230,8 +3234,8 @@ eeprom@0 {
> };
>
> cfam5_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3554,6 +3558,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam6_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3570,6 +3575,7 @@ eeprom@0 {
> };
>
> cfam6_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3586,8 +3592,8 @@ eeprom@0 {
> };
>
> cfam6_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3603,8 +3609,8 @@ eeprom@0 {
> };
>
> cfam6_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3927,6 +3933,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam7_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3943,6 +3950,7 @@ eeprom@0 {
> };
>
> cfam7_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3959,8 +3967,8 @@ eeprom@0 {
> };
>
> cfam7_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3976,8 +3984,8 @@ eeprom@0 {
> };
>
> cfam7_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi b/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
> index 07ce3b2bc62a..06fac236773f 100644
> --- a/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
> +++ b/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
> @@ -82,6 +82,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam0_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -98,6 +99,7 @@ eeprom@0 {
> };
>
> cfam0_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -114,8 +116,8 @@ eeprom@0 {
> };
>
> cfam0_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -131,8 +133,8 @@ eeprom@0 {
> };
>
> cfam0_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -249,6 +251,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam1_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -265,6 +268,7 @@ eeprom@0 {
> };
>
> cfam1_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -281,8 +285,8 @@ eeprom@0 {
> };
>
> cfam1_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -298,8 +302,8 @@ eeprom@0 {
> };
>
> cfam1_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi b/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
> index 57494c744b5d..9501f66d0030 100644
> --- a/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
> +++ b/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
> @@ -733,6 +733,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam2_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -749,6 +750,7 @@ eeprom@0 {
> };
>
> cfam2_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -765,8 +767,8 @@ eeprom@0 {
> };
>
> cfam2_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -782,8 +784,8 @@ eeprom@0 {
> };
>
> cfam2_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -1106,6 +1108,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam3_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -1122,6 +1125,7 @@ eeprom@0 {
> };
>
> cfam3_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -1138,8 +1142,8 @@ eeprom@0 {
> };
>
> cfam3_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -1155,8 +1159,8 @@ eeprom@0 {
> };
>
> cfam3_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
>
next prev parent reply other threads:[~2025-08-01 14:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
2025-07-31 22:12 ` [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays" Rob Herring (Arm)
2025-08-01 14:56 ` Eddie James
2025-07-31 22:12 ` [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles Rob Herring (Arm)
2025-08-01 14:57 ` Eddie James
2025-07-31 22:12 ` [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles Rob Herring (Arm)
2025-08-01 14:58 ` Eddie James [this message]
2025-07-31 22:12 ` [PATCH 4/6] MAINTAINERS: Add FSI bindings to FSI subsystem entry Rob Herring (Arm)
2025-08-01 14:59 ` Eddie James
2025-07-31 22:12 ` [PATCH 5/6] dt-bindings: fsi: Convert fsi-master-gpio to DT schema Rob Herring (Arm)
2025-08-01 15:01 ` Eddie James
2025-07-31 22:12 ` [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master " Rob Herring (Arm)
2025-08-01 15:03 ` Eddie James
2025-08-04 1:38 ` [PATCH 0/6] ASpeed FSI DT clean-ups Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0f216b-377c-4a1d-82a8-ead89ce8f574@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andrew@codeconstruct.com.au \
--cc=benh@kernel.crashing.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).