* [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays"
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
@ 2025-07-31 22:12 ` Rob Herring (Arm)
2025-08-01 14:56 ` Eddie James
2025-07-31 22:12 ` [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles Rob Herring (Arm)
` (5 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Rob Herring (Arm) @ 2025-07-31 22:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery,
Benjamin Herrenschmidt, Eddie James, Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
The "no-gpios-delays" property only applies to the "fsi-master-gpio"
binding and not the "aspeed,ast2[45]00-cf-fsi-master" binding. It
doesn't really make sense either as the timing is controlled by the
offloaded firmware.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 1 -
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts | 1 -
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts | 1 -
3 files changed, 3 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
index 78a5656ef75d..f42254ba6aeb 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
@@ -57,7 +57,6 @@ fsi: gpio-fsi {
compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
#address-cells = <2>;
#size-cells = <0>;
- no-gpio-delays;
memory-region = <&coldfire_memory>;
aspeed,sram = <&sram>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
index b1d0ff85d397..e5b8d07e7622 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
@@ -80,7 +80,6 @@ fsi: gpio-fsi {
compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
#address-cells = <2>;
#size-cells = <0>;
- no-gpio-delays;
memory-region = <&coldfire_memory>;
aspeed,sram = <&sram>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
index 24df24ad9c80..2180fa9b6f24 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
@@ -71,7 +71,6 @@ fsi: gpio-fsi {
compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
#address-cells = <2>;
#size-cells = <0>;
- no-gpio-delays;
memory-region = <&coldfire_memory>;
aspeed,sram = <&sram>;
--
2.47.2
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays"
2025-07-31 22:12 ` [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays" Rob Herring (Arm)
@ 2025-08-01 14:56 ` Eddie James
0 siblings, 0 replies; 14+ messages in thread
From: Eddie James @ 2025-08-01 14:56 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, Benjamin Herrenschmidt,
Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
On 7/31/25 17:12, Rob Herring (Arm) wrote:
> The "no-gpios-delays" property only applies to the "fsi-master-gpio"
> binding and not the "aspeed,ast2[45]00-cf-fsi-master" binding. It
> doesn't really make sense either as the timing is controlled by the
> offloaded firmware.
Thanks for the series Rob. It's fine with me if you take the bindings
(we're not using the FSI tree now, Grek just merges stuff as needed)
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 1 -
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts | 1 -
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> index 78a5656ef75d..f42254ba6aeb 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> @@ -57,7 +57,6 @@ fsi: gpio-fsi {
> compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
> - no-gpio-delays;
>
> memory-region = <&coldfire_memory>;
> aspeed,sram = <&sram>;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> index b1d0ff85d397..e5b8d07e7622 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> @@ -80,7 +80,6 @@ fsi: gpio-fsi {
> compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
> - no-gpio-delays;
>
> memory-region = <&coldfire_memory>;
> aspeed,sram = <&sram>;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> index 24df24ad9c80..2180fa9b6f24 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> @@ -71,7 +71,6 @@ fsi: gpio-fsi {
> compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
> - no-gpio-delays;
>
> memory-region = <&coldfire_memory>;
> aspeed,sram = <&sram>;
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
2025-07-31 22:12 ` [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays" Rob Herring (Arm)
@ 2025-07-31 22:12 ` Rob Herring (Arm)
2025-08-01 14:57 ` Eddie James
2025-07-31 22:12 ` [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles Rob Herring (Arm)
` (4 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Rob Herring (Arm) @ 2025-07-31 22:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery,
Benjamin Herrenschmidt, Eddie James, Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
The "fsi-master" compatible has been used inconsistently on FSI masters.
It doesn't have any real use or meaning, so it's easier to drop it
everywhere than add it where missing. It is also not documented by any
schemas (only .txt bindings).
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts | 2 +-
arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 4 ++--
10 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
index f42254ba6aeb..79c6919b3570 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
@@ -54,7 +54,7 @@ video_engine_memory: jpegbuffer {
};
fsi: gpio-fsi {
- compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
+ compatible = "aspeed,ast2500-cf-fsi-master";
#address-cells = <2>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
index 370738572a55..87acbfc0a1b7 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
@@ -63,7 +63,7 @@ sys_err {
};
fsi: gpio-fsi {
- compatible = "fsi-master-gpio", "fsi-master";
+ compatible = "fsi-master-gpio";
#address-cells = <2>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
index 31ff19ef87a0..6c8b966ffccc 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
@@ -165,7 +165,7 @@ fan4 {
};
fsi: gpio-fsi {
- compatible = "fsi-master-gpio", "fsi-master";
+ compatible = "fsi-master-gpio";
#address-cells = <2>;
#size-cells = <0>;
no-gpio-delays;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
index e5b8d07e7622..1b7c25e307bc 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
@@ -77,7 +77,7 @@ attention {
};
fsi: gpio-fsi {
- compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
+ compatible = "aspeed,ast2500-cf-fsi-master";
#address-cells = <2>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
index 45631b47a7b3..c7aa14034dc0 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
@@ -55,7 +55,7 @@ identify {
};
fsi: gpio-fsi {
- compatible = "aspeed,ast2400-cf-fsi-master", "fsi-master";
+ compatible = "aspeed,ast2400-cf-fsi-master";
#address-cells = <2>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
index 2180fa9b6f24..3c03204869e7 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
@@ -68,7 +68,7 @@ power {
};
fsi: gpio-fsi {
- compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
+ compatible = "aspeed,ast2500-cf-fsi-master";
#address-cells = <2>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
index a0e8c97e944a..39d0fe46fd9e 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
@@ -200,7 +200,7 @@ rear-id {
};
fsi: gpio-fsi {
- compatible = "fsi-master-gpio", "fsi-master";
+ compatible = "fsi-master-gpio";
#address-cells = <2>;
#size-cells = <0>;
no-gpio-delays;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
index 8b1e82c8cdfe..89907b628b65 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
@@ -173,7 +173,7 @@ power-button {
};
fsi: gpio-fsi {
- compatible = "fsi-master-gpio", "fsi-master";
+ compatible = "fsi-master-gpio";
#address-cells = <2>;
#size-cells = <0>;
no-gpio-delays;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
index 9904f0a58cfa..9b49b0aa8b35 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
@@ -96,7 +96,7 @@ hdd_fault {
};
fsi: gpio-fsi {
- compatible = "fsi-master-gpio", "fsi-master";
+ compatible = "fsi-master-gpio";
#address-cells = <2>;
#size-cells = <0>;
no-gpio-delays;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
index 8ed715bd53aa..acdb6ae74b27 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
@@ -847,7 +847,7 @@ i2c: bus@1e78a000 {
fsim0: fsi@1e79b000 {
#interrupt-cells = <1>;
- compatible = "aspeed,ast2600-fsi-master", "fsi-master";
+ compatible = "aspeed,ast2600-fsi-master";
reg = <0x1e79b000 0x94>;
interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-names = "default";
@@ -859,7 +859,7 @@ fsim0: fsi@1e79b000 {
fsim1: fsi@1e79b100 {
#interrupt-cells = <1>;
- compatible = "aspeed,ast2600-fsi-master", "fsi-master";
+ compatible = "aspeed,ast2600-fsi-master";
reg = <0x1e79b100 0x94>;
interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-names = "default";
--
2.47.2
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles
2025-07-31 22:12 ` [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles Rob Herring (Arm)
@ 2025-08-01 14:57 ` Eddie James
0 siblings, 0 replies; 14+ messages in thread
From: Eddie James @ 2025-08-01 14:57 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, Benjamin Herrenschmidt,
Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
On 7/31/25 17:12, Rob Herring (Arm) wrote:
> The "fsi-master" compatible has been used inconsistently on FSI masters.
> It doesn't have any real use or meaning, so it's easier to drop it
> everywhere than add it where missing. It is also not documented by any
> schemas (only .txt bindings).
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 4 ++--
> 10 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> index f42254ba6aeb..79c6919b3570 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> @@ -54,7 +54,7 @@ video_engine_memory: jpegbuffer {
> };
>
> fsi: gpio-fsi {
> - compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2500-cf-fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
> index 370738572a55..87acbfc0a1b7 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
> @@ -63,7 +63,7 @@ sys_err {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
> index 31ff19ef87a0..6c8b966ffccc 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
> @@ -165,7 +165,7 @@ fan4 {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
> no-gpio-delays;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> index e5b8d07e7622..1b7c25e307bc 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> @@ -77,7 +77,7 @@ attention {
> };
>
> fsi: gpio-fsi {
> - compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2500-cf-fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
> index 45631b47a7b3..c7aa14034dc0 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
> @@ -55,7 +55,7 @@ identify {
> };
>
> fsi: gpio-fsi {
> - compatible = "aspeed,ast2400-cf-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2400-cf-fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> index 2180fa9b6f24..3c03204869e7 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> @@ -68,7 +68,7 @@ power {
> };
>
> fsi: gpio-fsi {
> - compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2500-cf-fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
> index a0e8c97e944a..39d0fe46fd9e 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
> @@ -200,7 +200,7 @@ rear-id {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
> no-gpio-delays;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
> index 8b1e82c8cdfe..89907b628b65 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
> @@ -173,7 +173,7 @@ power-button {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
> no-gpio-delays;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
> index 9904f0a58cfa..9b49b0aa8b35 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
> @@ -96,7 +96,7 @@ hdd_fault {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
> no-gpio-delays;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> index 8ed715bd53aa..acdb6ae74b27 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> @@ -847,7 +847,7 @@ i2c: bus@1e78a000 {
>
> fsim0: fsi@1e79b000 {
> #interrupt-cells = <1>;
> - compatible = "aspeed,ast2600-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2600-fsi-master";
> reg = <0x1e79b000 0x94>;
> interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> pinctrl-names = "default";
> @@ -859,7 +859,7 @@ fsim0: fsi@1e79b000 {
>
> fsim1: fsi@1e79b100 {
> #interrupt-cells = <1>;
> - compatible = "aspeed,ast2600-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2600-fsi-master";
> reg = <0x1e79b100 0x94>;
> interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> pinctrl-names = "default";
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
2025-07-31 22:12 ` [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays" Rob Herring (Arm)
2025-07-31 22:12 ` [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles Rob Herring (Arm)
@ 2025-07-31 22:12 ` Rob Herring (Arm)
2025-08-01 14:58 ` Eddie James
2025-07-31 22:12 ` [PATCH 4/6] MAINTAINERS: Add FSI bindings to FSI subsystem entry Rob Herring (Arm)
` (3 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Rob Herring (Arm) @ 2025-07-31 22:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery,
Benjamin Herrenschmidt, Eddie James, Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
The "ibm,spi-fsi" compatible is missing or incorrect in various nodes.
The incorrect cases used the "ibm,fsi2spi" compatible by mistake which
is the parent node of the actual SPI controller nodes.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts | 24 ++++++++++++++--------
arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi | 12 +++++++----
arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 12 +++++++----
3 files changed, 32 insertions(+), 16 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
index 9961508ee872..52a044b1e454 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
@@ -2808,6 +2808,7 @@ fsi2spi@1c00 {
#size-cells = <0>;
cfam4_spi0: spi@0 {
+ compatible = "ibm,spi-fsi";
reg = <0x0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2824,6 +2825,7 @@ eeprom@0 {
};
cfam4_spi1: spi@20 {
+ compatible = "ibm,spi-fsi";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2840,8 +2842,8 @@ eeprom@0 {
};
cfam4_spi2: spi@40 {
+ compatible = "ibm,spi-fsi";
reg = <0x40>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -2857,8 +2859,8 @@ eeprom@0 {
};
cfam4_spi3: spi@60 {
+ compatible = "ibm,spi-fsi";
reg = <0x60>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -3181,6 +3183,7 @@ fsi2spi@1c00 {
#size-cells = <0>;
cfam5_spi0: spi@0 {
+ compatible = "ibm,spi-fsi";
reg = <0x0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3197,6 +3200,7 @@ eeprom@0 {
};
cfam5_spi1: spi@20 {
+ compatible = "ibm,spi-fsi";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3213,8 +3217,8 @@ eeprom@0 {
};
cfam5_spi2: spi@40 {
+ compatible = "ibm,spi-fsi";
reg = <0x40>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -3230,8 +3234,8 @@ eeprom@0 {
};
cfam5_spi3: spi@60 {
+ compatible = "ibm,spi-fsi";
reg = <0x60>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -3554,6 +3558,7 @@ fsi2spi@1c00 {
#size-cells = <0>;
cfam6_spi0: spi@0 {
+ compatible = "ibm,spi-fsi";
reg = <0x0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3570,6 +3575,7 @@ eeprom@0 {
};
cfam6_spi1: spi@20 {
+ compatible = "ibm,spi-fsi";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3586,8 +3592,8 @@ eeprom@0 {
};
cfam6_spi2: spi@40 {
+ compatible = "ibm,spi-fsi";
reg = <0x40>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -3603,8 +3609,8 @@ eeprom@0 {
};
cfam6_spi3: spi@60 {
+ compatible = "ibm,spi-fsi";
reg = <0x60>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -3927,6 +3933,7 @@ fsi2spi@1c00 {
#size-cells = <0>;
cfam7_spi0: spi@0 {
+ compatible = "ibm,spi-fsi";
reg = <0x0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3943,6 +3950,7 @@ eeprom@0 {
};
cfam7_spi1: spi@20 {
+ compatible = "ibm,spi-fsi";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3959,8 +3967,8 @@ eeprom@0 {
};
cfam7_spi2: spi@40 {
+ compatible = "ibm,spi-fsi";
reg = <0x40>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -3976,8 +3984,8 @@ eeprom@0 {
};
cfam7_spi3: spi@60 {
+ compatible = "ibm,spi-fsi";
reg = <0x60>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi b/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
index 07ce3b2bc62a..06fac236773f 100644
--- a/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
+++ b/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
@@ -82,6 +82,7 @@ fsi2spi@1c00 {
#size-cells = <0>;
cfam0_spi0: spi@0 {
+ compatible = "ibm,spi-fsi";
reg = <0x0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -98,6 +99,7 @@ eeprom@0 {
};
cfam0_spi1: spi@20 {
+ compatible = "ibm,spi-fsi";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -114,8 +116,8 @@ eeprom@0 {
};
cfam0_spi2: spi@40 {
+ compatible = "ibm,spi-fsi";
reg = <0x40>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -131,8 +133,8 @@ eeprom@0 {
};
cfam0_spi3: spi@60 {
+ compatible = "ibm,spi-fsi";
reg = <0x60>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -249,6 +251,7 @@ fsi2spi@1c00 {
#size-cells = <0>;
cfam1_spi0: spi@0 {
+ compatible = "ibm,spi-fsi";
reg = <0x0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -265,6 +268,7 @@ eeprom@0 {
};
cfam1_spi1: spi@20 {
+ compatible = "ibm,spi-fsi";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -281,8 +285,8 @@ eeprom@0 {
};
cfam1_spi2: spi@40 {
+ compatible = "ibm,spi-fsi";
reg = <0x40>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -298,8 +302,8 @@ eeprom@0 {
};
cfam1_spi3: spi@60 {
+ compatible = "ibm,spi-fsi";
reg = <0x60>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi b/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
index 57494c744b5d..9501f66d0030 100644
--- a/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
+++ b/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
@@ -733,6 +733,7 @@ fsi2spi@1c00 {
#size-cells = <0>;
cfam2_spi0: spi@0 {
+ compatible = "ibm,spi-fsi";
reg = <0x0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -749,6 +750,7 @@ eeprom@0 {
};
cfam2_spi1: spi@20 {
+ compatible = "ibm,spi-fsi";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -765,8 +767,8 @@ eeprom@0 {
};
cfam2_spi2: spi@40 {
+ compatible = "ibm,spi-fsi";
reg = <0x40>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -782,8 +784,8 @@ eeprom@0 {
};
cfam2_spi3: spi@60 {
+ compatible = "ibm,spi-fsi";
reg = <0x60>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -1106,6 +1108,7 @@ fsi2spi@1c00 {
#size-cells = <0>;
cfam3_spi0: spi@0 {
+ compatible = "ibm,spi-fsi";
reg = <0x0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -1122,6 +1125,7 @@ eeprom@0 {
};
cfam3_spi1: spi@20 {
+ compatible = "ibm,spi-fsi";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -1138,8 +1142,8 @@ eeprom@0 {
};
cfam3_spi2: spi@40 {
+ compatible = "ibm,spi-fsi";
reg = <0x40>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
@@ -1155,8 +1159,8 @@ eeprom@0 {
};
cfam3_spi3: spi@60 {
+ compatible = "ibm,spi-fsi";
reg = <0x60>;
- compatible = "ibm,fsi2spi";
#address-cells = <1>;
#size-cells = <0>;
--
2.47.2
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles
2025-07-31 22:12 ` [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles Rob Herring (Arm)
@ 2025-08-01 14:58 ` Eddie James
0 siblings, 0 replies; 14+ messages in thread
From: Eddie James @ 2025-08-01 14:58 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, Benjamin Herrenschmidt,
Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
On 7/31/25 17:12, Rob Herring (Arm) wrote:
> The "ibm,spi-fsi" compatible is missing or incorrect in various nodes.
> The incorrect cases used the "ibm,fsi2spi" compatible by mistake which
> is the parent node of the actual SPI controller nodes.
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts | 24 ++++++++++++++--------
> arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi | 12 +++++++----
> arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 12 +++++++----
> 3 files changed, 32 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> index 9961508ee872..52a044b1e454 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> @@ -2808,6 +2808,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam4_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2824,6 +2825,7 @@ eeprom@0 {
> };
>
> cfam4_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2840,8 +2842,8 @@ eeprom@0 {
> };
>
> cfam4_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -2857,8 +2859,8 @@ eeprom@0 {
> };
>
> cfam4_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3181,6 +3183,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam5_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3197,6 +3200,7 @@ eeprom@0 {
> };
>
> cfam5_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3213,8 +3217,8 @@ eeprom@0 {
> };
>
> cfam5_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3230,8 +3234,8 @@ eeprom@0 {
> };
>
> cfam5_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3554,6 +3558,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam6_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3570,6 +3575,7 @@ eeprom@0 {
> };
>
> cfam6_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3586,8 +3592,8 @@ eeprom@0 {
> };
>
> cfam6_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3603,8 +3609,8 @@ eeprom@0 {
> };
>
> cfam6_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3927,6 +3933,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam7_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3943,6 +3950,7 @@ eeprom@0 {
> };
>
> cfam7_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3959,8 +3967,8 @@ eeprom@0 {
> };
>
> cfam7_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -3976,8 +3984,8 @@ eeprom@0 {
> };
>
> cfam7_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi b/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
> index 07ce3b2bc62a..06fac236773f 100644
> --- a/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
> +++ b/arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi
> @@ -82,6 +82,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam0_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -98,6 +99,7 @@ eeprom@0 {
> };
>
> cfam0_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -114,8 +116,8 @@ eeprom@0 {
> };
>
> cfam0_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -131,8 +133,8 @@ eeprom@0 {
> };
>
> cfam0_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -249,6 +251,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam1_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -265,6 +268,7 @@ eeprom@0 {
> };
>
> cfam1_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -281,8 +285,8 @@ eeprom@0 {
> };
>
> cfam1_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -298,8 +302,8 @@ eeprom@0 {
> };
>
> cfam1_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi b/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
> index 57494c744b5d..9501f66d0030 100644
> --- a/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
> +++ b/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
> @@ -733,6 +733,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam2_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -749,6 +750,7 @@ eeprom@0 {
> };
>
> cfam2_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -765,8 +767,8 @@ eeprom@0 {
> };
>
> cfam2_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -782,8 +784,8 @@ eeprom@0 {
> };
>
> cfam2_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -1106,6 +1108,7 @@ fsi2spi@1c00 {
> #size-cells = <0>;
>
> cfam3_spi0: spi@0 {
> + compatible = "ibm,spi-fsi";
> reg = <0x0>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -1122,6 +1125,7 @@ eeprom@0 {
> };
>
> cfam3_spi1: spi@20 {
> + compatible = "ibm,spi-fsi";
> reg = <0x20>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -1138,8 +1142,8 @@ eeprom@0 {
> };
>
> cfam3_spi2: spi@40 {
> + compatible = "ibm,spi-fsi";
> reg = <0x40>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -1155,8 +1159,8 @@ eeprom@0 {
> };
>
> cfam3_spi3: spi@60 {
> + compatible = "ibm,spi-fsi";
> reg = <0x60>;
> - compatible = "ibm,fsi2spi";
> #address-cells = <1>;
> #size-cells = <0>;
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/6] MAINTAINERS: Add FSI bindings to FSI subsystem entry
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
` (2 preceding siblings ...)
2025-07-31 22:12 ` [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles Rob Herring (Arm)
@ 2025-07-31 22:12 ` Rob Herring (Arm)
2025-08-01 14:59 ` Eddie James
2025-07-31 22:12 ` [PATCH 5/6] dt-bindings: fsi: Convert fsi-master-gpio to DT schema Rob Herring (Arm)
` (2 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Rob Herring (Arm) @ 2025-07-31 22:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery,
Benjamin Herrenschmidt, Eddie James, Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
Maintainers of a subsystem should also be the maintainer for
corresponding DT bindings. Add the FSI bindings to the FSI subsystem
entry.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a92290fffa16..4a7b4656822c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9810,6 +9810,7 @@ R: Ninad Palsule <ninad@linux.ibm.com>
L: linux-fsi@lists.ozlabs.org
S: Supported
Q: http://patchwork.ozlabs.org/project/linux-fsi/list/
+F: Documentation/devicetree/bindings/fsi/
F: drivers/fsi/
F: include/linux/fsi*.h
F: include/trace/events/fsi*.h
--
2.47.2
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 4/6] MAINTAINERS: Add FSI bindings to FSI subsystem entry
2025-07-31 22:12 ` [PATCH 4/6] MAINTAINERS: Add FSI bindings to FSI subsystem entry Rob Herring (Arm)
@ 2025-08-01 14:59 ` Eddie James
0 siblings, 0 replies; 14+ messages in thread
From: Eddie James @ 2025-08-01 14:59 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, Benjamin Herrenschmidt,
Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
On 7/31/25 17:12, Rob Herring (Arm) wrote:
> Maintainers of a subsystem should also be the maintainer for
> corresponding DT bindings. Add the FSI bindings to the FSI subsystem
> entry.
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a92290fffa16..4a7b4656822c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9810,6 +9810,7 @@ R: Ninad Palsule <ninad@linux.ibm.com>
> L: linux-fsi@lists.ozlabs.org
> S: Supported
> Q: http://patchwork.ozlabs.org/project/linux-fsi/list/
> +F: Documentation/devicetree/bindings/fsi/
> F: drivers/fsi/
> F: include/linux/fsi*.h
> F: include/trace/events/fsi*.h
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 5/6] dt-bindings: fsi: Convert fsi-master-gpio to DT schema
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
` (3 preceding siblings ...)
2025-07-31 22:12 ` [PATCH 4/6] MAINTAINERS: Add FSI bindings to FSI subsystem entry Rob Herring (Arm)
@ 2025-07-31 22:12 ` Rob Herring (Arm)
2025-08-01 15:01 ` Eddie James
2025-07-31 22:12 ` [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master " Rob Herring (Arm)
2025-08-04 1:38 ` [PATCH 0/6] ASpeed FSI DT clean-ups Andrew Jeffery
6 siblings, 1 reply; 14+ messages in thread
From: Rob Herring (Arm) @ 2025-07-31 22:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery,
Benjamin Herrenschmidt, Eddie James, Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
Convert the GPIO-based FSI master binding to DT schema format.
Drop the "fsi-master" compatible as it has not be used consistently and
doesn't represent anything.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../devicetree/bindings/fsi/fsi-master-gpio.txt | 28 ----------
.../devicetree/bindings/fsi/fsi-master-gpio.yaml | 63 ++++++++++++++++++++++
2 files changed, 63 insertions(+), 28 deletions(-)
diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-gpio.txt b/Documentation/devicetree/bindings/fsi/fsi-master-gpio.txt
deleted file mode 100644
index 1e442450747f..000000000000
--- a/Documentation/devicetree/bindings/fsi/fsi-master-gpio.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Device-tree bindings for gpio-based FSI master driver
------------------------------------------------------
-
-Required properties:
- - compatible = "fsi-master-gpio";
- - clock-gpios = <gpio-descriptor>; : GPIO for FSI clock
- - data-gpios = <gpio-descriptor>; : GPIO for FSI data signal
-
-Optional properties:
- - enable-gpios = <gpio-descriptor>; : GPIO for enable signal
- - trans-gpios = <gpio-descriptor>; : GPIO for voltage translator enable
- - mux-gpios = <gpio-descriptor>; : GPIO for pin multiplexing with other
- functions (eg, external FSI masters)
- - no-gpio-delays; : Don't add extra delays between GPIO
- accesses. This is useful when the HW
- GPIO block is running at a low enough
- frequency.
-
-Examples:
-
- fsi-master {
- compatible = "fsi-master-gpio", "fsi-master";
- clock-gpios = <&gpio 0>;
- data-gpios = <&gpio 1>;
- enable-gpios = <&gpio 2>;
- trans-gpios = <&gpio 3>;
- mux-gpios = <&gpio 4>;
- }
diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-gpio.yaml b/Documentation/devicetree/bindings/fsi/fsi-master-gpio.yaml
new file mode 100644
index 000000000000..21bfbad595b3
--- /dev/null
+++ b/Documentation/devicetree/bindings/fsi/fsi-master-gpio.yaml
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/fsi/fsi-master-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: fsi-master-gpio
+
+maintainers:
+ - Eddie James <eajames@linux.ibm.com>
+
+allOf:
+ - $ref: /schemas/fsi/fsi-controller.yaml
+
+properties:
+ compatible:
+ items:
+ - const: fsi-master-gpio
+
+ clock-gpios:
+ description: GPIO for FSI clock
+ maxItems: 1
+
+ data-gpios:
+ description: GPIO for FSI data signal
+ maxItems: 1
+
+ enable-gpios:
+ description: GPIO for enable signal
+ maxItems: 1
+
+ trans-gpios:
+ description: GPIO for voltage translator enable
+ maxItems: 1
+
+ mux-gpios:
+ description: GPIO for pin multiplexing with other functions (eg, external
+ FSI masters)
+ maxItems: 1
+
+ no-gpio-delays:
+ description:
+ Don't add extra delays between GPIO accesses. This is useful when the HW
+ GPIO block is running at a low enough frequency.
+ type: boolean
+
+required:
+ - compatible
+ - clock-gpios
+ - data-gpios
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ fsi-master {
+ compatible = "fsi-master-gpio";
+ clock-gpios = <&gpio 0>;
+ data-gpios = <&gpio 1>;
+ enable-gpios = <&gpio 2>;
+ trans-gpios = <&gpio 3>;
+ mux-gpios = <&gpio 4>;
+ };
--
2.47.2
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 5/6] dt-bindings: fsi: Convert fsi-master-gpio to DT schema
2025-07-31 22:12 ` [PATCH 5/6] dt-bindings: fsi: Convert fsi-master-gpio to DT schema Rob Herring (Arm)
@ 2025-08-01 15:01 ` Eddie James
0 siblings, 0 replies; 14+ messages in thread
From: Eddie James @ 2025-08-01 15:01 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, Benjamin Herrenschmidt,
Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
On 7/31/25 17:12, Rob Herring (Arm) wrote:
> Convert the GPIO-based FSI master binding to DT schema format.
>
> Drop the "fsi-master" compatible as it has not be used consistently and
> doesn't represent anything.
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../devicetree/bindings/fsi/fsi-master-gpio.txt | 28 ----------
> .../devicetree/bindings/fsi/fsi-master-gpio.yaml | 63 ++++++++++++++++++++++
> 2 files changed, 63 insertions(+), 28 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-gpio.txt b/Documentation/devicetree/bindings/fsi/fsi-master-gpio.txt
> deleted file mode 100644
> index 1e442450747f..000000000000
> --- a/Documentation/devicetree/bindings/fsi/fsi-master-gpio.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Device-tree bindings for gpio-based FSI master driver
> ------------------------------------------------------
> -
> -Required properties:
> - - compatible = "fsi-master-gpio";
> - - clock-gpios = <gpio-descriptor>; : GPIO for FSI clock
> - - data-gpios = <gpio-descriptor>; : GPIO for FSI data signal
> -
> -Optional properties:
> - - enable-gpios = <gpio-descriptor>; : GPIO for enable signal
> - - trans-gpios = <gpio-descriptor>; : GPIO for voltage translator enable
> - - mux-gpios = <gpio-descriptor>; : GPIO for pin multiplexing with other
> - functions (eg, external FSI masters)
> - - no-gpio-delays; : Don't add extra delays between GPIO
> - accesses. This is useful when the HW
> - GPIO block is running at a low enough
> - frequency.
> -
> -Examples:
> -
> - fsi-master {
> - compatible = "fsi-master-gpio", "fsi-master";
> - clock-gpios = <&gpio 0>;
> - data-gpios = <&gpio 1>;
> - enable-gpios = <&gpio 2>;
> - trans-gpios = <&gpio 3>;
> - mux-gpios = <&gpio 4>;
> - }
> diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-gpio.yaml b/Documentation/devicetree/bindings/fsi/fsi-master-gpio.yaml
> new file mode 100644
> index 000000000000..21bfbad595b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/fsi-master-gpio.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fsi/fsi-master-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: fsi-master-gpio
> +
> +maintainers:
> + - Eddie James <eajames@linux.ibm.com>
> +
> +allOf:
> + - $ref: /schemas/fsi/fsi-controller.yaml
> +
> +properties:
> + compatible:
> + items:
> + - const: fsi-master-gpio
> +
> + clock-gpios:
> + description: GPIO for FSI clock
> + maxItems: 1
> +
> + data-gpios:
> + description: GPIO for FSI data signal
> + maxItems: 1
> +
> + enable-gpios:
> + description: GPIO for enable signal
> + maxItems: 1
> +
> + trans-gpios:
> + description: GPIO for voltage translator enable
> + maxItems: 1
> +
> + mux-gpios:
> + description: GPIO for pin multiplexing with other functions (eg, external
> + FSI masters)
> + maxItems: 1
> +
> + no-gpio-delays:
> + description:
> + Don't add extra delays between GPIO accesses. This is useful when the HW
> + GPIO block is running at a low enough frequency.
> + type: boolean
> +
> +required:
> + - compatible
> + - clock-gpios
> + - data-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + fsi-master {
> + compatible = "fsi-master-gpio";
> + clock-gpios = <&gpio 0>;
> + data-gpios = <&gpio 1>;
> + enable-gpios = <&gpio 2>;
> + trans-gpios = <&gpio 3>;
> + mux-gpios = <&gpio 4>;
> + };
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master to DT schema
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
` (4 preceding siblings ...)
2025-07-31 22:12 ` [PATCH 5/6] dt-bindings: fsi: Convert fsi-master-gpio to DT schema Rob Herring (Arm)
@ 2025-07-31 22:12 ` Rob Herring (Arm)
2025-08-01 15:03 ` Eddie James
2025-08-04 1:38 ` [PATCH 0/6] ASpeed FSI DT clean-ups Andrew Jeffery
6 siblings, 1 reply; 14+ messages in thread
From: Rob Herring (Arm) @ 2025-07-31 22:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery,
Benjamin Herrenschmidt, Eddie James, Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
Convert the ASpeed Coldfire offloaded GPIO FSI master.
Drop the "fsi-master" compatible as it has not be used consistently and
doesn't represent anything.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml | 81 ++++++++++++++++++++++
.../devicetree/bindings/fsi/fsi-master-ast-cf.txt | 36 ----------
2 files changed, 81 insertions(+), 36 deletions(-)
diff --git a/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml b/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml
new file mode 100644
index 000000000000..690b6c936f18
--- /dev/null
+++ b/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/fsi/aspeed,ast2400-cf-fsi-master.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASpeed ColdFire offloaded GPIO-based FSI master
+
+maintainers:
+ - Eddie James <eajames@linux.ibm.com>
+
+allOf:
+ - $ref: /schemas/fsi/fsi-controller.yaml#
+
+properties:
+ compatible:
+ enum:
+ - aspeed,ast2400-cf-fsi-master
+ - aspeed,ast2500-cf-fsi-master
+
+ clock-gpios:
+ maxItems: 1
+ description: GPIO for FSI clock
+
+ data-gpios:
+ maxItems: 1
+ description: GPIO for FSI data signal
+
+ enable-gpios:
+ maxItems: 1
+ description: GPIO for enable signal
+
+ trans-gpios:
+ maxItems: 1
+ description: GPIO for voltage translator enable
+
+ mux-gpios:
+ maxItems: 1
+ description:
+ GPIO for pin multiplexing with other functions (eg, external FSI masters)
+
+ memory-region:
+ maxItems: 1
+ description:
+ Reference to the reserved memory for the ColdFire. Must be 2M aligned on
+ AST2400 and 1M aligned on AST2500.
+
+ aspeed,cvic:
+ description: Reference to the CVIC node.
+ $ref: /schemas/types.yaml#/definitions/phandle
+
+ aspeed,sram:
+ description: Reference to the SRAM node.
+ $ref: /schemas/types.yaml#/definitions/phandle
+
+required:
+ - compatible
+ - clock-gpios
+ - data-gpios
+ - enable-gpios
+ - trans-gpios
+ - mux-gpios
+ - memory-region
+ - aspeed,cvic
+ - aspeed,sram
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ fsi-master {
+ compatible = "aspeed,ast2500-cf-fsi-master";
+ clock-gpios = <&gpio 0>;
+ data-gpios = <&gpio 1>;
+ enable-gpios = <&gpio 2>;
+ trans-gpios = <&gpio 3>;
+ mux-gpios = <&gpio 4>;
+ memory-region = <&coldfire_memory>;
+ aspeed,cvic = <&cvic>;
+ aspeed,sram = <&sram>;
+ };
diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt b/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt
deleted file mode 100644
index 3dc752db748b..000000000000
--- a/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt
+++ /dev/null
@@ -1,36 +0,0 @@
-Device-tree bindings for ColdFire offloaded gpio-based FSI master driver
-------------------------------------------------------------------------
-
-Required properties:
- - compatible =
- "aspeed,ast2400-cf-fsi-master" for an AST2400 based system
- or
- "aspeed,ast2500-cf-fsi-master" for an AST2500 based system
-
- - clock-gpios = <gpio-descriptor>; : GPIO for FSI clock
- - data-gpios = <gpio-descriptor>; : GPIO for FSI data signal
- - enable-gpios = <gpio-descriptor>; : GPIO for enable signal
- - trans-gpios = <gpio-descriptor>; : GPIO for voltage translator enable
- - mux-gpios = <gpio-descriptor>; : GPIO for pin multiplexing with other
- functions (eg, external FSI masters)
- - memory-region = <phandle>; : Reference to the reserved memory for
- the ColdFire. Must be 2M aligned on
- AST2400 and 1M aligned on AST2500
- - aspeed,sram = <phandle>; : Reference to the SRAM node.
- - aspeed,cvic = <phandle>; : Reference to the CVIC node.
-
-Examples:
-
- fsi-master {
- compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
-
- clock-gpios = <&gpio 0>;
- data-gpios = <&gpio 1>;
- enable-gpios = <&gpio 2>;
- trans-gpios = <&gpio 3>;
- mux-gpios = <&gpio 4>;
-
- memory-region = <&coldfire_memory>;
- aspeed,sram = <&sram>;
- aspeed,cvic = <&cvic>;
- }
--
2.47.2
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master to DT schema
2025-07-31 22:12 ` [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master " Rob Herring (Arm)
@ 2025-08-01 15:03 ` Eddie James
0 siblings, 0 replies; 14+ messages in thread
From: Eddie James @ 2025-08-01 15:03 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, Benjamin Herrenschmidt,
Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
On 7/31/25 17:12, Rob Herring (Arm) wrote:
> Convert the ASpeed Coldfire offloaded GPIO FSI master.
>
> Drop the "fsi-master" compatible as it has not be used consistently and
> doesn't represent anything.
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml | 81 ++++++++++++++++++++++
> .../devicetree/bindings/fsi/fsi-master-ast-cf.txt | 36 ----------
> 2 files changed, 81 insertions(+), 36 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml b/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml
> new file mode 100644
> index 000000000000..690b6c936f18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fsi/aspeed,ast2400-cf-fsi-master.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ASpeed ColdFire offloaded GPIO-based FSI master
> +
> +maintainers:
> + - Eddie James <eajames@linux.ibm.com>
> +
> +allOf:
> + - $ref: /schemas/fsi/fsi-controller.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2400-cf-fsi-master
> + - aspeed,ast2500-cf-fsi-master
> +
> + clock-gpios:
> + maxItems: 1
> + description: GPIO for FSI clock
> +
> + data-gpios:
> + maxItems: 1
> + description: GPIO for FSI data signal
> +
> + enable-gpios:
> + maxItems: 1
> + description: GPIO for enable signal
> +
> + trans-gpios:
> + maxItems: 1
> + description: GPIO for voltage translator enable
> +
> + mux-gpios:
> + maxItems: 1
> + description:
> + GPIO for pin multiplexing with other functions (eg, external FSI masters)
> +
> + memory-region:
> + maxItems: 1
> + description:
> + Reference to the reserved memory for the ColdFire. Must be 2M aligned on
> + AST2400 and 1M aligned on AST2500.
> +
> + aspeed,cvic:
> + description: Reference to the CVIC node.
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> + aspeed,sram:
> + description: Reference to the SRAM node.
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> + - compatible
> + - clock-gpios
> + - data-gpios
> + - enable-gpios
> + - trans-gpios
> + - mux-gpios
> + - memory-region
> + - aspeed,cvic
> + - aspeed,sram
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + fsi-master {
> + compatible = "aspeed,ast2500-cf-fsi-master";
> + clock-gpios = <&gpio 0>;
> + data-gpios = <&gpio 1>;
> + enable-gpios = <&gpio 2>;
> + trans-gpios = <&gpio 3>;
> + mux-gpios = <&gpio 4>;
> + memory-region = <&coldfire_memory>;
> + aspeed,cvic = <&cvic>;
> + aspeed,sram = <&sram>;
> + };
> diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt b/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt
> deleted file mode 100644
> index 3dc752db748b..000000000000
> --- a/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -Device-tree bindings for ColdFire offloaded gpio-based FSI master driver
> -------------------------------------------------------------------------
> -
> -Required properties:
> - - compatible =
> - "aspeed,ast2400-cf-fsi-master" for an AST2400 based system
> - or
> - "aspeed,ast2500-cf-fsi-master" for an AST2500 based system
> -
> - - clock-gpios = <gpio-descriptor>; : GPIO for FSI clock
> - - data-gpios = <gpio-descriptor>; : GPIO for FSI data signal
> - - enable-gpios = <gpio-descriptor>; : GPIO for enable signal
> - - trans-gpios = <gpio-descriptor>; : GPIO for voltage translator enable
> - - mux-gpios = <gpio-descriptor>; : GPIO for pin multiplexing with other
> - functions (eg, external FSI masters)
> - - memory-region = <phandle>; : Reference to the reserved memory for
> - the ColdFire. Must be 2M aligned on
> - AST2400 and 1M aligned on AST2500
> - - aspeed,sram = <phandle>; : Reference to the SRAM node.
> - - aspeed,cvic = <phandle>; : Reference to the CVIC node.
> -
> -Examples:
> -
> - fsi-master {
> - compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> -
> - clock-gpios = <&gpio 0>;
> - data-gpios = <&gpio 1>;
> - enable-gpios = <&gpio 2>;
> - trans-gpios = <&gpio 3>;
> - mux-gpios = <&gpio 4>;
> -
> - memory-region = <&coldfire_memory>;
> - aspeed,sram = <&sram>;
> - aspeed,cvic = <&cvic>;
> - }
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/6] ASpeed FSI DT clean-ups
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
` (5 preceding siblings ...)
2025-07-31 22:12 ` [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master " Rob Herring (Arm)
@ 2025-08-04 1:38 ` Andrew Jeffery
6 siblings, 0 replies; 14+ messages in thread
From: Andrew Jeffery @ 2025-08-04 1:38 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Benjamin Herrenschmidt, Eddie James, Ninad Palsule
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-fsi
Hi Rob,
On Thu, 2025-07-31 at 17:12 -0500, Rob Herring (Arm) wrote:
> There's a whole bunch of FSI related DT warnings on ASpeed platforms.
> This series fixes most of them except some related to SBEFIFO.
>
> The remaining SBEFIFO warnings are from some deprecated properties noted
> with 'remove when userspace is fixed'. Not sure if they can be removed
> now or soon. If not, perhaps the deprecated properties need to be
> properly documented.
>
> All the patches here are independent, so DTS changes can go via ASpeed
> tree and FSI bindings via FSI tree (or ack if you want me to take the
> bindings instead).
>
> Rob
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Rob Herring (Arm) (6):
> ARM: dts: aspeed: Drop "no-gpio-delays"
> ARM: dts: aspeed: Drop "fsi-master" compatibles
> ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles
Thanks for this. I've applied patches 1-3 to the BMC tree. I'll leave
the binding changes for you to take as indicated by Eddie in his
response on patch 1.
Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread