linux-aspeed.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Winiarska, Iwona <iwona.winiarska@intel.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases
Date: Fri, 5 Nov 2021 17:05:18 +0000	[thread overview]
Message-ID: <6057e8fe3bc84c719e0dc3cc4753a472ac92a8bf.camel@intel.com> (raw)
In-Reply-To: <20211104173709.222912-1-jae.hyun.yoo@intel.com>

On Thu, 2021-11-04 at 10:37 -0700, jae.hyun.yoo at intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> 
> Add a checking code when it gets -EPROBE_DEFER while getting a clock
> resource. In this case, it doesn't need to print out an error message
> because the probing will be re-visited.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>

-Iwona

> ---
> v1 -> v2:
> ?* Simplified it using dev_err_probe. (Iwona)
> 
> ?drivers/soc/aspeed/aspeed-lpc-ctrl.c | 7 +++----
> ?1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/aspeed/aspeed-lpc-ctrl.c b/drivers/soc/aspeed/aspeed-
> lpc-ctrl.c
> index 72771e018c42..258894ed234b 100644
> --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c
> +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c
> @@ -306,10 +306,9 @@ static int aspeed_lpc_ctrl_probe(struct platform_device
> *pdev)
> ????????}
> ?
> ????????lpc_ctrl->clk = devm_clk_get(dev, NULL);
> -???????if (IS_ERR(lpc_ctrl->clk)) {
> -???????????????dev_err(dev, "couldn't get clock\n");
> -???????????????return PTR_ERR(lpc_ctrl->clk);
> -???????}
> +???????if (IS_ERR(lpc_ctrl->clk))
> +???????????????return dev_err_probe(dev, PTR_ERR(lpc_ctrl->clk),
> +??????????????????????????????????? "couldn't get clock\n");
> ????????rc = clk_prepare_enable(lpc_ctrl->clk);
> ????????if (rc) {
> ????????????????dev_err(dev, "couldn't enable clock\n");


  reply	other threads:[~2021-11-05 17:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 17:37 [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases jae.hyun.yoo
2021-11-05 17:05 ` Winiarska, Iwona [this message]
2021-11-05 17:08   ` Jae Hyun Yoo
2021-11-08  0:29 ` Andrew Jeffery
2021-11-08 18:45   ` Jae Hyun Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6057e8fe3bc84c719e0dc3cc4753a472ac92a8bf.camel@intel.com \
    --to=iwona.winiarska@intel.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).