public inbox for linux-aspeed@lists.ozlabs.org
 help / color / mirror / Atom feed
From: Tao Ren <taoren@fb.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout
Date: Thu, 8 Nov 2018 02:31:32 +0000	[thread overview]
Message-ID: <62de5dcd-e8a2-9572-3b0b-fc3ca9d1875c@fb.com> (raw)
In-Reply-To: <1541641556.1495362.1569509568.7BE039CA@webmail.messagingengine.com>

On 11/7/18 5:45 PM, Andrew Jeffery wrote:

>>> Is this necessary? Isn't the same thing achieved with the /dev/mtd0 device?
>>
>> Hi Andrew,
>>
>> Thank you for the review! The new layout file is needed mainly because 
>> of "data0" partition: several facebook platforms use the partition as 
>> "persistent" storage.
>>
>> As for "flash0", technically it's not needed (as you pointed out, /dev/
>> mtd0 covers the entire flash if master_partition is enabled). It's still 
>> here to avoid breaking some legacy applications.
> 
> This is what I expected. I think it might be worth adding a comment, given
> you are respinning the series to address my comments on the board
> devicetree patch.
> 
> Anyway, thanks for the clarification.
> 
> Andrew

Sure Andrew. I will add some comments and send out 2 updated patches together (most likely sometime tomorrow).

Thanks,
Tao Ren

      reply	other threads:[~2018-11-08  2:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06  4:28 [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout Tao Ren
2018-11-08  0:02 ` Andrew Jeffery
2018-11-08  0:18   ` Tao Ren
2018-11-08  1:45     ` Andrew Jeffery
2018-11-08  2:31       ` Tao Ren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62de5dcd-e8a2-9572-3b0b-fc3ca9d1875c@fb.com \
    --to=taoren@fb.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox