Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Ninad Palsule <ninad@linux.ibm.com>,
	eajames@linux.ibm.com, robh@kernel.org, 	krzk+dt@kernel.org,
	conor+dt@kernel.org, joel@jms.id.au,  devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 7/7] ARM: dts: aspeed: system1: DTS updates
Date: Mon, 18 May 2026 21:04:40 +0930	[thread overview]
Message-ID: <642d8a490626d4e62473baa37bef04ce85bddb96.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260421224551.1611818-8-ninad@linux.ibm.com>

Hi Ninad,

On Tue, 2026-04-21 at 17:45 -0500, Ninad Palsule wrote:
> - Removed SGPIO node as not in use anymore.
> - Updated chassis power related pins as per the new hardware design

Can you please take a look at the discussion in the thread linked
below, and consider some of the approaches outlined there?

https://lore.kernel.org/all/d7794f74b26bbc1ee0a70e39c5671acc018f80eb.camel@codeconstruct.com.au/

I'd like to avoid a stream of backwards-incompatible changes due to
platform design changes where we can.

Andrew

> 
> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> index 91c317267d6b..d7a934fe5860 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> @@ -424,7 +424,7 @@ &pinctrl_gpiol6_unbiased
>  	/*E0-E7*/	"","","","","","","","",
>  	/*F0-F7*/	"","","","","","","","",
>  	/*G0-G7*/	"","","","","","","","",
> -	/*H0-H7*/	"","","","","","","","",
> +	/*H0-H7*/	"power-chassis-good","power-chassis-reboot","","","","","","",
>  	/*I0-I7*/	"","","","","","","","",
>  	/*J0-J7*/	"","","","","","","","",
>  	/*K0-K7*/	"","","","","","","","",
> @@ -440,7 +440,7 @@ &pinctrl_gpiol6_unbiased
>  	/*U0-U7*/	"","","","","","","","",
>  	/*V0-V7*/	"","rtc-battery-voltage-read-enable","","power-chassis-control","","","","",
>  	/*W0-W7*/	"","","","","","","","",
> -	/*X0-X7*/	"fpga-pgood","power-chassis-good","pch-pgood","","","","","",
> +	/*X0-X7*/	"fpga-pgood","","pch-pgood","","","","","",
>  	/*Y0-Y7*/	"","","","","","","","",
>  	/*Z0-Z7*/	"","","","","","","","";
>  
> @@ -486,12 +486,6 @@ &emmc {
>  	clk-phase-mmc-hs200 = <180>, <180>;
>  };
>  
> -&sgpiom0 {
> -	status = "okay";
> -	ngpios = <128>;
> -	bus-frequency = <500000>;
> -};
> -
>  &ibt {
>  	status = "okay";
>  };


      reply	other threads:[~2026-05-18 11:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 22:45 [PATCH v1 0/7] DTS updates for system1 BMC Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 1/7] ARM: dts: aspeed: system1: Disable vuart2 Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 2/7] ARM: dts: aspeed: system1: Enable video engine Ninad Palsule
2026-05-18 11:38   ` Andrew Jeffery
2026-04-21 22:45 ` [PATCH v1 3/7] ARM: dts: aspeed: system1: Add usb virtual hub dev Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 4/7] ARM: dts: aspeed: system1: Enable temp sensors Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 5/7] ARM: dts: aspeed: system1: disable NCSI net port Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 6/7] ARM: dts: aspeed: system1: Added status LEDs Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 7/7] ARM: dts: aspeed: system1: DTS updates Ninad Palsule
2026-05-18 11:34   ` Andrew Jeffery [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=642d8a490626d4e62473baa37bef04ce85bddb96.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eajames@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ninad@linux.ibm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox