Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kevin Chen <kevin_chen@aspeedtech.com>,
	lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
	chiawei_wang@aspeedtech.com, linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-binding: aspeed: Add LPC PCC controller
Date: Mon, 17 Feb 2025 12:56:09 +0100	[thread overview]
Message-ID: <6ab0afc3-dcfa-4ae8-a695-b8b3864c0a6e@kernel.org> (raw)
In-Reply-To: <20250217114831.3225970-2-kevin_chen@aspeedtech.com>

On 17/02/2025 12:48, Kevin Chen wrote:
> Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
> 
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
> ---
>  .../devicetree/bindings/mfd/aspeed-lpc.yaml   | 36 +++++++++++++++++++

Nothing improved. You will not get different review.

Also, provide detailed changelog explaining how you fixed here
previously reported issues.


<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof


  reply	other threads:[~2025-02-17 11:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 11:48 [PATCH v1 0/3] Add AST2600 LPC PCC support Kevin Chen
2025-02-17 11:48 ` [PATCH v1 1/3] dt-binding: aspeed: Add LPC PCC controller Kevin Chen
2025-02-17 11:56   ` Krzysztof Kozlowski [this message]
2025-02-17 11:48 ` [PATCH v1 2/3] ARM: dts: aspeed-g6: Add AST2600 LPC PCC support Kevin Chen
2025-02-17 11:48 ` [PATCH v1 3/3] soc: aspeed: lpc-pcc: Add PCC controller support Kevin Chen
2025-02-17 12:00   ` Krzysztof Kozlowski
2025-02-18  0:56     ` Andrew Jeffery
2025-02-18 11:11       ` Kevin Chen
2025-02-19  1:04         ` Andrew Jeffery
2025-02-19 11:59           ` Kevin Chen
2025-02-20  1:22             ` Andrew Jeffery
2025-02-21  0:51               ` Kevin Chen
2025-02-25  4:27                 ` Andrew Jeffery
2025-02-25  4:34                   ` Mo Elbadry
2025-02-25 23:28                     ` Andrew Jeffery
2025-02-26  0:48                       ` Mo Elbadry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ab0afc3-dcfa-4ae8-a695-b8b3864c0a6e@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=chiawei_wang@aspeedtech.com \
    --cc=conor+dt@kernel.org \
    --cc=joel@jms.id.au \
    --cc=kevin_chen@aspeedtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox