Re: [PATCH v9 2/2] ARM: dts: aspeed: ventura: add Meta Ventura BMC

[Andrew Jeffery <andrew@codeconstruct.com.au>]

On Wed, 2025-07-16 at 17:43 +0800, P.K. Lee wrote:
> Add Linux device tree related to Meta (Facebook) Ventura specific
> devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to
> detect liquid leakage from all compute trays, switch trays and rack
> sensors within the rack, log the events, and take necessary actions
> accordingly.
> 
> Signed-off-by: P.K. Lee <pkleequanta@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed/Makefile             |    1 +
>  .../aspeed/aspeed-bmc-facebook-ventura.dts    | 1553 +++++++++++++++++
>  2 files changed, 1554 insertions(+)
>  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
> 
> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile
> index c4f064e4b073..5ed6042eea97 100644
> --- a/arch/arm/boot/dts/aspeed/Makefile
> +++ b/arch/arm/boot/dts/aspeed/Makefile
> @@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>         aspeed-bmc-facebook-minerva.dtb \
>         aspeed-bmc-facebook-minipack.dtb \
>         aspeed-bmc-facebook-tiogapass.dtb \
> +       aspeed-bmc-facebook-ventura.dtb \

I'm hitting a conflict here, can you please rebase this series on top
of aspeed/dt from [1]?

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/bmc/linux.git/


> +
> +       memory@80000000 {
> +               device_type = "memory";
> +               reg = <0x80000000 0x80000000>;
> +       };
> +
> +    p1v8_bmc_aux: regulator-p1v8-bmc-aux {

Can you please fix the indentation here?

> +               compatible = "regulator-fixed";
> +               regulator-name = "p1v8_bmc_aux";
> +               regulator-min-microvolt = <1800000>;
> +               regulator-max-microvolt = <1800000>;
> +               regulator-always-on;
> +       };
> +
> +       p2v5_bmc_aux: regulator-p2v5-bmc-aux {
> +               compatible = "regulator-fixed";
> +               regulator-name = "p2v5_bmc_aux";
> +               regulator-min-microvolt = <2500000>;
> +               regulator-max-microvolt = <2500000>;
> +               regulator-always-on;
> +       };
> +
> +    spi1_gpio: spi {

And again here?

Please check the entire devicetree for similar issues.

> +               compatible = "spi-gpio";
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> +               mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> +               miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> +               cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_LOW>;
> +               num-chipselects = <1>;
> +
> +               tpm@0 {
> +                       compatible = "infineon,slb9670", "tcg,tpm_tis-spi";
> +                       spi-max-frequency = <33000000>;
> +                       reg = <0>;
> +               };
> +       };
> +};
> +

[...]

> +               i2c3mux0ch3: i2c@3 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <3>;
> +
> +                       // Fan Board 0 FRU
> +                       eeprom@56 {
> +                               compatible = "atmel,24c128";
> +                               reg = <0x56>;
> +                       };
> +
> +                       fan_leds_g1_gpio: gpio@21 {

Please make sure the devicetree meets the style guide[2], particularly
the order of nodes:

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

Here, devices should be listed in ascending order of address.

Please check the entire devicetree.

[2]: https://docs.kernel.org/devicetree/bindings/dts-coding-style.html

Andrew