Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH -next] ARM: dts: aspeed: nuvia: rename vendor nuvia to qcom
Date: Tue, 24 May 2022 04:57:56 -0700	[thread overview]
Message-ID: <71613fa5-c468-e3ab-935a-7aa675e822fc@quicinc.com> (raw)
In-Reply-To: <dd67a453-b75b-d092-f999-3faf05ef8160@linaro.org>

Hi Krzysztof,

On 5/24/2022 2:53 AM, Krzysztof Kozlowski wrote:
> On 23/05/2022 19:56, Jae Hyun Yoo wrote:
>> Nuvia has been acquired by Qualcomm and the vendor name 'nuvia' will
>> not be used anymore so rename aspeed-bmc-nuvia-dc-scm.dts to
>> aspeed-bmc-qcom-dc-scm-v1.dts and change 'nuvia' to 'qcom' as its vendor
>> name in the file.
> 
> And all users of this DTB now have to update their bootloaders, scripts,
> installation methods. We did not rename FSL or Marvell boards, so
> neither should be renamed this one.

Yeah, I know that we don't rename dts but the previous version of this
change was picked recently in the middle of code review
https://lore.kernel.org/all/979a5c87-a7ea-a1f0-e42e-29043df6b348 at quicinc.com/
and the v3 was pulled recently so it's still in the -next queue so
I believe it has a chance to be renamed since no one is using the DTB
yet.

>>
>> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
>> ---
>>   arch/arm/boot/dts/Makefile                                    | 2 +-
>>   ...eed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} | 4 ++--
>>   2 files changed, 3 insertions(+), 3 deletions(-)
>>   rename arch/arm/boot/dts/{aspeed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} (97%)
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 03f5b3a15415..2a3c95387613 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -1584,7 +1584,6 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>>   	aspeed-bmc-lenovo-hr630.dtb \
>>   	aspeed-bmc-lenovo-hr855xg2.dtb \
>>   	aspeed-bmc-microsoft-olympus.dtb \
>> -	aspeed-bmc-nuvia-dc-scm.dtb \
>>   	aspeed-bmc-opp-lanyang.dtb \
>>   	aspeed-bmc-opp-mihawk.dtb \
>>   	aspeed-bmc-opp-mowgli.dtb \
>> @@ -1597,6 +1596,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>>   	aspeed-bmc-opp-witherspoon.dtb \
>>   	aspeed-bmc-opp-zaius.dtb \
>>   	aspeed-bmc-portwell-neptune.dtb \
>> +	aspeed-bmc-qcom-dc-scm-v1.dtb \
>>   	aspeed-bmc-quanta-q71l.dtb \
>>   	aspeed-bmc-quanta-s6q.dtb \
>>   	aspeed-bmc-supermicro-x11spi.dtb \
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts
>> similarity index 97%
>> rename from arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts
>> rename to arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts
>> index f4a97cfb0f23..259ef3f54c5c 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts
>> @@ -6,8 +6,8 @@
>>   #include "aspeed-g6.dtsi"
>>   
>>   / {
>> -	model = "Nuvia DC-SCM BMC";
>> -	compatible = "nuvia,dc-scm-bmc", "aspeed,ast2600";
>> +	model = "Qualcomm DC-SCM V1 BMC";
>> +	compatible = "qcom,dc-scm-v1-bmc", "aspeed,ast2600";
> 
> 
> You need also change bindings.

I didn't see any case of changing bindings for adding a new Aspped BMC
dts.

Thanks,
Jae

> 
> Best regards,
> Krzysztof

  reply	other threads:[~2022-05-24 11:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23 17:56 [PATCH -next] ARM: dts: aspeed: nuvia: rename vendor nuvia to qcom Jae Hyun Yoo
2022-05-24  9:53 ` Krzysztof Kozlowski
2022-05-24 11:57   ` Jae Hyun Yoo [this message]
2022-05-26 12:11     ` Krzysztof Kozlowski
2022-05-24 12:02   ` Graeme Gregory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71613fa5-c468-e3ab-935a-7aa675e822fc@quicinc.com \
    --to=quic_jaehyoo@quicinc.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox