Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 02/11] ARM: dts: aspeed: Harma: add VR device
Date: Fri, 02 Aug 2024 16:06:47 +0930	[thread overview]
Message-ID: <7bf4cb57f2b0b41c79f2efea3e0b0211988c0896.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240801160136.1281291-3-peteryin.openbmc@gmail.com>

On Fri, 2024-08-02 at 00:01 +0800, Peter Yin wrote:
> Add isl69260, xdpe152c4 device
> 
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> ---
>  .../dts/aspeed/aspeed-bmc-facebook-harma.dts  | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> index d99fba321379..8fb30029e46c 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> @@ -398,6 +398,30 @@ imux28: i2c at 0 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0>;
> +			power-monitor at 61 {
> +				compatible = "isil,isl69260";
> +				reg = <0x61>;
> +			};
> +			power-monitor at 62 {
> +				compatible = "isil,isl69260";
> +				reg = <0x62>;
> +			};
> +			power-monitor at 63 {
> +				compatible = "isil,isl69260";
> +				reg = <0x63>;
> +			};

As of v6.11-rc1 this gives me:

```
$ ./scripts/checkpatch.pl --strict -g HEAD
...
WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/
#24: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:402:
+                               compatible = "isil,isl69260";

WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/
#28: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:406:
+                               compatible = "isil,isl69260";

WARNING: DT compatible string "isil,isl69260" appears un-documented -- check ./Documentation/devicetree/bindings/
#32: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts:410:
+                               compatible = "isil,isl69260";

total: 0 errors, 3 warnings, 0 checks, 30 lines checked
```

and

```
$ make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-harma.dtb 2>&1 | grep isil
...
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus at 1e78a000/i2c at 700/i2c-mux at 70/i2c at 0/power-monitor at 61: failed to match any schema with compatible: ['isil,isl69260']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus at 1e78a000/i2c at 700/i2c-mux at 70/i2c at 0/power-monitor at 62: failed to match any schema with compatible: ['isil,isl69260']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: /ahb/apb/bus at 1e78a000/i2c at 700/i2c-mux at 70/i2c at 0/power-monitor at 63: failed to match any schema with compatible: ['isil,isl69260']
```

While there's already an Aspeed-based Quanta platform that also
specifies this device, let's not add to the problems of the Aspeed
devicetrees.

Please make sure to run `make dtbs_check ...` and checkpatch on your
changes. Regarding `make dtbs_check` and related tests, this blog post
is helpful:

https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/

Andrew

  reply	other threads:[~2024-08-02  6:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 16:01 [PATCH v3 00/11] Revise Meta(Facebook) Harma BMC(AST2600) Peter Yin
2024-08-01 16:01 ` [PATCH v3 01/11] ARM: dts: aspeed: Harma: revise hsc chip Peter Yin
2024-08-01 16:01 ` [PATCH v3 02/11] ARM: dts: aspeed: Harma: add VR device Peter Yin
2024-08-02  6:36   ` Andrew Jeffery [this message]
2024-08-12  2:08     ` Andrew Jeffery
2024-08-01 16:01 ` [PATCH v3 03/11] ARM: dts: aspeed: Harma: add sgpio name Peter Yin
2024-08-01 16:01 ` [PATCH v3 04/11] ARM: dts: aspeed: Harma: add ina238 Peter Yin
2024-08-01 16:01 ` [PATCH v3 05/11] ARM: dts: aspeed: Harma: add power monitor xdp710 Peter Yin
2024-08-01 16:01 ` [PATCH v3 06/11] ARM: dts: aspeed: Harma: remove multi-host property Peter Yin
2024-08-01 16:01 ` [PATCH v3 07/11] ARM: dts: aspeed: Harma: add fru device Peter Yin
2024-08-01 16:01 ` [PATCH v3 08/11] ARM: dts: aspeed: Harma: add temperature device Peter Yin
2024-08-01 16:01 ` [PATCH v3 09/11] ARM: dts: aspeed: Harma: enable mctp controller Peter Yin
2024-08-01 16:01 ` [PATCH v3 10/11] ARM: dts: aspeed: Harma: fixed dtb_check warning Peter Yin
2024-08-01 16:01 ` [PATCH v3 11/11] ARM: dts: aspeed: Harma: remove pca9546 Peter Yin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bf4cb57f2b0b41c79f2efea3e0b0211988c0896.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox