From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Date: Thu, 08 Aug 2024 15:40:27 -0700 Subject: [PATCH] ARM: dts: Fix undocumented LM75 compatible nodes In-Reply-To: <20240808164941.1407327-1-robh@kernel.org> References: <20240808164941.1407327-1-robh@kernel.org> Message-ID: <7hcymir63o.fsf@baylibre.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit "Rob Herring (Arm)" writes: > "lm75" without any vendor is undocumented. It works with the Linux > kernel since the I2C subsystem will do matches of the compatible string > without a vendor prefix to the i2c_device_id and/or driver name. > > Mostly replace "lm75" with "national,lm75" as that's the original part > vendor and the compatible which matches what "lm75" matched with. In a > couple of cases the node name or compatible gives a clue to the actual > part and vendor and a more specific compatible can be used. In these > cases, it does change the variant the kernel picks. > > "nct75" is an OnSemi part which is compatible with TI TMP75C based on > a comparison of the OnSemi NCT75 datasheet and configuration the Linux > driver uses. Adding an OnSemi compatible would be an ABI change. > > "nxp,lm75" is most likely an NXP part. NXP makes a LM75A and LM75B. > Both are 11-bit resolution and 100ms sample time, so "national,lm75b" is > the closest match. > > While we're here, fix the node names to use the generic name > "temperature-sensor". > > Signed-off-by: Rob Herring (Arm) > --- > SoC maintainers, Please take this directly. [...] > arch/arm/boot/dts/ti/omap/am335x-nano.dts | 2 +- For this one... Reviewed-by: Kevin Hilman