* [PATCH v1] media: aspeed: Fix driver probe failure
@ 2026-02-27 12:38 Haiyue Wang
2026-02-27 12:59 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Haiyue Wang @ 2026-02-27 12:38 UTC (permalink / raw)
To: linux-aspeed
Cc: Haiyue Wang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, Michael Turquette, Stephen Boyd,
Hans Verkuil, Jammy Huang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/ASPEED MACHINE SUPPORT, open list,
open list:COMMON CLK FRAMEWORK
The aspeed video (be compatible for ast2400, ast2500, ast2600) now needs
the reset DTS handle specified, otherwise it will fail to load:
[ 0.000000] OF: reserved mem: initialized node video, compatible id shared-dma-pool
[ 0.000000] OF: reserved mem: 0xbb000000..0xbeffffff (65536 KiB) map reusable video
[ 0.377039] videodev: Linux video capture interface: v2.00
[ 4.809494] aspeed-video 1e700000.video: irq 57
[ 4.809977] aspeed-video 1e700000.video: Unable to get reset
[ 4.810341] aspeed-video 1e700000.video: probe with driver aspeed-video failed with error -2
Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
Signed-off-by: Haiyue Wang <haiyuewa@163.com>
---
arch/arm/boot/dts/aspeed/aspeed-g4.dtsi | 1 +
arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 1 +
arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 1 +
include/dt-bindings/clock/ast2600-clock.h | 1 +
4 files changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g4.dtsi
index c3d4d916c69b..1547e28d77e2 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g4.dtsi
@@ -242,6 +242,7 @@ video: video@1e700000 {
<&syscon ASPEED_CLK_GATE_ECLK>;
clock-names = "vclk", "eclk";
interrupts = <7>;
+ resets = <&syscon ASPEED_RESET_VIDEO>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
index 39500bdb4747..793570ca2518 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
@@ -296,6 +296,7 @@ video: video@1e700000 {
<&syscon ASPEED_CLK_GATE_ECLK>;
clock-names = "vclk", "eclk";
interrupts = <7>;
+ resets = <&syscon ASPEED_RESET_VIDEO>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
index 189bc3bbb47c..3adf48987a17 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
@@ -428,6 +428,7 @@ video: video@1e700000 {
<&syscon ASPEED_CLK_GATE_ECLK>;
clock-names = "vclk", "eclk";
interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&syscon ASPEED_RESET_VIDEO>;
status = "disabled";
};
diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
index f60fff261130..7b9b80c38a8b 100644
--- a/include/dt-bindings/clock/ast2600-clock.h
+++ b/include/dt-bindings/clock/ast2600-clock.h
@@ -124,6 +124,7 @@
#define ASPEED_RESET_PCIE_RC_OEN 18
#define ASPEED_RESET_MAC2 12
#define ASPEED_RESET_MAC1 11
+#define ASPEED_RESET_VIDEO 6
#define ASPEED_RESET_PCI_DP 5
#define ASPEED_RESET_HACE 4
#define ASPEED_RESET_AHB 1
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] media: aspeed: Fix driver probe failure
2026-02-27 12:38 [PATCH v1] media: aspeed: Fix driver probe failure Haiyue Wang
@ 2026-02-27 12:59 ` Krzysztof Kozlowski
2026-02-27 15:18 ` Haiyue Wang
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-27 12:59 UTC (permalink / raw)
To: Haiyue Wang, linux-aspeed
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery, Michael Turquette, Stephen Boyd, Hans Verkuil,
Jammy Huang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/ASPEED MACHINE SUPPORT, open list,
open list:COMMON CLK FRAMEWORK
On 27/02/2026 13:38, Haiyue Wang wrote:
> The aspeed video (be compatible for ast2400, ast2500, ast2600) now needs
> the reset DTS handle specified, otherwise it will fail to load:
>
> [ 0.000000] OF: reserved mem: initialized node video, compatible id shared-dma-pool
> [ 0.000000] OF: reserved mem: 0xbb000000..0xbeffffff (65536 KiB) map reusable video
> [ 0.377039] videodev: Linux video capture interface: v2.00
> [ 4.809494] aspeed-video 1e700000.video: irq 57
> [ 4.809977] aspeed-video 1e700000.video: Unable to get reset
> [ 4.810341] aspeed-video 1e700000.video: probe with driver aspeed-video failed with error -2
>
> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-g4.dtsi | 1 +
> arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 1 +
> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 1 +
> include/dt-bindings/clock/ast2600-clock.h | 1 +
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 4 files changed, 4 insertions(+)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] media: aspeed: Fix driver probe failure
2026-02-27 12:59 ` Krzysztof Kozlowski
@ 2026-02-27 15:18 ` Haiyue Wang
2026-02-27 15:35 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Haiyue Wang @ 2026-02-27 15:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-aspeed
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery, Michael Turquette, Stephen Boyd, Hans Verkuil,
Jammy Huang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/ASPEED MACHINE SUPPORT, open list,
open list:COMMON CLK FRAMEWORK
On 2/27/2026 8:59 PM, Krzysztof Kozlowski wrote:
> On 27/02/2026 13:38, Haiyue Wang wrote:
>> The aspeed video (be compatible for ast2400, ast2500, ast2600) now needs
>> the reset DTS handle specified, otherwise it will fail to load:
>>
>> [ 0.000000] OF: reserved mem: initialized node video, compatible id shared-dma-pool
>> [ 0.000000] OF: reserved mem: 0xbb000000..0xbeffffff (65536 KiB) map reusable video
>> [ 0.377039] videodev: Linux video capture interface: v2.00
>> [ 4.809494] aspeed-video 1e700000.video: irq 57
>> [ 4.809977] aspeed-video 1e700000.video: Unable to get reset
>> [ 4.810341] aspeed-video 1e700000.video: probe with driver aspeed-video failed with error -2
>>
>> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
>> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
>> ---
>> arch/arm/boot/dts/aspeed/aspeed-g4.dtsi | 1 +
>> arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 1 +
>> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 1 +
>> include/dt-bindings/clock/ast2600-clock.h | 1 +
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
>
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
Seperated into two patches in v2, please help to review.
>> 4 files changed, 4 insertions(+)
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] media: aspeed: Fix driver probe failure
2026-02-27 15:18 ` Haiyue Wang
@ 2026-02-27 15:35 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-27 15:35 UTC (permalink / raw)
To: Haiyue Wang, linux-aspeed
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery, Michael Turquette, Stephen Boyd, Hans Verkuil,
Jammy Huang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/ASPEED MACHINE SUPPORT, open list,
open list:COMMON CLK FRAMEWORK
On 27/02/2026 16:18, Haiyue Wang wrote:
>
>
> On 2/27/2026 8:59 PM, Krzysztof Kozlowski wrote:
>> On 27/02/2026 13:38, Haiyue Wang wrote:
>>> The aspeed video (be compatible for ast2400, ast2500, ast2600) now needs
>>> the reset DTS handle specified, otherwise it will fail to load:
>>>
>>> [ 0.000000] OF: reserved mem: initialized node video, compatible id shared-dma-pool
>>> [ 0.000000] OF: reserved mem: 0xbb000000..0xbeffffff (65536 KiB) map reusable video
>>> [ 0.377039] videodev: Linux video capture interface: v2.00
>>> [ 4.809494] aspeed-video 1e700000.video: irq 57
>>> [ 4.809977] aspeed-video 1e700000.video: Unable to get reset
>>> [ 4.810341] aspeed-video 1e700000.video: probe with driver aspeed-video failed with error -2
>>>
>>> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
>>> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
>>> ---
>>> arch/arm/boot/dts/aspeed/aspeed-g4.dtsi | 1 +
>>> arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 1 +
>>> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 1 +
>>> include/dt-bindings/clock/ast2600-clock.h | 1 +
>>
>> Please run scripts/checkpatch.pl on the patches and fix reported
>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>> patches and (probably) fix more warnings. Some warnings can be ignored,
>> especially from --strict run, but the code here looks like it needs a
>> fix. Feel free to get in touch if the warning is not clear.
>>
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
>
> Seperated into two patches in v2, please help to review.
No, please wait. One posting per day. We have enough of other patches to
review.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-02 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 12:38 [PATCH v1] media: aspeed: Fix driver probe failure Haiyue Wang
2026-02-27 12:59 ` Krzysztof Kozlowski
2026-02-27 15:18 ` Haiyue Wang
2026-02-27 15:35 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox