From: Felipe Balbi <balbi@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2] usb: introduce usb_ep_type_string() function
Date: Wed, 20 Mar 2019 08:55:11 +0200 [thread overview]
Message-ID: <87r2b2ujao.fsf@linux.intel.com> (raw)
In-Reply-To: <1553044567.10179.148.camel@mhfsdcap03>
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Hi Greg,
>
> On Tue, 2019-03-19 at 10:23 +0100, Greg Kroah-Hartman wrote:
>> On Tue, Mar 19, 2019 at 03:54:19PM +0800, Chunfeng Yun wrote:
>> >
>> > Hi Felipe & Mathias,
>> >
>> > Could you please comment this patch, if there is some-effect on dwc3 and
>> > xhci, I'll remove its change.
> typo: some-effect/side-effect
well, we don't really know if there are tools parsing the output. The
side-effect _does_ exist (i.e. you change the string :-), what we don't
know is if this will cause problems to possibly existing tools.
Personally, I don't mind the patch, but if it breaks existing parsers,
that would be a little annoying.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20190320/7719f1d8/attachment.sig>
next prev parent reply other threads:[~2019-03-20 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 7:44 [PATCH v2] usb: introduce usb_ep_type_string() function Chunfeng Yun
2019-03-19 7:54 ` Chunfeng Yun
2019-03-19 9:23 ` Greg Kroah-Hartman
2019-03-20 1:16 ` Chunfeng Yun
2019-03-20 6:55 ` Felipe Balbi [this message]
2019-03-20 7:49 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2b2ujao.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).