From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Sanjay R Mehta" <sanju.mehta@amd.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Han Xu" <han.xu@nxp.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Yogesh Gaur" <yogeshgaur.83@gmail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Michal Simek" <michal.simek@amd.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Jacky Huang" <ychuang3@nuvoton.com>,
"Shan-Chun Hung" <schung@nuvoton.com>,
"Chin-Ting Kuo" <chin-ting_kuo@aspeedtech.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Raju Rangoju" <Raju.Rangoju@amd.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Steam Lin" <stlin2@winbond.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-aspeed@lists.ozlabs.org,
openbmc@lists.ozlabs.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2 20/27] spi: spi-mem: Estimate the time taken by operations
Date: Fri, 10 Jan 2025 15:37:52 +0100 [thread overview]
Message-ID: <87tta6ag5b.fsf@bootlin.com> (raw)
In-Reply-To: <ca317e2c-cd09-4884-b9eb-9cf23ae88078@sirena.org.uk> (Mark Brown's message of "Fri, 10 Jan 2025 12:42:47 +0000")
Hi Mark,
On 10/01/2025 at 12:42:47 GMT, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Dec 24, 2024 at 06:06:05PM +0100, Miquel Raynal wrote:
>> In the SPI-NAND layer, we currently make list of operation variants from
>> the fastest one to the slowest and there is a bit of logic in the core
>> to go over them and pick the first one that is supported by the
>> controller, ie. the fastest one among the supported ops.
>
> This breaks the build:
>
> /build/stage/linux/drivers/spi/spi-mem.c:580:5: error: conflicting types for ‘spi_mem_calc_op_duration’; have ‘u64(struct spi_mem_op *)’ {aka ‘long long unsigned int(struct spi_mem_op *)’}
> 580 | u64 spi_mem_calc_op_duration(struct spi_mem_op *op)
Crap, that's a fixup that landed in the wrong commit (mtd: spinand:
Enhance the logic when picking a variant). I'll fix it.
Thanks,
Miquèl
next prev parent reply other threads:[~2025-01-10 14:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 17:05 [PATCH v2 00/27] spi-nand/spi-mem DTR support Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 01/27] spi: spi-mem: Extend spi-mem operations with a per-operation maximum frequency Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 02/27] spi: spi-mem: Add a new controller capability Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 03/27] spi: amd: Support per spi-mem operation frequency switches Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 04/27] spi: amd: Drop redundant check Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 05/27] spi: amlogic-spifc-a1: Support per spi-mem operation frequency switches Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 06/27] spi: cadence-qspi: " Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 07/27] spi: dw: " Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 08/27] spi: fsl-qspi: " Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 09/27] spi: microchip-core-qspi: " Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 10/27] spi: mt65xx: " Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 11/27] spi: mxic: " Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 12/27] spi: nxp-fspi: " Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 13/27] spi: rockchip-sfc: " Miquel Raynal
2024-12-24 17:05 ` [PATCH v2 14/27] spi: spi-sn-f-ospi: " Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 15/27] spi: spi-ti-qspi: " Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 16/27] spi: zynq-qspi: " Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 17/27] spi: zynqmp-gqspi: " Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 18/27] spi: spi-mem: Reorder spi-mem macro assignments Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 19/27] spi: spi-mem: Create macros for DTR operation Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 20/27] spi: spi-mem: Estimate the time taken by operations Miquel Raynal
2025-01-10 12:42 ` Mark Brown
2025-01-10 14:37 ` Miquel Raynal [this message]
2025-01-10 14:52 ` Mark Brown
2025-01-10 15:06 ` Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 21/27] mtd: spinand: Create distinct fast and slow read from cache variants Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 22/27] mtd: spinand: Add an optional frequency to read from cache macros Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 23/27] mtd: spinand: Enhance the logic when picking a variant Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 24/27] mtd: spinand: Add support for read DTR operations Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 25/27] mtd: spinand: winbond: Update the *JW chip definitions Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 26/27] mtd: spinand: winbond: Add comment about naming Miquel Raynal
2024-12-24 17:06 ` [PATCH v2 27/27] mtd: spinand: winbond: Add support for DTR operations Miquel Raynal
2025-01-10 15:47 ` (subset) [PATCH v2 00/27] spi-nand/spi-mem DTR support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tta6ag5b.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Raju.Rangoju@amd.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@codeconstruct.com.au \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=broonie@kernel.org \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=clg@kaod.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=fancer.lancer@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@amd.com \
--cc=openbmc@lists.ozlabs.org \
--cc=richard@nod.at \
--cc=sanju.mehta@amd.com \
--cc=schung@nuvoton.com \
--cc=stlin2@winbond.com \
--cc=tali.perry1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=vigneshr@ti.com \
--cc=ychuang3@nuvoton.com \
--cc=yogeshgaur.83@gmail.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).