From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Cosmo Chou <chou.cosmo@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
joel@jms.id.au
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
cosmo.chou@quantatw.com
Subject: Re: [PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1
Date: Fri, 17 Oct 2025 17:03:26 +1030 [thread overview]
Message-ID: <8bf232de1d4254afc408b415d3476c2c2183a4ac.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20251016052727.881576-1-chou.cosmo@gmail.com>
On Thu, 2025-10-16 at 13:27 +0800, Cosmo Chou wrote:
> Remove the external signal configuration from wdt1 to prevent the
> WDTRST1 pin from being asserted during watchdog resets.
Yes, this is certainly the immediate impact of the patch.
But what's the motivation? And if asserting WDTRST1 was the wrong thing
to be doing, why was it done to start with?
Please address both questions in an update to the commit message.
Thanks,
Andrew
prev parent reply other threads:[~2025-10-17 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 5:27 [PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1 Cosmo Chou
2025-10-17 6:33 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf232de1d4254afc408b415d3476c2c2183a4ac.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=chou.cosmo@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cosmo.chou@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).