* [PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1
@ 2025-10-16 5:27 Cosmo Chou
2025-10-17 6:33 ` Andrew Jeffery
0 siblings, 1 reply; 2+ messages in thread
From: Cosmo Chou @ 2025-10-16 5:27 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, joel, andrew
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
cosmo.chou, Cosmo Chou
Remove the external signal configuration from wdt1 to prevent the
WDTRST1 pin from being asserted during watchdog resets.
Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
index 24969c82d05e..abdb1562115a 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
@@ -1080,11 +1080,5 @@ pinctrl_gpiov2_unbiased_default: gpiov2 {
&wdt1 {
status = "okay";
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_wdtrst1_default>;
aspeed,reset-type = "soc";
- aspeed,external-signal;
- aspeed,ext-push-pull;
- aspeed,ext-active-high;
- aspeed,ext-pulse-duration = <256>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1
2025-10-16 5:27 [PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1 Cosmo Chou
@ 2025-10-17 6:33 ` Andrew Jeffery
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jeffery @ 2025-10-17 6:33 UTC (permalink / raw)
To: Cosmo Chou, robh, krzk+dt, conor+dt, joel
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
cosmo.chou
On Thu, 2025-10-16 at 13:27 +0800, Cosmo Chou wrote:
> Remove the external signal configuration from wdt1 to prevent the
> WDTRST1 pin from being asserted during watchdog resets.
Yes, this is certainly the immediate impact of the patch.
But what's the motivation? And if asserting WDTRST1 was the wrong thing
to be doing, why was it done to start with?
Please address both questions in an update to the commit message.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-17 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 5:27 [PATCH] ARM: dts: aspeed: bletchley: remove WDTRST1 assertion from wdt1 Cosmo Chou
2025-10-17 6:33 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).