From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v6 1/2] dt-bindings: media: convert aspeed-video.txt to dt-schema
Date: Thu, 29 Aug 2024 09:55:30 +0200 [thread overview]
Message-ID: <8ce757a9-ea4c-4dd2-8aaa-e04f21eb3f63@kernel.org> (raw)
In-Reply-To: <20240829064508.3706672-2-jammy_huang@aspeedtech.com>
On 29/08/2024 08:45, Jammy Huang wrote:
> Convert the ASPEED SoCs video txt bindings to dt-schema.
>
> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> ---
> .../bindings/media/aspeed,video-engine.yaml | 78 +++++++++++++++++++
> .../bindings/media/aspeed-video.txt | 33 --------
> 2 files changed, 78 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/aspeed,video-engine.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/aspeed-video.txt
Fix the paths in kernel (git grep).
...
> +
> + resets:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + memory-region:
> + description: |
> + Phandle to a memory region to allocate from, as defined in
> + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
Useless description, completely redundant. Please say something useful
about this particular memory region and its usage.
Missing maxItems.
> +
> + aspeed,scu:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: |
> + Specifies the scu node that is needed if video wants to capture
> + from sources other than Host VGA.
> +
> + aspeed,gfx:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: |
> + Specifies the Soc Display(gfx) node that needs to be queried to get
> + related information if video wants to use gfx as capture source.
These two were not in the binding. Mention in the commit msg any changes
from pure conversion with rationale WHY you are changing the binding.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> +
> +additionalProperties: false
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-29 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 6:45 [PATCH v6 0/2] media: aspeed: Allow to capture from SoC display (GFX) Jammy Huang
2024-08-29 6:45 ` [PATCH v6 1/2] dt-bindings: media: convert aspeed-video.txt to dt-schema Jammy Huang
2024-08-29 7:55 ` Krzysztof Kozlowski [this message]
2024-09-02 1:44 ` Jammy Huang
2024-09-02 6:57 ` Krzysztof Kozlowski
2024-08-29 8:23 ` Rob Herring
2024-09-02 0:43 ` Jammy Huang
2024-08-30 0:21 ` kernel test robot
2024-08-29 6:45 ` [PATCH v6 2/2] media: aspeed: Allow to capture from SoC display (GFX) Jammy Huang
2024-08-29 7:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ce757a9-ea4c-4dd2-8aaa-e04f21eb3f63@kernel.org \
--to=krzk@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox