From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v11 25/27] ARM: dts: aspeed: yosemite4: add RTQ6056 support
Date: Tue, 30 Jul 2024 08:04:40 +0200 [thread overview]
Message-ID: <8e416a44-f637-4a3a-ad9a-6a84b3770b2e@kernel.org> (raw)
In-Reply-To: <ZqgRq4h0HWClxSEW@heinlein.vulture-banana.ts.net>
On 30/07/2024 00:03, Patrick Williams wrote:
> On Tue, Jul 23, 2024 at 05:23:06PM +0800, Delphine CC Chiu wrote:
>> Add RTQ6056 (spider board 3rd source) support in yosemite4 DTS.
>>
>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
>> ---
>> .../boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
>> index f73719b3c2f1..03a1e41312e3 100644
>> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
>> @@ -1240,35 +1240,35 @@ adc at 37 {
>> };
>>
>> power-sensor at 40 {
>> - compatible = "ti,ina233";
>> + compatible = "ti,ina233", "richtek,rtq6056";
>
> Is this legal to have two chips both listed as compatible? I thought
> this approach has been rejected before.
>
Testing would tell... This was clearly not tested and is just ridiculous.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-30 6:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 9:22 [PATCH v11 00/27] Add i2c-mux and eeprom devices for Meta Yosemite 4 Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 01/27] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 02/27] ARM: dts: aspeed: yosemite4: Enable adc15 Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 03/27] ARM: dts: aspeed: yosemite4: Enable spi-gpio setting Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 04/27] ARM: dts: aspeed: yosemite4: Enable watchdog2 Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 05/27] ARM: dts: aspeed: yosemite4: Revise quad mode to dual mode Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 06/27] ARM: dts: aspeed: yosemite4: Revise power sensor adm1281 for schematic change Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 07/27] ARM: dts: aspeed: yosemite4: Add gpio pca9506 Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 08/27] ARM: dts: aspeed: yosemite4: Remove space for adm1272 compatible Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 09/27] ARM: dts: aspeed: yosemite4: Enable interrupt setting for pca9555 Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 10/27] ARM: dts: aspeed: yosemite4: Add power sensor for power module reading Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 11/27] ARM: dts: aspeed: yosemite4: Add eeprom for yosemite4 use Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 12/27] ARM: dts: aspeed: yosemite4: Remove temperature sensor for yosemite4 schematic change Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 13/27] ARM: dts: aspeed: yosemite4: Revise adc128d818 adc mode " Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 14/27] ARM: dts: aspeed: yosemite4: Revise ina233 config " Delphine CC Chiu
2024-07-29 22:13 ` Patrick Williams
2024-07-23 9:22 ` [PATCH v11 15/27] ARM: dts: aspeed: yosemite4: Remove idle state setting for yosemite4 NIC connection Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 16/27] ARM: dts: aspeed: yosemite4: Initialize bmc gpio state Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 17/27] ARM: dts: aspeed: yosemite4: Revise mx31790 fan tach config Delphine CC Chiu
2024-07-23 9:22 ` [PATCH v11 18/27] ARM: dts: aspeed: yosemite4: add mctp config for NIC Delphine CC Chiu
2024-07-23 9:23 ` [PATCH v11 19/27] ARM: dts: aspeed: yosemite4: support mux to cpld Delphine CC Chiu
2024-07-23 9:23 ` [PATCH v11 20/27] ARM: dts: aspeed: yosemite4: support medusa board adc sensors Delphine CC Chiu
2024-07-29 22:12 ` Patrick Williams
2024-07-30 3:59 ` Andrew Jeffery
2024-07-23 9:23 ` [PATCH v11 21/27] ARM: dts: aspeed: yosemite4: support NIC eeprom Delphine CC Chiu
2024-07-23 9:23 ` [PATCH v11 22/27] ARM: dts: aspeed: yosemite4: Revise i2c duty-cycle Delphine CC Chiu
2024-07-29 22:09 ` [PATCH v11 22/27] ARM: dts: aspeed: yosemite4: Revise i2c duty-cycle^[ Patrick Williams
2024-07-23 9:23 ` [PATCH v11 23/27] ARM: dts: aspeed: yosemite4: add fan led config Delphine CC Chiu
2024-07-23 9:23 ` [PATCH v11 24/27] ARM: dts: aspeed: yosemite4: add XDP710 Delphine CC Chiu
2024-07-23 9:23 ` [PATCH v11 25/27] ARM: dts: aspeed: yosemite4: add RTQ6056 support Delphine CC Chiu
2024-07-29 22:03 ` Patrick Williams
2024-07-30 3:56 ` Andrew Jeffery
2024-07-30 6:04 ` Krzysztof Kozlowski [this message]
2024-07-23 9:23 ` [PATCH v11 26/27] ARM: dts: aspeed: yosemite4: add MP5990 support Delphine CC Chiu
2024-07-23 9:23 ` [PATCH v11 27/27] ARM: dts: aspeed: yosemite4: Adjust ioexp bus and remove mctp driver Delphine CC Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e416a44-f637-4a3a-ad9a-6a84b3770b2e@kernel.org \
--to=krzk@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox