From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhruva Gole Date: Mon, 23 Jan 2023 19:50:50 +0530 Subject: [PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call In-Reply-To: <20230119185342.2093323-3-amit.kumar-mahapatra@amd.com> References: <20230119185342.2093323-1-amit.kumar-mahapatra@amd.com> <20230119185342.2093323-3-amit.kumar-mahapatra@amd.com> Message-ID: <90084f5f-6e9d-7b17-5487-3b4b01bd5e7d@ti.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Amit, On 20/01/23 00:23, Amit Kumar Mahapatra wrote: > Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod > members of struct spi_device to be an array. But changing the type of these > members to array would break the spi driver functionality. To make the > transition smoother introduced four new APIs to get/set the > spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and > spi->cs_gpiod references with get or set API calls. > While adding multi-cs support in further patches the chip_select & cs_gpiod > members of the spi_device structure would be converted to arrays & the > "idx" parameter of the APIs would be used as array index i.e., > spi->chip_select[idx] & spi->cs_gpiod[idx] respectively. > > Signed-off-by: Amit Kumar Mahapatra > --- > [...] > drivers/spi/spi-cadence-quadspi.c | 5 +++-- > drivers/spi/spi-cadence-xspi.c | 4 ++-- > drivers/spi/spi-cadence.c | 4 ++-- [...] For SPI Cadence QSPI, Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated