From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH i2c-next v4 2/3] i2c: aspeed: Add 'timeout' DT property reading code
Date: Wed, 3 Oct 2018 10:10:23 -0700 [thread overview]
Message-ID: <9951c217-70c1-81cf-a43d-baf6bb02beb9@linux.intel.com> (raw)
In-Reply-To: <CACPK8XeuFm_GYFhe-KimOHV7y7PBdFjhMGG+QAmfNrfOcb488A@mail.gmail.com>
Hi Joel,
On 10/3/2018 12:49 AM, Joel Stanley wrote:
> Hello Jae,
>
> On Mon, 1 Oct 2018 at 22:28, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote:
>> @@ -918,6 +919,11 @@ static int aspeed_i2c_probe_bus(struct platform_device *pdev)
>> bus->bus_frequency = 100000;
>> }
>>
>> + ret = of_property_read_u32(pdev->dev.of_node, "timeout",
>> + &timeout_ms);
>> + if (ret)
>> + timeout_ms = 0; /* then adap.timeout will be set by i2c-core */
>
> Is it possible to implement the parsing of this property in the i2c
> core instead?
>
Yes, that's possible but I'm not sure that could be acceptable or not.
Let me try.
Thanks,
Jae
next prev parent reply other threads:[~2018-10-03 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 20:27 [PATCH i2c-next v4 0/3] i2c: aspeed: Add bus idle waiting logic for multi-master use cases Jae Hyun Yoo
2018-10-01 20:27 ` [PATCH i2c-next v4 1/3] dt-bindings: i2c: aspeed: Add 'timeout' property as an optional property Jae Hyun Yoo
2018-10-01 20:27 ` [PATCH i2c-next v4 2/3] i2c: aspeed: Add 'timeout' DT property reading code Jae Hyun Yoo
2018-10-03 7:49 ` Joel Stanley
2018-10-03 17:10 ` Jae Hyun Yoo [this message]
2018-10-01 20:27 ` [PATCH i2c-next v4 3/3] i2c: aspeed: Add bus idle waiting logic for multi-master use cases Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9951c217-70c1-81cf-a43d-baf6bb02beb9@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).