* [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases
@ 2021-11-04 17:37 jae.hyun.yoo
2021-11-05 17:05 ` Winiarska, Iwona
2021-11-08 0:29 ` Andrew Jeffery
0 siblings, 2 replies; 5+ messages in thread
From: jae.hyun.yoo @ 2021-11-04 17:37 UTC (permalink / raw)
To: linux-aspeed
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Add a checking code when it gets -EPROBE_DEFER while getting a clock
resource. In this case, it doesn't need to print out an error message
because the probing will be re-visited.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
v1 -> v2:
* Simplified it using dev_err_probe. (Iwona)
drivers/soc/aspeed/aspeed-lpc-ctrl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/soc/aspeed/aspeed-lpc-ctrl.c b/drivers/soc/aspeed/aspeed-lpc-ctrl.c
index 72771e018c42..258894ed234b 100644
--- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c
+++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c
@@ -306,10 +306,9 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev)
}
lpc_ctrl->clk = devm_clk_get(dev, NULL);
- if (IS_ERR(lpc_ctrl->clk)) {
- dev_err(dev, "couldn't get clock\n");
- return PTR_ERR(lpc_ctrl->clk);
- }
+ if (IS_ERR(lpc_ctrl->clk))
+ return dev_err_probe(dev, PTR_ERR(lpc_ctrl->clk),
+ "couldn't get clock\n");
rc = clk_prepare_enable(lpc_ctrl->clk);
if (rc) {
dev_err(dev, "couldn't enable clock\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases
2021-11-04 17:37 [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases jae.hyun.yoo
@ 2021-11-05 17:05 ` Winiarska, Iwona
2021-11-05 17:08 ` Jae Hyun Yoo
2021-11-08 0:29 ` Andrew Jeffery
1 sibling, 1 reply; 5+ messages in thread
From: Winiarska, Iwona @ 2021-11-05 17:05 UTC (permalink / raw)
To: linux-aspeed
On Thu, 2021-11-04 at 10:37 -0700, jae.hyun.yoo at intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add a checking code when it gets -EPROBE_DEFER while getting a clock
> resource. In this case, it doesn't need to print out an error message
> because the probing will be re-visited.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
-Iwona
> ---
> v1 -> v2:
> ?* Simplified it using dev_err_probe. (Iwona)
>
> ?drivers/soc/aspeed/aspeed-lpc-ctrl.c | 7 +++----
> ?1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/aspeed/aspeed-lpc-ctrl.c b/drivers/soc/aspeed/aspeed-
> lpc-ctrl.c
> index 72771e018c42..258894ed234b 100644
> --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c
> +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c
> @@ -306,10 +306,9 @@ static int aspeed_lpc_ctrl_probe(struct platform_device
> *pdev)
> ????????}
> ?
> ????????lpc_ctrl->clk = devm_clk_get(dev, NULL);
> -???????if (IS_ERR(lpc_ctrl->clk)) {
> -???????????????dev_err(dev, "couldn't get clock\n");
> -???????????????return PTR_ERR(lpc_ctrl->clk);
> -???????}
> +???????if (IS_ERR(lpc_ctrl->clk))
> +???????????????return dev_err_probe(dev, PTR_ERR(lpc_ctrl->clk),
> +??????????????????????????????????? "couldn't get clock\n");
> ????????rc = clk_prepare_enable(lpc_ctrl->clk);
> ????????if (rc) {
> ????????????????dev_err(dev, "couldn't enable clock\n");
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases
2021-11-05 17:05 ` Winiarska, Iwona
@ 2021-11-05 17:08 ` Jae Hyun Yoo
0 siblings, 0 replies; 5+ messages in thread
From: Jae Hyun Yoo @ 2021-11-05 17:08 UTC (permalink / raw)
To: linux-aspeed
> Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
Thank a lot for your review.
-Jae
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases
2021-11-04 17:37 [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases jae.hyun.yoo
2021-11-05 17:05 ` Winiarska, Iwona
@ 2021-11-08 0:29 ` Andrew Jeffery
2021-11-08 18:45 ` Jae Hyun Yoo
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Jeffery @ 2021-11-08 0:29 UTC (permalink / raw)
To: linux-aspeed
On Fri, 5 Nov 2021, at 04:07, jae.hyun.yoo at intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add a checking code when it gets -EPROBE_DEFER while getting a clock
> resource. In this case, it doesn't need to print out an error message
> because the probing will be re-visited.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases
2021-11-08 0:29 ` Andrew Jeffery
@ 2021-11-08 18:45 ` Jae Hyun Yoo
0 siblings, 0 replies; 5+ messages in thread
From: Jae Hyun Yoo @ 2021-11-08 18:45 UTC (permalink / raw)
To: linux-aspeed
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Thanks a lot for your review.
-Jae
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-08 18:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-04 17:37 [PATCH v2] soc: aspeed: lpc-ctrl: Block error printing on probe defer cases jae.hyun.yoo
2021-11-05 17:05 ` Winiarska, Iwona
2021-11-05 17:08 ` Jae Hyun Yoo
2021-11-08 0:29 ` Andrew Jeffery
2021-11-08 18:45 ` Jae Hyun Yoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).