From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 5/6] ipmi: kcs_bmc_aspeed: Convert to platform remove callback returning void
Date: Wed, 06 Mar 2024 12:27:55 +1030 [thread overview]
Message-ID: <9b390f91102100f1e91098e9d49d6f200aa8a6fd.camel@codeconstruct.com.au> (raw)
In-Reply-To: <d125e83788ddc27fc52a3f11b2c329b40cbdd6f9.1709655755.git.u.kleine-koenig@pengutronix.de>
On Tue, 2024-03-05 at 17:27 +0100, Uwe Kleine-K?nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Thanks!
next prev parent reply other threads:[~2024-03-06 1:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 16:26 [PATCH 0/6] ipmi: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-05 16:27 ` [PATCH 5/6] ipmi: kcs_bmc_aspeed: " Uwe Kleine-König
2024-03-06 1:57 ` Andrew Jeffery [this message]
2024-04-11 7:15 ` [PATCH 0/6] ipmi: " Uwe Kleine-König
2024-04-11 15:11 ` Corey Minyard
2024-05-25 10:10 ` Uwe Kleine-König
2024-05-25 14:39 ` Corey Minyard
2024-05-26 10:24 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b390f91102100f1e91098e9d49d6f200aa8a6fd.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).