Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Willie Thai <wthai@nvidia.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	joel@jms.id.au, andrew@codeconstruct.com.au, kees@kernel.org,
	tony.luck@intel.com, gpiccoli@igalia.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org, openbmc@lists.ozlabs.org,
	leohu@nvidia.com, tingkaic@nvidia.com, dkodihalli@nvidia.com,
	maryang@nvidia.com, pmenzel@molgen.mpg.de,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v2] ARM: dts: aspeed: Add device tree for Nvidia's GB200NVL BMC
Date: Wed, 12 Mar 2025 13:11:48 +0100	[thread overview]
Message-ID: <9ccc845b-9392-4a37-8bca-4f54997126ce@lunn.ch> (raw)
In-Reply-To: <20250312045802.4115029-1-wthai@nvidia.com>

> +&mac0 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	phy-mode = "rgmii";
> +	phy-handle = <&ethphy3>;
> +	pinctrl-0 = <&pinctrl_rgmii1_default>;
> +};

Please read the discussion again. "rgmii" is probably equally wrong as
"rgmii-rxid" you had in v1.

Please talk with Aspeed and ask them the clean up the mess they made
with RGMII delays. Until that happens, adding this node should wait.

     Andrew


  parent reply	other threads:[~2025-03-12 12:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12  4:58 [PATCH v2] ARM: dts: aspeed: Add device tree for Nvidia's GB200NVL BMC Willie Thai
2025-03-12  7:49 ` Krzysztof Kozlowski
2025-03-19 11:24   ` Willie Thai
2025-03-19 19:28     ` Krzysztof Kozlowski
2025-03-12 12:11 ` Andrew Lunn [this message]
2025-03-18 19:14   ` [PATCH v3] " Willie Thai
2025-03-12 13:07 ` [PATCH v2] " Rob Herring (Arm)
2025-03-20 10:02   ` Willie Thai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ccc845b-9392-4a37-8bca-4f54997126ce@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dkodihalli@nvidia.com \
    --cc=gpiccoli@igalia.com \
    --cc=joel@jms.id.au \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=leohu@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maryang@nvidia.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=robh@kernel.org \
    --cc=tingkaic@nvidia.com \
    --cc=tony.luck@intel.com \
    --cc=wthai@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox