From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Rob Herring <robh@kernel.org>, Jammy Huang <jammy_huang@aspeedtech.com>
Cc: jassisinghbrar@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v5 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC
Date: Fri, 27 Jun 2025 11:22:56 +0930 [thread overview]
Message-ID: <9efb52255ee55c6300f97c067d8cec606dab0574.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250625155007.GA1489062-robh@kernel.org>
On Wed, 2025-06-25 at 10:50 -0500, Rob Herring wrote:
> On Wed, Jun 25, 2025 at 03:34:16PM +0800, Jammy Huang wrote:
> > Introduce the mailbox module for AST27XX series SoC, which is responsible
> > for interchanging messages between asymmetric processors.
> >
> > Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
>
*snip*
> > +properties:
> > + compatible:
> > + const: aspeed,ast2700-mailbox
> > +
> > + reg:
> > + maxItems: 2
> > + description:
> > + Contains the base addresses and sizes of the mailbox controller. 1st one
> > + is for TX control register; 2nd one is for RX control register.
>
> Instead, just:
>
> items:
> - description: TX control register
> - description: RX control register
Maybe also specify reg-names with "tx" and "rx"? That way we can use
devm_platform_ioremap_resource_byname() in the linux driver
implementation, which should look tidier.
Andrew
next prev parent reply other threads:[~2025-06-27 1:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 7:34 [PATCH v5 0/2] ASPEED: Add mailbox driver for AST2700 series Jammy Huang
2025-06-25 7:34 ` [PATCH v5 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC Jammy Huang
2025-06-25 15:50 ` Rob Herring
2025-06-26 3:41 ` Jammy Huang
2025-06-27 1:52 ` Andrew Jeffery [this message]
2025-06-27 2:22 ` Jammy Huang
2025-06-25 7:34 ` [PATCH v5 2/2] mailbox: aspeed: add mailbox driver for AST27XX " Jammy Huang
2025-06-27 1:54 ` Andrew Jeffery
2025-06-27 2:21 ` Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9efb52255ee55c6300f97c067d8cec606dab0574.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jammy_huang@aspeedtech.com \
--cc=jassisinghbrar@gmail.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).