From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Date: Thu, 7 Nov 2019 09:22:35 +0100 Subject: [PATCH v2 0/2] Add definition for GPIO direction In-Reply-To: References: <20191106120846.5bunrqj3uz4khih5@earth.universe> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Nov 6, 2019 at 1:25 PM Vaittinen, Matti wrote: > On Wed, 2019-11-06 at 13:08 +0100, Sebastian Reichel wrote: > > On Wed, Nov 06, 2019 at 10:51:06AM +0200, Matti Vaittinen wrote: > > > The patch series adds definitions for GPIO line directions. > > > > > > For occasional GPIO contributor like me it is always a pain to > > > remember > > > whether 1 or 0 was used for GPIO direction INPUT/OUTPUT. > > > > Maybe also update the GPIO drivers in pinctrl? (...) > Ouch. I didn't check from pinctrl but I see those should be converted > as well. I'm a bit short on time right now so if anyone else is > interested I won't mind :) > > Luckily the value for IN and OUT is not changed - only the defines were > added - so all of the drivers do not need to be done at once. If no one > else will take the pinctrl part then I can probably do pinctrl patches > for v5.6 cycle. No hurry with that. This is a good start, we don't have to fix the whole world at once. Let's look at this for v5.6. Yours, Linus Walleij