From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB0F9C7115B for ; Thu, 19 Jun 2025 11:20:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4bNJ7Q1YRtz2yPd; Thu, 19 Jun 2025 21:20:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::b2a" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1750332034; cv=none; b=LMwbZArAKOpPQiOOP0MeqERRks2WbfLfGtww5NmoYc1bPTqW5OyGw0ga2Rm8Pws4Hq3m1ylDm3vegAZo2ThRreHkXsOx/UCTPb66J9DBp4LKNwuID/DwhzNq/jMaBFHH7YCzVdjX3Z1XJuIVjb3LcfDGzbDNxwB1o10Ne57y1kzRi8FpByW3Q5JWAoZ05J9NY20RMLJe8FkLsV3XVpoRyiMhKOdrJZCFjPeiwvvruUUW+rbicGHChli/zHyZ3m2A+rzMMsc1DxjWGHJcEWAF4Jjm8yoe6UlDfNb6tWzOYHByw3BlXBFhfVgZEbAw/sahXhZtS8Wn332n0aitIHeBRw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1750332034; c=relaxed/relaxed; bh=PBUsi0YBNMAsSBVKTalCtjkPCy5c9CLBxMjhKRUhDZY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=egJWzuQ7OR1NmWfV+freX30XgVqSn+B61wpRAsW1pwTVoDdBVaGWjK5sRlBCiGYmjNjz9u2trLZ1UIlOzHSRbJbMsK6VtWRSyCQaNnTr43w/G14ayEoWDjZLoV27ED+KBphH0Ts28i2rQEFHk/kAb920u8eGkQWRvjoeVoy6AP0lcM/ALuwbhXbj1O96gPiKzCwcs0deGqegW+Tz9Quf1EryM2Kl4g5uorgD0NdAz4crfLmYkw+o/D/sGlaA0rvIIm3M9QKSYsnSeuPV+76H4yWFrgPGeZRXZkyi9f3MY8zAnyfl5aFvBNjC5FY5Jnm+zRVa8YsYl84XSF4QxQ5Kvg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=y5WkYUtb; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::b2a; helo=mail-yb1-xb2a.google.com; envelope-from=ulf.hansson@linaro.org; receiver=lists.ozlabs.org) smtp.mailfrom=linaro.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=y5WkYUtb; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::b2a; helo=mail-yb1-xb2a.google.com; envelope-from=ulf.hansson@linaro.org; receiver=lists.ozlabs.org) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4bNJ7N2ZxMz2yFJ for ; Thu, 19 Jun 2025 21:20:31 +1000 (AEST) Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-e819aa98e7aso620765276.2 for ; Thu, 19 Jun 2025 04:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750332029; x=1750936829; darn=lists.ozlabs.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PBUsi0YBNMAsSBVKTalCtjkPCy5c9CLBxMjhKRUhDZY=; b=y5WkYUtb31T3JMoeZbLvKkXeJnVoqbgZssYAfVMjU2od/bOvFusLkVhjLt2m7se6oG JDF567Xdcg3jMbn74HpXuat+oADIdnpAOTummuTTS8gQipxuCVqCXG1lMNBu6dau9j6/ MfEmRjaky2Ax+LFOb7Y70fAy+M55pLNBnvFxfn7AbzyYIl9sToJkDJS6kJQ5TjAH8nKg EvBN1sGtCnfqZ0t0PKTxLTqPBSyNdx2wfFryJigeef6+A53sgioRtEWCtNj38cuVo7FK lCsaAgdSOTF5Nep5lhfj87QFF8o3pQPG5lSsLa40yzMfzaUrM9RsMVGZYqre5eyVC0oJ OHuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750332029; x=1750936829; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PBUsi0YBNMAsSBVKTalCtjkPCy5c9CLBxMjhKRUhDZY=; b=eZsMyA/aBYdMPgLENBD8V9XydE3ZllkR18W9g/y2HpR8PbAAUz4SiPpyUa/Lfkehmy Hq73x1idMJ1UlPLnZD7hHn2biRTNwuv2+aqULWzDrkZ5vtQAVNcX+vVQngwbp+W78uV5 GxV4ZmvY1j7bbLXq/k8ppKL3jhCrb3HqtFzs3PhDnlvpnhkq5bPVOByO332K1eHPbUyK GHZoNpC5K5lPH1+2IoyppNKPDl+l35ZtFlXXcbCgDV98Dhd/wf8hpv6ccTprey3d9/bs sjyHVfZqXTs7PinpGhWkYDrG/f2PN3pKmUnyF8ZfD5H58RaiOlRv4hJcRz5wMUkynX4F FudQ== X-Forwarded-Encrypted: i=1; AJvYcCXbV9YcVk4TMiOGAgyY9toWU59f/TXD8SY5nS8Fjd4ZyDOF2Crd9eR2iEF4kxY8tMK1ESQ97YzGC/wMIos=@lists.ozlabs.org X-Gm-Message-State: AOJu0YzWEzzWY5XYGTWM1tLRCP101t1BhKjJkbq1/SziCwlsJMIBZbsR fk8BDxlzrWutidmJKBpmPDyvrEqs8XGXSYjEbQg1IBJnrvEH/VaErrycA/SjdrdLgjhNvKVwvAH W/mmW7nnJw37eCrToL7cI8G4M5lTibWmSr1mP0QGq0g== X-Gm-Gg: ASbGncs++IFwAoeEZSeUAAb4kC2l398VDrkWTNCSguxUucmjQkH9XK+nQCxjL5zDWb6 EsgnJ+UmHGS4BsdSqjHjukVDhAoIDeQta2XLYMBoVjy3aFYsTZA/svle7gAuWeSMP1qWoFTc5yV ukiu9q97QyA3D+qXp93WiXF3Rw9MAN0YJ83Suw0dqJUYLL X-Google-Smtp-Source: AGHT+IHX9ksGPdiWQPczJro/bAe1IGvypwqoP8WCOZDCwwHcVTV4TvNUdtBj0nob0BRaQUU78E2vrWhUpGn208sRiuY= X-Received: by 2002:a05:6902:1b04:b0:e82:13f4:6156 with SMTP id 3f1490d57ef6-e822acc6b88mr30435408276.13.1750332028965; Thu, 19 Jun 2025 04:20:28 -0700 (PDT) X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Thu, 19 Jun 2025 13:19:50 +0200 X-Gm-Features: AX0GCFvvZQe_9Nix73DE7Q-G_-P34yyA4RJkioiqjIQNcE5PdVnCw3Am06hW7zc Message-ID: Subject: Re: [PATCH v3 00/35] mmc: Cleanup sdhci_pltfm_free()/sdhci_free_host() usage To: Binbin Zhou Cc: Binbin Zhou , Huacai Chen , Adrian Hunter , Huacai Chen , linux-mmc@vger.kernel.org, Andrew Jeffery , Taichi Sugaya , Takao Orito , Ben Dooks , Jaehoon Chung , Florian Fainelli , Ray Jui , Scott Branden , Kamal Dasu , Al Cooper , Haibo Chen , Shawn Guo , Sascha Hauer , Fabio Estevam , imx@lists.linux.dev, Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , openbmc@lists.ozlabs.org, Michal Simek , Joel Stanley , linux-aspeed@lists.ozlabs.org, Aubin Constans , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Yixun Lan , linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Jacky Huang , Shan-Chun Hung , Steen Hegelund , Daniel Machon , Vignesh Raghavendra , Patrice Chotard , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org, Hu Ziji Content-Type: text/plain; charset="UTF-8" On Sat, 7 Jun 2025 at 09:32, Binbin Zhou wrote: > > Hi all: > > After the first part of the cleanup[1], there are sdhci related > drivers that need further cleanup. > > This patchset is the second part of the cleanup series, and since sdhci has > sdhci_alloc_host() as the general interface, our main job is to clean up > sdhci_pltfm_free() and sdhci_free_host(). > > [1]: https://lore.kernel.org/all/cover.1748933789.git.zhoubinbin@loongson.cn/ > > Thanks. > > ----- > V3: > - Collect Reviewed-by and Acked-by tags. > Patch-19: > - Use dev_err_probe() to cleanup the code. > Patch-32: > - Fix build warning by lkp: > https://lore.kernel.org/all/202505300815.tjQRQD6z-lkp@intel.com/ > > Link to V2: > https://lore.kernel.org/all/cover.1748515612.git.zhoubinbin@loongson.cn/ > > V2: > - Collect Reviewed-by and Acked-by tags. > > Patch-01: > - Set sdhci_free_host() to empty, rather than dropping it. > Patch-07: > - Set sdhci_pltfm_free() to empty, rather than dropping it. > Patch-22: > - As requested by Yixun, retain the goto scheme. > Patch-35: > - New patch; > - Since all calls have been cleaned up, sdhci_pltfm_free()/sdhci_free_host() > are now dropped directly; > > Link to V1: > https://lore.kernel.org/all/cover.1747792905.git.zhoubinbin@loongson.cn/ > > Binbin Zhou (35): > mmc: sdhci: Use devm_mmc_alloc_host() helper > mmc: sdhci-acpi: Drop the use of sdhci_free_host() > mmc: sdhci-milbeaut: Drop the use of sdhci_free_host() > mmc: sdhci-pci: Drop the use of sdhci_free_host() > mmc: sdhci-s3c: Drop the use of sdhci_free_host() > mmc: sdhci-spear: Drop the use of sdhci_free_host() > mmc: sdhci-pltfm: Drop the use of sdhci_pltfm_free() > mmc: sdhci-bcm-kona: Drop the use of sdhci_pltfm_free() > mmc: sdhci-brcmstb: Drop the use of sdhci_pltfm_free() > mmc: sdhci-cadence: Drop the use of sdhci_pltfm_free() > mmc: sdhci-dove: Drop the use of sdhci_pltfm_free() > mmc: sdhci-esdhc-imx: Drop the use of sdhci_pltfm_free() > mmc: sdhci-esdhc-mcf: Drop the use of sdhci_pltfm_free() > mmc: sdhci-iproc: Drop the use of sdhci_pltfm_free() > mmc: sdhci-msm: Drop the use of sdhci_pltfm_free() > mmc: sdhci-npcm: Drop the use of sdhci_pltfm_free() > mmc: sdhci-of-arasan: Drop the use of sdhci_pltfm_free() > mmc: sdhci-of-aspeed: Drop the use of sdhci_pltfm_free() > mmc: sdhci-of-at91: Drop the use of sdhci_pltfm_free() > mmc: sdhci-of-dwcmshc: Drop the use of sdhci_pltfm_free() > mmc: sdhci-of-esdhc: Drop the use of sdhci_pltfm_free() > mmc: sdhci-of-k1: Drop the use of sdhci_pltfm_free() > mmc: sdhci-of-ma35d1: Drop the use of sdhci_pltfm_free() > mmc: sdhci-of-sparx5: Drop the use of sdhci_pltfm_free() > mmc: sdhci-omap: Drop the use of sdhci_pltfm_free() > mmc: sdhci-pic32: Drop the use of sdhci_pltfm_free() > mmc: sdhci-pxav2: Drop the use of sdhci_pltfm_free() > mmc: sdhci-pxav3: Drop the use of sdhci_pltfm_free() > mmc: sdhci-sprd: Drop the use of sdhci_pltfm_free() > mmc: sdhci-st: Drop the use of sdhci_pltfm_free() > mmc: sdhci-tegra: Drop the use of sdhci_pltfm_free() > mmc: sdhci-xenon: Drop the use of sdhci_pltfm_free() > mmc: sdhci_am654: Drop the use of sdhci_pltfm_free() > mmc: sdhci_f_sdh30: Drop the use of sdhci_pltfm_free() > mmc: sdhci: Drop sdhci_free_host()/sdhci_pltfm_free() interface > > drivers/mmc/host/sdhci-acpi.c | 3 --- > drivers/mmc/host/sdhci-bcm-kona.c | 2 -- > drivers/mmc/host/sdhci-brcmstb.c | 1 - > drivers/mmc/host/sdhci-cadence.c | 21 ++++++------------ > drivers/mmc/host/sdhci-dove.c | 12 ++--------- > drivers/mmc/host/sdhci-esdhc-imx.c | 3 --- > drivers/mmc/host/sdhci-esdhc-mcf.c | 25 ++++++---------------- > drivers/mmc/host/sdhci-iproc.c | 18 ++++------------ > drivers/mmc/host/sdhci-milbeaut.c | 19 ++++++----------- > drivers/mmc/host/sdhci-msm.c | 11 ++++------ > drivers/mmc/host/sdhci-npcm.c | 15 +++---------- > drivers/mmc/host/sdhci-of-arasan.c | 26 +++++++---------------- > drivers/mmc/host/sdhci-of-aspeed.c | 10 ++------- > drivers/mmc/host/sdhci-of-at91.c | 30 ++++++++++---------------- > drivers/mmc/host/sdhci-of-dwcmshc.c | 14 +++++------- > drivers/mmc/host/sdhci-of-esdhc.c | 11 ++-------- > drivers/mmc/host/sdhci-of-k1.c | 1 - > drivers/mmc/host/sdhci-of-ma35d1.c | 23 +++++++------------- > drivers/mmc/host/sdhci-of-sparx5.c | 24 +++++++-------------- > drivers/mmc/host/sdhci-omap.c | 21 ++++++------------ > drivers/mmc/host/sdhci-pci-core.c | 9 ++------ > drivers/mmc/host/sdhci-pic32.c | 9 +++----- > drivers/mmc/host/sdhci-pltfm.c | 16 +------------- > drivers/mmc/host/sdhci-pltfm.h | 1 - > drivers/mmc/host/sdhci-pxav2.c | 26 ++++++----------------- > drivers/mmc/host/sdhci-pxav3.c | 7 +----- > drivers/mmc/host/sdhci-s3c.c | 16 ++++---------- > drivers/mmc/host/sdhci-spear.c | 11 ++++------ > drivers/mmc/host/sdhci-sprd.c | 33 +++++++++-------------------- > drivers/mmc/host/sdhci-st.c | 6 ++---- > drivers/mmc/host/sdhci-tegra.c | 9 +++----- > drivers/mmc/host/sdhci-xenon.c | 15 +++++-------- > drivers/mmc/host/sdhci.c | 9 +------- > drivers/mmc/host/sdhci.h | 1 - > drivers/mmc/host/sdhci_am654.c | 20 ++++++----------- > drivers/mmc/host/sdhci_f_sdh30.c | 13 ++++-------- > 36 files changed, 135 insertions(+), 356 deletions(-) > > The series applied for next, thanks! Kind regards Uffe