From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Date: Thu, 22 Aug 2019 13:45:19 +0200 Subject: [PATCH v5 1/2] dt-bindings: mmc: Document Aspeed SD controller In-Reply-To: <6c94aada-9c4a-4f55-9a43-349282ad12af@www.fastmail.com> References: <20190807003629.2974-1-andrew@aj.id.au> <20190807003629.2974-2-andrew@aj.id.au> <6c94aada-9c4a-4f55-9a43-349282ad12af@www.fastmail.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 15 Aug 2019 at 07:37, Andrew Jeffery wrote: > > > > On Thu, 15 Aug 2019, at 15:06, Joel Stanley wrote: > > On Wed, 7 Aug 2019 at 00:38, Andrew Jeffery wrote: > > > > > > The ASPEED SD/SDIO/MMC controller exposes two slots implementing the > > > SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit > > > data bus if only a single slot is enabled. > > > > > > Signed-off-by: Andrew Jeffery > > > > Reviewed-by: Joel Stanley > > > > Two minor comments below. > > > > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > @@ -0,0 +1,105 @@ > > > +# SPDX-License-Identifier: GPL-2.0-or-later > > > > No "Copyright IBM" ? > > I'm going rogue. > > That reminds me I should chase up where we got to with the binding > licensing. > > > > > > +%YAML 1.2 > > > +--- > > > > > + > > > +examples: > > > + - | > > > + #include > > > + sdc at 1e740000 { > > > + compatible = "aspeed,ast2500-sd-controller"; > > > + reg = <0x1e740000 0x100>; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + ranges = <0 0x1e740000 0x10000>; > > > > According to the datasheet this could be 0x20000. It does not matter > > though, as there's nothing in it past 0x300. > > Good catch. > Are you planning on sending a v6 or you want me to apply this and you can post a patch on top? Kind regards Uffe