From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org Date: Sat, 17 Jul 2021 08:12:52 +0200 Subject: [PATCH 06/14] peci: Add core infrastructure In-Reply-To: References: <20210712220447.957418-1-iwona.winiarska@intel.com> <20210712220447.957418-7-iwona.winiarska@intel.com> <59428599ef7efb2521bd62c49a3bc55c710f29de.camel@intel.com> <6807a14deb52956ad2fe390b1811dd98901a642a.camel@intel.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Jul 16, 2021 at 02:50:04PM -0700, Dan Williams wrote: > On Fri, Jul 16, 2021 at 2:08 PM Winiarska, Iwona > > > > +} > > > > +EXPORT_SYMBOL_NS_GPL(peci_controller_add, PECI); > > > > > > I think it's cleaner to declare symbol namespaces in the Makefile. In > > > this case, add: > > > > > > cflags-y += -DDEFAULT_SYMBOL_NAMESPACE=PECI > > > > > > ...and just use EXPORT_SYMBOL_GPL as normal in the C file. > > > > > > > I kind of prefer the more verbose EXPORT_SYMBOL_NS_GPL - it also > > doesn't "hide" the fact that we're using namespaces (everything is in > > the C file rather than mixed into Makefile), but it's not a strong > > opinion, so sure - I can change this. > > > > Perhaps as a tie breaker, the maintainer you are submitting this to, > Greg, uses the -DDEFAULT_SYMBOL_NAMESPACE scheme in his subsystem, > drivers/usb/. We did that because namespaces were added _after_ the kernel code was already there. For new code like this, the original use of EXPORT_SYMBOL_NS_GPL() is best as it is explicit and obvious. No need to dig around in a Makefile to find out the namespace name. thanks, greg k-h