From: Andrew Lunn <andrew@lunn.ch>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2] mdio: aspeed: Fix "Link is Down" issue
Date: Thu, 25 Nov 2021 15:47:10 +0100 [thread overview]
Message-ID: <YZ+h7qXTLvRRXpj0@lunn.ch> (raw)
In-Reply-To: <20211125024432.15809-1-dylan_hung@aspeedtech.com>
On Thu, Nov 25, 2021 at 10:44:32AM +0800, Dylan Hung wrote:
> The issue happened randomly in runtime. The message "Link is Down" is
> popped but soon it recovered to "Link is Up".
>
> The "Link is Down" results from the incorrect read data for reading the
> PHY register via MDIO bus. The correct sequence for reading the data
> shall be:
> 1. fire the command
> 2. wait for command done (this step was missing)
> 3. wait for data idle
> 4. read data from data register
>
> Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
> Cc: stable at vger.kernel.org
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-11-25 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 2:44 [PATCH v2] mdio: aspeed: Fix "Link is Down" issue Dylan Hung
2021-11-25 14:47 ` Andrew Lunn [this message]
2021-11-25 15:35 ` Russell King
2021-11-25 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ+h7qXTLvRRXpj0@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox