From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Mon, 4 Apr 2022 16:45:50 +0200 Subject: [PATCH] serial: 8250_aspeed_vuart: Fix potential NULL dereference in aspeed_vuart_probe In-Reply-To: <20220404143842.16960-1-linmq006@gmail.com> References: <20220404143842.16960-1-linmq006@gmail.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Apr 04, 2022 at 02:38:40PM +0000, Miaoqian Lin wrote: > platform_get_resource() may fail and return NULL, so we should > better check it's return value to avoid a NULL pointer dereference. > > Fixes: 54da3e381c2b ("serial: 8250_aspeed_vuart: use UPF_IOREMAP to set up register mapping") > Signed-off-by: Miaoqian Lin > --- > drivers/tty/serial/8250/8250_aspeed_vuart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c > index 93fe10c680fb..9d2a7856784f 100644 > --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c > +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c > @@ -429,6 +429,8 @@ static int aspeed_vuart_probe(struct platform_device *pdev) > timer_setup(&vuart->unthrottle_timer, aspeed_vuart_unthrottle_exp, 0); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -EINVAL; How did you test this change was correct?