From: Greg KH <gregkh@linuxfoundation.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] usb: gadget: udc: clean up comments
Date: Mon, 11 Apr 2022 14:24:48 +0200 [thread overview]
Message-ID: <YlQeEC41m3UeOeiE@kroah.com> (raw)
In-Reply-To: <ecd8609b-2c52-5fb8-7820-191559d76011@redhat.com>
On Mon, Apr 11, 2022 at 04:49:00AM -0700, Tom Rix wrote:
>
> On 4/11/22 3:22 AM, Andy Shevchenko wrote:
> > On Sun, Apr 10, 2022 at 11:08:28AM -0400, Tom Rix wrote:
> > > SPDX
> > > *.h use /* */ style comments
> > >
> > > For double words, remove
> > > with, also
> > >
> > > Spelling replacements
> > > wayt to way
> > > wakup to wakeup
> > > Contrl to Control
> > > cheks to checks
> > > initiaization to initialization
> > > dyanmic to dynamic
> > Something really wrong with indentation above.
> >
> > ...
> >
> > > drivers/usb/gadget/udc/amd5536udc.h | 2 +-
> > > drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +-
> > > drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +-
> > > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +-
> > > drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++--
> > > drivers/usb/gadget/udc/at91_udc.c | 2 +-
> > > drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++--
> > > drivers/usb/gadget/udc/core.c | 4 ++--
> > > drivers/usb/gadget/udc/trace.h | 2 +-
> > I believe that Greg's bot asks to split on per-driver basis.
> > OTOH I don't see anything that can be problematic if in one
> > change. So, it's up to maintainers then.
>
> Yes, whatever folks want. I can split these.
>
> I have been cleaning up the comments in other areas and am trying to strike
> a balance between too big of a patch vs peppering with many single changes.
Patch series are much easier to review and is just as simple to apply as
a single patch, so that makes it overall better for you to do.
thanks,
greg k-h
next prev parent reply other threads:[~2022-04-11 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 15:08 [PATCH] usb: gadget: udc: clean up comments Tom Rix
2022-04-10 15:18 ` Greg KH
2022-04-11 10:22 ` Andy Shevchenko
2022-04-11 11:49 ` Tom Rix
2022-04-11 12:24 ` Greg KH [this message]
2022-04-11 12:54 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlQeEC41m3UeOeiE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox