* [PATCH v3 1/3] firmware: Add boot information to sysfs
2022-02-04 7:22 [PATCH v3 0/3] firmware: Add boot information to sysfs Joel Stanley
@ 2022-02-04 7:22 ` Joel Stanley
2022-04-22 6:46 ` Greg Kroah-Hartman
2022-02-04 7:22 ` [PATCH v3 2/3] ARM: aspeed: Add secure boot controller support Joel Stanley
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Joel Stanley @ 2022-02-04 7:22 UTC (permalink / raw)
To: linux-aspeed
Machines often have firmware that perform some action before Linux is
loaded. It's useful to know how this firmware is configured, so create a
sysfs directory and some properties that a system can choose to expose
to describe how the system was started.
Currently the intended use describes four files, relating to hardware
root of trust configuration.
These properties are populated by platform code at startup. Using fixed
values is suitable as the state that the system booted in will not
change after firmware has handed over.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v2:
- Rewrite so properties are present in common code and are exposed based
on the is_visible callback.
- Use sysfs_emit
v3:
- drop uart_boot
- Add kerneldoc to header
- Rename en -> present
- Rename val -> value
- Drop unncessary __init from header
- Wrap macro in do { } while(0)
---
.../ABI/testing/sysfs-firmware-bootinfo | 37 +++++++++
drivers/base/firmware.c | 80 +++++++++++++++++++
include/linux/firmware_bootinfo.h | 48 +++++++++++
3 files changed, 165 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-firmware-bootinfo
create mode 100644 include/linux/firmware_bootinfo.h
diff --git a/Documentation/ABI/testing/sysfs-firmware-bootinfo b/Documentation/ABI/testing/sysfs-firmware-bootinfo
new file mode 100644
index 000000000000..cd8eeaa49a00
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-firmware-bootinfo
@@ -0,0 +1,37 @@
+What: /sys/firmware/bootinfo/*
+Date: Jan 2022
+Description:
+ A system can expose information about how it was started in
+ this directory.
+
+ This information is agnostic as to the firmware implementation.
+
+ A system may expose a subset of these properties as applicable.
+
+
+What: /sys/firmware/bootinfo/secure_boot
+Date: Jan 2022
+Description:
+ Indicates the system was started with secure boot enabled in
+ the firmware.
+
+
+What: /sys/firmware/bootinfo/abr_image
+Date: Jan 2022
+Description:
+ Indicates the system was started from the alternate image
+ loaded from an Alternate Boot Region. Often this is a result of
+ the primary firmware image failing to start the system.
+
+
+What: /sys/firmware/bootinfo/low_security_key
+Date: Jan 2022
+Description:
+ Indicates the system's secure boot was verified with a low
+ security or development key.
+
+What: /sys/firmware/bootinfo/otp_protected
+Date: Jan 2022
+Description:
+ Indicates the system's boot configuration region is write
+ protected and cannot be modified.
diff --git a/drivers/base/firmware.c b/drivers/base/firmware.c
index 8dff940e0db9..8d1a7a36784c 100644
--- a/drivers/base/firmware.c
+++ b/drivers/base/firmware.c
@@ -11,6 +11,7 @@
#include <linux/module.h>
#include <linux/init.h>
#include <linux/device.h>
+#include <linux/firmware_bootinfo.h>
#include "base.h"
@@ -24,3 +25,82 @@ int __init firmware_init(void)
return -ENOMEM;
return 0;
}
+
+/*
+ * Exposes attributes documented in Documentation/ABI/testing/sysfs-firmware-bootinfo
+ */
+static struct bootinfo bootinfo;
+
+static ssize_t abr_image_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ return sysfs_emit(buf, "%d\n", bootinfo.abr_image.value);
+}
+static DEVICE_ATTR_RO(abr_image);
+
+static ssize_t low_security_key_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ return sysfs_emit(buf, "%d\n", bootinfo.low_security_key.value);
+}
+static DEVICE_ATTR_RO(low_security_key);
+
+static ssize_t otp_protected_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ return sysfs_emit(buf, "%d\n", bootinfo.otp_protected.value);
+}
+static DEVICE_ATTR_RO(otp_protected);
+
+static ssize_t secure_boot_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ return sysfs_emit(buf, "%d\n", bootinfo.secure_boot.value);
+}
+static DEVICE_ATTR_RO(secure_boot);
+
+#define ATTR_ENABLED(a) ((attr == &dev_attr_##a.attr) && bootinfo.a.present)
+
+static umode_t bootinfo_attr_mode(struct kobject *kobj, struct attribute *attr, int index)
+{
+ if (ATTR_ENABLED(abr_image))
+ return 0444;
+
+ if (ATTR_ENABLED(otp_protected))
+ return 0444;
+
+ if (ATTR_ENABLED(low_security_key))
+ return 0444;
+
+ if (ATTR_ENABLED(otp_protected))
+ return 0444;
+
+ if (ATTR_ENABLED(low_security_key))
+ return 0444;
+
+ if (ATTR_ENABLED(secure_boot))
+ return 0444;
+
+ return 0;
+}
+
+static struct attribute *bootinfo_attrs[] = {
+ &dev_attr_abr_image.attr,
+ &dev_attr_low_security_key.attr,
+ &dev_attr_otp_protected.attr,
+ &dev_attr_secure_boot.attr,
+ NULL,
+};
+
+static const struct attribute_group bootinfo_attr_group = {
+ .attrs = bootinfo_attrs,
+ .is_visible = bootinfo_attr_mode,
+};
+
+int __init firmware_bootinfo_init(struct bootinfo *bootinfo_init)
+{
+ struct kobject *kobj = kobject_create_and_add("bootinfo", firmware_kobj);
+ if (!kobj)
+ return -ENOMEM;
+
+ memcpy(&bootinfo, bootinfo_init, sizeof(bootinfo));
+
+ return sysfs_create_group(kobj, &bootinfo_attr_group);
+}
+EXPORT_SYMBOL_GPL(firmware_bootinfo_init);
diff --git a/include/linux/firmware_bootinfo.h b/include/linux/firmware_bootinfo.h
new file mode 100644
index 000000000000..237da83b673c
--- /dev/null
+++ b/include/linux/firmware_bootinfo.h
@@ -0,0 +1,48 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* Copyright 2022 IBM Corp. */
+
+#include <linux/sysfs.h>
+#include <linux/init.h>
+
+#define BOOTINFO_SET(b, n, v) do {b.n.present = true; b.n.value = v; } while (0)
+
+/**
+ * struct bootinfo_entry - A bootinfo sysfs entry
+ * @present: true if the file should be present (visible) in sysfs
+ * @value: value of the entry, will be printed as 1 or 0
+ *
+ * Contains the state of a given bootinfo sysfs file, to be filled out by the
+ * platform that wishes it to be present.
+ *
+ * It is used by sysfs. The is_present callback tests .present indicate the
+ * attribute should be shown, and by the show callback tests .value to display
+ * the value.
+ */
+struct bootinfo_entry {
+ bool present;
+ bool value;
+};
+
+/**
+ * struct bootinfo: A collection of bootinfo entries
+ * @abr_image: sysfs property
+ * @low_security_key: sysfs property
+ * @otp_protected: sysfs property
+ * @secure_boot: sysfs property
+ *
+ * The documented set of bootinfo entries to be displayed in
+ * /sys/firmware/bootinfo. Platform code populates a struct bootinfo and
+ * passes it to firmware_bootinfo_init, which takes a copy to be used at
+ * runtime.
+ *
+ * See struct bootinfo_entry for a description of the information each entry
+ * contiains.
+ */
+struct bootinfo {
+ struct bootinfo_entry abr_image;
+ struct bootinfo_entry low_security_key;
+ struct bootinfo_entry otp_protected;
+ struct bootinfo_entry secure_boot;
+};
+
+int firmware_bootinfo_init(struct bootinfo *bootinfo_init);
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3 1/3] firmware: Add boot information to sysfs
2022-02-04 7:22 ` [PATCH v3 1/3] " Joel Stanley
@ 2022-04-22 6:46 ` Greg Kroah-Hartman
2022-04-22 9:05 ` Arnd Bergmann
0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-22 6:46 UTC (permalink / raw)
To: linux-aspeed
On Fri, Feb 04, 2022 at 05:52:32PM +1030, Joel Stanley wrote:
> Machines often have firmware that perform some action before Linux is
> loaded. It's useful to know how this firmware is configured, so create a
> sysfs directory and some properties that a system can choose to expose
> to describe how the system was started.
>
> Currently the intended use describes four files, relating to hardware
> root of trust configuration.
>
> These properties are populated by platform code at startup. Using fixed
> values is suitable as the state that the system booted in will not
> change after firmware has handed over.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2:
> - Rewrite so properties are present in common code and are exposed based
> on the is_visible callback.
> - Use sysfs_emit
> v3:
> - drop uart_boot
> - Add kerneldoc to header
> - Rename en -> present
> - Rename val -> value
> - Drop unncessary __init from header
> - Wrap macro in do { } while(0)
> ---
> .../ABI/testing/sysfs-firmware-bootinfo | 37 +++++++++
> drivers/base/firmware.c | 80 +++++++++++++++++++
> include/linux/firmware_bootinfo.h | 48 +++++++++++
> 3 files changed, 165 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-firmware-bootinfo
> create mode 100644 include/linux/firmware_bootinfo.h
>
> diff --git a/Documentation/ABI/testing/sysfs-firmware-bootinfo b/Documentation/ABI/testing/sysfs-firmware-bootinfo
> new file mode 100644
> index 000000000000..cd8eeaa49a00
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-firmware-bootinfo
> @@ -0,0 +1,37 @@
> +What: /sys/firmware/bootinfo/*
> +Date: Jan 2022
It isn't January anymore :)
> +Description:
> + A system can expose information about how it was started in
> + this directory.
I do not understand what you mean by "how it was started".
> + This information is agnostic as to the firmware implementation.
How? This should be very firmware specific.
> +
> + A system may expose a subset of these properties as applicable.
> +
> +
> +What: /sys/firmware/bootinfo/secure_boot
> +Date: Jan 2022
> +Description:
> + Indicates the system was started with secure boot enabled in
> + the firmware.
What are the valid values of this file?
If this file is not present what does that mean?
> +
> +
> +What: /sys/firmware/bootinfo/abr_image
> +Date: Jan 2022
> +Description:
> + Indicates the system was started from the alternate image
> + loaded from an Alternate Boot Region. Often this is a result of
> + the primary firmware image failing to start the system.
What are the valid values here?
> +
> +
> +What: /sys/firmware/bootinfo/low_security_key
> +Date: Jan 2022
> +Description:
> + Indicates the system's secure boot was verified with a low
> + security or development key.
What is a "low security" key? What is a "development key"? What are
the valid values here?
> +
> +What: /sys/firmware/bootinfo/otp_protected
> +Date: Jan 2022
> +Description:
> + Indicates the system's boot configuration region is write
> + protected and cannot be modified.
What are the valid values here?
> diff --git a/drivers/base/firmware.c b/drivers/base/firmware.c
> index 8dff940e0db9..8d1a7a36784c 100644
> --- a/drivers/base/firmware.c
> +++ b/drivers/base/firmware.c
> @@ -11,6 +11,7 @@
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/device.h>
> +#include <linux/firmware_bootinfo.h>
>
> #include "base.h"
>
> @@ -24,3 +25,82 @@ int __init firmware_init(void)
> return -ENOMEM;
> return 0;
> }
> +
> +/*
> + * Exposes attributes documented in Documentation/ABI/testing/sysfs-firmware-bootinfo
> + */
> +static struct bootinfo bootinfo;
> +
> +static ssize_t abr_image_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> + return sysfs_emit(buf, "%d\n", bootinfo.abr_image.value);
> +}
> +static DEVICE_ATTR_RO(abr_image);
> +
> +static ssize_t low_security_key_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> + return sysfs_emit(buf, "%d\n", bootinfo.low_security_key.value);
> +}
> +static DEVICE_ATTR_RO(low_security_key);
> +
> +static ssize_t otp_protected_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> + return sysfs_emit(buf, "%d\n", bootinfo.otp_protected.value);
> +}
> +static DEVICE_ATTR_RO(otp_protected);
> +
> +static ssize_t secure_boot_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> + return sysfs_emit(buf, "%d\n", bootinfo.secure_boot.value);
> +}
> +static DEVICE_ATTR_RO(secure_boot);
> +
> +#define ATTR_ENABLED(a) ((attr == &dev_attr_##a.attr) && bootinfo.a.present)
> +
> +static umode_t bootinfo_attr_mode(struct kobject *kobj, struct attribute *attr, int index)
> +{
> + if (ATTR_ENABLED(abr_image))
> + return 0444;
> +
> + if (ATTR_ENABLED(otp_protected))
> + return 0444;
> +
> + if (ATTR_ENABLED(low_security_key))
> + return 0444;
> +
> + if (ATTR_ENABLED(otp_protected))
> + return 0444;
> +
> + if (ATTR_ENABLED(low_security_key))
> + return 0444;
> +
> + if (ATTR_ENABLED(secure_boot))
> + return 0444;
> +
> + return 0;
> +}
> +
> +static struct attribute *bootinfo_attrs[] = {
> + &dev_attr_abr_image.attr,
> + &dev_attr_low_security_key.attr,
> + &dev_attr_otp_protected.attr,
> + &dev_attr_secure_boot.attr,
> + NULL,
> +};
> +
> +static const struct attribute_group bootinfo_attr_group = {
> + .attrs = bootinfo_attrs,
> + .is_visible = bootinfo_attr_mode,
> +};
> +
> +int __init firmware_bootinfo_init(struct bootinfo *bootinfo_init)
> +{
> + struct kobject *kobj = kobject_create_and_add("bootinfo", firmware_kobj);
> + if (!kobj)
> + return -ENOMEM;
> +
> + memcpy(&bootinfo, bootinfo_init, sizeof(bootinfo));
> +
> + return sysfs_create_group(kobj, &bootinfo_attr_group);
If creating the group fails, shouldn't you remove the kobject?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v3 1/3] firmware: Add boot information to sysfs
2022-04-22 6:46 ` Greg Kroah-Hartman
@ 2022-04-22 9:05 ` Arnd Bergmann
2022-04-22 12:26 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Arnd Bergmann @ 2022-04-22 9:05 UTC (permalink / raw)
To: linux-aspeed
On Fri, Apr 22, 2022 at 8:46 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Feb 04, 2022 at 05:52:32PM +1030, Joel Stanley wrote:
> > +What: /sys/firmware/bootinfo/*
> > +Date: Jan 2022
>
> It isn't January anymore :)
The patch was sent on Feb 4, I would expect that to be close enough. Does this
need to be the month of the kernel release it is merged into instead?
> > +Description:
> > + A system can expose information about how it was started in
> > + this directory.
>
> I do not understand what you mean by "how it was started".
>
> > + This information is agnostic as to the firmware implementation.
>
> How? This should be very firmware specific.
The original patch was specific to a particular SoC vendor. Since the
information provided here is fairly generic in the end, I asked for
the interface
to be generalized to the point that it can be reused across multiple
vendors and architectures.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v3 1/3] firmware: Add boot information to sysfs
2022-04-22 9:05 ` Arnd Bergmann
@ 2022-04-22 12:26 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-22 12:26 UTC (permalink / raw)
To: linux-aspeed
On Fri, Apr 22, 2022 at 11:05:46AM +0200, Arnd Bergmann wrote:
> On Fri, Apr 22, 2022 at 8:46 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Fri, Feb 04, 2022 at 05:52:32PM +1030, Joel Stanley wrote:
> > > +What: /sys/firmware/bootinfo/*
> > > +Date: Jan 2022
> >
> > It isn't January anymore :)
>
> The patch was sent on Feb 4, I would expect that to be close enough. Does this
> need to be the month of the kernel release it is merged into instead?
That's usually best, but at least the month the patch was sent in is
good.
Also I notice there's no "who is responsible for this" entry here.
>
> > > +Description:
> > > + A system can expose information about how it was started in
> > > + this directory.
> >
> > I do not understand what you mean by "how it was started".
> >
> > > + This information is agnostic as to the firmware implementation.
> >
> > How? This should be very firmware specific.
>
> The original patch was specific to a particular SoC vendor. Since the
> information provided here is fairly generic in the end, I asked for
> the interface
> to be generalized to the point that it can be reused across multiple
> vendors and architectures.
Ok, and is that what this interface provides?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/3] ARM: aspeed: Add secure boot controller support
2022-02-04 7:22 [PATCH v3 0/3] firmware: Add boot information to sysfs Joel Stanley
2022-02-04 7:22 ` [PATCH v3 1/3] " Joel Stanley
@ 2022-02-04 7:22 ` Joel Stanley
2022-02-04 7:22 ` [PATCH v3 3/3] x86/setup: Populate bootinfo with secure boot status Joel Stanley
2022-04-22 6:48 ` [PATCH v3 0/3] firmware: Add boot information to sysfs Greg Kroah-Hartman
3 siblings, 0 replies; 8+ messages in thread
From: Joel Stanley @ 2022-02-04 7:22 UTC (permalink / raw)
To: linux-aspeed
This reads out the status of the secure boot controller and exposes it
in sysfs using the bootinfo sysfs api.
An example on a AST2600A3 QEMU model:
# grep -r . /sys/firmware/bootinfo/*
/sys/firmware/bootinfo/abr_image:0
/sys/firmware/bootinfo/low_security_key:0
/sys/firmware/bootinfo/otp_protected:0
/sys/firmware/bootinfo/secure_boot:1
On boot the state of the system according to the secure boot controller
will be printed:
[ 0.037634] AST2600 secure boot enabled
or
[ 0.037935] AST2600 secure boot disabled
The initialisation is changed from early_initcall to subsys_initcall
because we need the firmware_kobj to be initialised, and because there's
no requirement to print this information early.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v2:
- Rewrite to new bootinfo api
- Get rid of unused return values
v3:
- Drop uart_boot
---
drivers/soc/aspeed/aspeed-socinfo.c | 44 ++++++++++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/aspeed/aspeed-socinfo.c b/drivers/soc/aspeed/aspeed-socinfo.c
index 1ca140356a08..e5ced9bebfa2 100644
--- a/drivers/soc/aspeed/aspeed-socinfo.c
+++ b/drivers/soc/aspeed/aspeed-socinfo.c
@@ -8,6 +8,7 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/sys_soc.h>
+#include <linux/firmware_bootinfo.h>
static struct {
const char *name;
@@ -74,6 +75,45 @@ static const char *siliconid_to_rev(u32 siliconid)
return "??";
}
+/* Secure Boot Controller register */
+#define SEC_STATUS 0x14
+#define ABR_IMAGE_SOURCE BIT(13)
+#define OTP_PROTECTED BIT(8)
+#define LOW_SEC_KEY BIT(7)
+#define SECURE_BOOT BIT(6)
+#define UART_BOOT BIT(5)
+
+static void __init aspeed_bootinfo_init(void)
+{
+ struct device_node *np;
+ void __iomem *base;
+ struct bootinfo bootinfo = {};
+ u32 reg;
+
+ /* AST2600 only */
+ np = of_find_compatible_node(NULL, NULL, "aspeed,ast2600-sbc");
+ if (!of_device_is_available(np))
+ return;
+
+ base = of_iomap(np, 0);
+ if (!base)
+ of_node_put(np);
+
+ reg = readl(base + SEC_STATUS);
+
+ iounmap(base);
+ of_node_put(np);
+
+ BOOTINFO_SET(bootinfo, abr_image, reg & ABR_IMAGE_SOURCE);
+ BOOTINFO_SET(bootinfo, low_security_key, reg & LOW_SEC_KEY);
+ BOOTINFO_SET(bootinfo, otp_protected, reg & OTP_PROTECTED);
+ BOOTINFO_SET(bootinfo, secure_boot, reg & SECURE_BOOT);
+
+ firmware_bootinfo_init(&bootinfo);
+
+ pr_info("AST2600 secure boot %s\n", (reg & SECURE_BOOT) ? "enabled" : "disabled");
+}
+
static int __init aspeed_socinfo_init(void)
{
struct soc_device_attribute *attrs;
@@ -148,6 +188,8 @@ static int __init aspeed_socinfo_init(void)
attrs->revision,
attrs->soc_id);
+ aspeed_bootinfo_init();
+
return 0;
}
-early_initcall(aspeed_socinfo_init);
+subsys_initcall(aspeed_socinfo_init);
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3 3/3] x86/setup: Populate bootinfo with secure boot status
2022-02-04 7:22 [PATCH v3 0/3] firmware: Add boot information to sysfs Joel Stanley
2022-02-04 7:22 ` [PATCH v3 1/3] " Joel Stanley
2022-02-04 7:22 ` [PATCH v3 2/3] ARM: aspeed: Add secure boot controller support Joel Stanley
@ 2022-02-04 7:22 ` Joel Stanley
2022-04-22 6:48 ` [PATCH v3 0/3] firmware: Add boot information to sysfs Greg Kroah-Hartman
3 siblings, 0 replies; 8+ messages in thread
From: Joel Stanley @ 2022-02-04 7:22 UTC (permalink / raw)
To: linux-aspeed
bootinfo indicates to userspace that firmware is configured to boot with
secure boot.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v2: new
v3: no change
---
arch/x86/kernel/setup.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index f7a132eb794d..b805b758478f 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -23,6 +23,7 @@
#include <linux/usb/xhci-dbgp.h>
#include <linux/static_call.h>
#include <linux/swiotlb.h>
+#include <linux/firmware_bootinfo.h>
#include <uapi/linux/mount.h>
@@ -1100,17 +1101,22 @@ void __init setup_arch(char **cmdline_p)
setup_log_buf(1);
if (efi_enabled(EFI_BOOT)) {
+ struct bootinfo bootinfo = {};
+
switch (boot_params.secure_boot) {
case efi_secureboot_mode_disabled:
pr_info("Secure boot disabled\n");
+ BOOTINFO_SET(bootinfo, secure_boot, false);
break;
case efi_secureboot_mode_enabled:
pr_info("Secure boot enabled\n");
+ BOOTINFO_SET(bootinfo, secure_boot, true);
break;
default:
pr_info("Secure boot could not be determined\n");
break;
}
+ firmware_bootinfo_init(&bootinfo);
}
reserve_initrd();
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3 0/3] firmware: Add boot information to sysfs
2022-02-04 7:22 [PATCH v3 0/3] firmware: Add boot information to sysfs Joel Stanley
` (2 preceding siblings ...)
2022-02-04 7:22 ` [PATCH v3 3/3] x86/setup: Populate bootinfo with secure boot status Joel Stanley
@ 2022-04-22 6:48 ` Greg Kroah-Hartman
3 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-22 6:48 UTC (permalink / raw)
To: linux-aspeed
On Fri, Feb 04, 2022 at 05:52:31PM +1030, Joel Stanley wrote:
> v3 resolves Greg's review for the bootinfo header and macros, and drops
> uart_boot as it's unlikely to be common across platforms.
>
> v2 reworks the series to put the sysfs properties in the core, and
> optionally show them with the is_visible() callback.
>
> This is the second iteration of this idea. The first used socinfo
> custom attribute groups, but Arnd suggested we make this something
> standardised under /sys/firmware instead:
>
> http://lore.kernel.org/all/CAK8P3a3MRf0aGt1drkgsuZyBbeoy+S7Ha18SBM01q+3f33oL+Q at mail.gmail.com
>
> Some ARM systems have a firmware that provides a hardware root of
> trust. It's useful for the system to know how this root of trust has
> been configured, so provide a standardised interface that expose this
> information to userspace.
>
> This is implemented as a sysfs attribute group registration in the
> driver core, with platforms populating values obtained from firmware at
> kernel boot time.
>
> Patch 2 provides a user of the properties on an ARM system.
>
> Patch 3 is new in v2 and is an example of populating bootinfo with the
> EFI secure boot status.
I would like arch maintainers to review this before it going any
further.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread