From mboxrd@z Thu Jan  1 00:00:00 1970
From: Winiarska, Iwona <iwona.winiarska@intel.com>
Date: Fri, 30 Jul 2021 20:14:26 +0000
Subject: [PATCH 10/14] peci: Add peci-cpu driver
In-Reply-To: <26dbd0d3-c326-96a5-2ec7-4fc3387865e9@elsoft.ch>
References: <20210712220447.957418-1-iwona.winiarska@intel.com>
 <20210712220447.957418-11-iwona.winiarska@intel.com>
 <26dbd0d3-c326-96a5-2ec7-4fc3387865e9@elsoft.ch>
Message-ID: <a6b25deb2b9c7690270c9fdd619d980e6e26289f.camel@intel.com>
List-Id: <linux-aspeed.lists.ozlabs.org>
To: linux-aspeed@lists.ozlabs.org
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Tue, 2021-07-27 at 13:16 +0200, David M?ller (ELSOFT AG) wrote:
> Iwona Winiarska wrote:
> 
> > +static const struct peci_device_id peci_cpu_device_ids[] = {
> > +???????{ /* Haswell Xeon */
> > +???????????????.family?= 6,
> > +???????????????.model??= INTEL_FAM6_HASWELL_X,
> > +???????????????.data???= "hsx",
> > +???????},
> > +???????{ /* Broadwell Xeon */
> > +???????????????.family?= 6,
> > +???????????????.model??= INTEL_FAM6_BROADWELL_X,
> > +???????????????.data???= "bdx",
> > +???????},
> > +???????{ /* Broadwell Xeon D */
> > +???????????????.family?= 6,
> > +???????????????.model??= INTEL_FAM6_BROADWELL_D,
> > +???????????????.data???= "skxd",
> 
> I think this should read "bdxd" as "skxd" does not exist in the
> cputemp/dimmtemp drivers.

It should be "bdxd" - I'll fix it in v2.

Thank you
-Iwona