From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Basavaraj Natikar" <Basavaraj.Natikar@amd.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"David Rhodes" <david.rhodes@cirrus.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Sean Wang" <sean.wang@kernel.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Lars Persson" <lars.persson@axis.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Michal Simek" <michal.simek@amd.com>,
"Emil Renner Berthing" <kernel@esmil.dk>,
"Jianlong Huang" <jianlong.huang@starfivetech.com>,
"Hal Feng" <hal.feng@starfivetech.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com,
linux-mediatek@lists.infradead.org, linux-arm-kernel@axis.com,
linux-riscv@lists.infradead.org, linux-rtc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 16/17] pinctrl: Constify static 'pinctrl_desc'
Date: Wed, 28 May 2025 14:51:51 +0200 [thread overview]
Message-ID: <aDcG58lXUgtW7pRZ@lore-desk> (raw)
In-Reply-To: <20250528-pinctrl-const-desc-v1-16-76fe97899945@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 7720 bytes --]
> The local static 'struct pinctrl_desc' is not modified, so can be made
> const for code safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
For airoha bits:
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/pinctrl/berlin/berlin.c | 2 +-
> drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 2 +-
> drivers/pinctrl/mediatek/pinctrl-airoha.c | 2 +-
> drivers/pinctrl/pinctrl-artpec6.c | 2 +-
> drivers/pinctrl/pinctrl-bm1880.c | 2 +-
> drivers/pinctrl/pinctrl-k210.c | 2 +-
> drivers/pinctrl/pinctrl-lpc18xx.c | 2 +-
> drivers/pinctrl/pinctrl-mlxbf3.c | 2 +-
> drivers/pinctrl/pinctrl-tb10x.c | 2 +-
> drivers/pinctrl/pinctrl-zynq.c | 2 +-
> drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c | 2 +-
> 11 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c
> index c372a2a24be4bb80b1f2475ef8512171c8e1326f..e5a35b803ce66d247c5e5ad78e6677570a1add60 100644
> --- a/drivers/pinctrl/berlin/berlin.c
> +++ b/drivers/pinctrl/berlin/berlin.c
> @@ -283,7 +283,7 @@ static int berlin_pinctrl_build_state(struct platform_device *pdev)
> return 0;
> }
>
> -static struct pinctrl_desc berlin_pctrl_desc = {
> +static const struct pinctrl_desc berlin_pctrl_desc = {
> .name = "berlin-pinctrl",
> .pctlops = &berlin_pinctrl_ops,
> .pmxops = &berlin_pinmux_ops,
> diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> index 628b60ccc2b07dc77e36da8919436fa348749e0c..a90beb986f5bb707c54552e1333802943a4b04bc 100644
> --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> @@ -448,7 +448,7 @@ static const struct pinconf_ops cs42l43_pin_conf_ops = {
> .pin_config_group_set = cs42l43_pin_config_group_set,
> };
>
> -static struct pinctrl_desc cs42l43_pin_desc = {
> +static const struct pinctrl_desc cs42l43_pin_desc = {
> .name = "cs42l43-pinctrl",
> .owner = THIS_MODULE,
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> index b97b28ebb37a6ec092360f8ea404dd67e6c43eac..ccd2b512e8365b3a5af0bb223329f39119bc7078 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> @@ -2852,7 +2852,7 @@ static const struct pinctrl_ops airoha_pctlops = {
> .dt_free_map = pinconf_generic_dt_free_map,
> };
>
> -static struct pinctrl_desc airoha_pinctrl_desc = {
> +static const struct pinctrl_desc airoha_pinctrl_desc = {
> .name = KBUILD_MODNAME,
> .owner = THIS_MODULE,
> .pctlops = &airoha_pctlops,
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index 717f9592b28b51737e67aafc93664b1345511908..af67057128ff1e9e766b958fece9c71518c89081 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -907,7 +907,7 @@ static const struct pinconf_ops artpec6_pconf_ops = {
> .pin_config_group_set = artpec6_pconf_group_set,
> };
>
> -static struct pinctrl_desc artpec6_desc = {
> +static const struct pinctrl_desc artpec6_desc = {
> .name = "artpec6-pinctrl",
> .owner = THIS_MODULE,
> .pins = artpec6_pins,
> diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
> index b0000fe5b31dfbcd6af6eaf0c01029f00cbd205b..387798fb09be51cabd5cb76e0d90a28b1d363050 100644
> --- a/drivers/pinctrl/pinctrl-bm1880.c
> +++ b/drivers/pinctrl/pinctrl-bm1880.c
> @@ -1298,7 +1298,7 @@ static const struct pinmux_ops bm1880_pinmux_ops = {
> .set_mux = bm1880_pinmux_set_mux,
> };
>
> -static struct pinctrl_desc bm1880_desc = {
> +static const struct pinctrl_desc bm1880_desc = {
> .name = "bm1880_pinctrl",
> .pins = bm1880_pins,
> .npins = ARRAY_SIZE(bm1880_pins),
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index eddb01796a83eb86c8c5bcf6788c999e8bf2926a..66c04120c29deccf53b21cbf8705f1d10c74ace5 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -879,7 +879,7 @@ static const struct pinctrl_ops k210_pinctrl_ops = {
> .dt_free_map = pinconf_generic_dt_free_map,
> };
>
> -static struct pinctrl_desc k210_pinctrl_desc = {
> +static const struct pinctrl_desc k210_pinctrl_desc = {
> .name = "k210-pinctrl",
> .pins = k210_pins,
> .npins = K210_NPINS,
> diff --git a/drivers/pinctrl/pinctrl-lpc18xx.c b/drivers/pinctrl/pinctrl-lpc18xx.c
> index 0f5a7bed2f81b731714e3b65908df23f2ffdfd63..5e0201768323521754e7ecd27e878a81925c18a6 100644
> --- a/drivers/pinctrl/pinctrl-lpc18xx.c
> +++ b/drivers/pinctrl/pinctrl-lpc18xx.c
> @@ -1257,7 +1257,7 @@ static const struct pinctrl_ops lpc18xx_pctl_ops = {
> .dt_free_map = pinctrl_utils_free_map,
> };
>
> -static struct pinctrl_desc lpc18xx_scu_desc = {
> +static const struct pinctrl_desc lpc18xx_scu_desc = {
> .name = "lpc18xx/43xx-scu",
> .pins = lpc18xx_pins,
> .npins = ARRAY_SIZE(lpc18xx_pins),
> diff --git a/drivers/pinctrl/pinctrl-mlxbf3.c b/drivers/pinctrl/pinctrl-mlxbf3.c
> index ffb5dda364dc81808cfd5a168ce3f1e9f119357d..fcd9d46de89fb3e5215784109ba31b171fd15448 100644
> --- a/drivers/pinctrl/pinctrl-mlxbf3.c
> +++ b/drivers/pinctrl/pinctrl-mlxbf3.c
> @@ -231,7 +231,7 @@ static const struct pinmux_ops mlxbf3_pmx_ops = {
> .gpio_request_enable = mlxbf3_gpio_request_enable,
> };
>
> -static struct pinctrl_desc mlxbf3_pin_desc = {
> +static const struct pinctrl_desc mlxbf3_pin_desc = {
> .name = "pinctrl-mlxbf3",
> .pins = mlxbf3_pins,
> .npins = ARRAY_SIZE(mlxbf3_pins),
> diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10x.c
> index d6bb8f58978df1577db24f96c2174f47962b5520..2d2e9f697ff99b4209dda8d5511f478a18b26a21 100644
> --- a/drivers/pinctrl/pinctrl-tb10x.c
> +++ b/drivers/pinctrl/pinctrl-tb10x.c
> @@ -735,7 +735,7 @@ static const struct pinmux_ops tb10x_pinmux_ops = {
> .set_mux = tb10x_pctl_set_mux,
> };
>
> -static struct pinctrl_desc tb10x_pindesc = {
> +static const struct pinctrl_desc tb10x_pindesc = {
> .name = "TB10x",
> .pins = tb10x_pins,
> .npins = ARRAY_SIZE(tb10x_pins),
> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
> index caa8a2ca3e681718fe213921deca8d130371b122..dcde86fed10db3e2dfebc19cb841ea7f63e74989 100644
> --- a/drivers/pinctrl/pinctrl-zynq.c
> +++ b/drivers/pinctrl/pinctrl-zynq.c
> @@ -1143,7 +1143,7 @@ static const struct pinconf_ops zynq_pinconf_ops = {
> .pin_config_group_set = zynq_pinconf_group_set,
> };
>
> -static struct pinctrl_desc zynq_desc = {
> +static const struct pinctrl_desc zynq_desc = {
> .name = "zynq_pinctrl",
> .pins = zynq_pins,
> .npins = ARRAY_SIZE(zynq_pins),
> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> index 27f99183d994dccb92aac81ca42228bdb9225e87..aeaa0ded7c1e5ee7f9c5e4113bfd208fb844ba7d 100644
> --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> @@ -898,7 +898,7 @@ static const struct pinconf_ops starfive_pinconf_ops = {
> .is_generic = true,
> };
>
> -static struct pinctrl_desc starfive_desc = {
> +static const struct pinctrl_desc starfive_desc = {
> .name = DRIVER_NAME,
> .pins = starfive_pins,
> .npins = ARRAY_SIZE(starfive_pins),
>
> --
> 2.45.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-05-29 0:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 10:40 [PATCH 00/17] pinctrl: Constify pointers to 'pinctrl_desc' and more Krzysztof Kozlowski
2025-05-28 10:40 ` [PATCH 01/17] pinctrl: starfive: Allow compile testing on other platforms Krzysztof Kozlowski
2025-05-28 12:36 ` Geert Uytterhoeven
2025-05-28 12:51 ` Krzysztof Kozlowski
2025-05-28 10:40 ` [PATCH 02/17] pinctrl: Allow compile testing for K210, TB10X and ZYNQ Krzysztof Kozlowski
2025-05-29 6:26 ` Krzysztof Kozlowski
2025-05-28 10:40 ` [PATCH 03/17] pinctrl: amd: Constify pointers to 'pinctrl_desc' Krzysztof Kozlowski
2025-05-28 10:41 ` [PATCH 04/17] pinctrl: " Krzysztof Kozlowski
2025-05-28 12:47 ` Geert Uytterhoeven
2025-05-28 10:41 ` [PATCH 05/17] pinctrl: aspeed: Constify static 'pinctrl_desc' Krzysztof Kozlowski
2025-05-29 0:39 ` Andrew Jeffery
2025-05-28 10:41 ` [PATCH 06/17] pinctrl: nuvoton: " Krzysztof Kozlowski
2025-05-28 10:41 ` [PATCH 07/17] pinctrl: bcm: " Krzysztof Kozlowski
2025-05-28 16:45 ` Florian Fainelli
2025-05-28 10:41 ` [PATCH 08/17] pinctrl: bcm: cygnus-mux: Move fixed assignments to 'pinctrl_desc' definition Krzysztof Kozlowski
2025-05-28 16:46 ` Florian Fainelli
2025-05-28 10:41 ` [PATCH 09/17] pinctrl: bcm: cygnus-ns2: " Krzysztof Kozlowski
2025-05-28 16:46 ` Florian Fainelli
2025-05-28 10:41 ` [PATCH 10/17] pinctrl: bcm: cygnus-nsp: " Krzysztof Kozlowski
2025-05-28 16:46 ` Florian Fainelli
2025-05-28 10:41 ` [PATCH 11/17] pinctrl: as3722: " Krzysztof Kozlowski
2025-05-28 10:41 ` [PATCH 12/17] pinctrl: max77620: " Krzysztof Kozlowski
2025-05-28 10:41 ` [PATCH 13/17] pinctrl: palmas: " Krzysztof Kozlowski
2025-05-28 10:41 ` [PATCH 14/17] pinctrl: renesas: " Krzysztof Kozlowski
2025-05-28 12:54 ` Geert Uytterhoeven
2025-05-28 17:55 ` Krzysztof Kozlowski
2025-05-30 8:06 ` Geert Uytterhoeven
2025-05-28 10:41 ` [PATCH 15/17] pinctrl: pistachio: Constify static 'pinctrl_desc' Krzysztof Kozlowski
2025-05-28 10:41 ` [PATCH 16/17] pinctrl: " Krzysztof Kozlowski
2025-05-28 12:51 ` Lorenzo Bianconi [this message]
2025-05-28 16:41 ` Charles Keepax
2025-06-03 9:40 ` Jesper Nilsson
2025-05-28 10:41 ` [PATCH 17/17] rtc: stm32: " Krzysztof Kozlowski
2025-06-10 12:16 ` [PATCH 00/17] pinctrl: Constify pointers to 'pinctrl_desc' and more Linus Walleij
2025-06-11 6:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDcG58lXUgtW7pRZ@lore-desk \
--to=lorenzo@kernel.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@codeconstruct.com.au \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avifishman70@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjaminfair@google.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=dlemoal@kernel.org \
--cc=geert+renesas@glider.be \
--cc=hal.feng@starfivetech.com \
--cc=j.neuschaefer@gmx.net \
--cc=jesper.nilsson@axis.com \
--cc=jianlong.huang@starfivetech.com \
--cc=joel@jms.id.au \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars.persson@axis.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@amd.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@opensource.cirrus.com \
--cc=rafal@milecki.pl \
--cc=rf@opensource.cirrus.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sean.wang@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=vz@mleia.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).