From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19A37F506D9 for ; Mon, 16 Mar 2026 14:27:01 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fZHTv5fjrz2xlm; Tue, 17 Mar 2026 01:26:59 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773671219; cv=none; b=cB45J/MbbP3qNSj/rP34v3n/UAAxUyjU7FauYuZNUH4IZtMHFAVYGylzGsNJYC3MZogjCoyaBvTt7VqvP6Fns4ONoZRgPfAej2MVdY6F7V8YiZDxn+fPTRJfePojOYCGUomYCYgiHYLzL01SDc+0PQyfj5QwE3xi+mo2A38O987tPdVkRPiY2gFvYEiQY0xcp9DhoKRjgpXAptb6eQAnJI3RG0Vmc6JTY2SRMtui0NI0L9Sqosrss3Z3PhMH9ZRbh8kTMHxyRWsLHEU/bQvJe7cCFV+Rx3BZxV1UsjY/q3aE0Nh2clFMOMbAh9Gq0btnDdNEwI12s8sB2UENPvm/aw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773671219; c=relaxed/relaxed; bh=lxJ4lZ8qpN0azXDhDuYNMBFlk26kc4wHsRqoUGPLHbo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B9DlHfK/L31KYk5ICSqwZC1CYvYal5DYa2m8ITdoyVYKafjVbdj01SRfYJIZnWxZUDOK7Io7gGE8jYJbzRDLAtnouyYMh/GlRgb9EaxP8Tuk42JDinWtQKozez46tNS2MgSq31nZGwfYNu8EfYY3429FCuopfajfOdrI1Rpy4KuU6EVdc4lSG+EiGaBg91kPIkNtpqGMfc39N4RE9e4zwR2n+3qvg+wp918E20Kuff8ufywKmMkbIEzW2VJW82el3KT7WkI7FnRABjrN0KaPyJHTTbfcf8ekNvXGoov5QP3UOjmQXfE+uJ0NwoXgVAtSvIN5joWiA2iYqg3gEYIsLw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=nRZ0irxM; dkim-atps=neutral; spf=pass (client-ip=192.198.163.10; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=nRZ0irxM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.198.163.10; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fZHTt6RWkz2xS3 for ; Tue, 17 Mar 2026 01:26:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773671219; x=1805207219; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FHZKMW2URFGAFnuWPY2dSlQRkpSj1pWYiDSSZoc4g/A=; b=nRZ0irxML49znrLNSTo7ZcIm8x+TWu2STyJdkBV2ctJVq9O2qFdGEFje pudazJH7d8gG1/IZcEki8mgymZg2VQPZt3i58fNYs6I9TsYuZkT9OHlRv 33i1udPKmWRdvuY5jhpIQ3IlDCgeasUf87eNXsyDRrMIjQU3opciK2U5i LYtkN6aYOlLoNzZCmdeAh7+U78TWzbk0+BfA5FDJrPBVtqpFH0G0J59ZK B+qyTKHHRhes7dTN9rK8QP25iYsXJ6hgEgYPReXfSF92hZHUxT1ERmkxV tkeADxl6a/k1QT+2Rcl+z/HCuYjVfv8VxyPh7II6wL2BeZsJ8zueV/QJI w==; X-CSE-ConnectionGUID: AxB0btK/QbaXhRPzZZUzTQ== X-CSE-MsgGUID: xT/VVPa5QGanLJHFO9JVxg== X-IronPort-AV: E=McAfee;i="6800,10657,11731"; a="86039939" X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="86039939" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 07:26:57 -0700 X-CSE-ConnectionGUID: tsI2Z1KxQnWT9RmUCOp0KA== X-CSE-MsgGUID: F04AREtNTA2z0GTK803eTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="216439404" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.244.237]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 07:26:54 -0700 Date: Mon, 16 Mar 2026 16:26:51 +0200 From: Andy Shevchenko To: Billy Tsai Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, morris_mao@aspeedtech.com Subject: Re: [PATCH v2 3/3] iio: adc: aspeed: Reserve battery sensing channel for on-demand use Message-ID: References: <20260316-adc-v2-0-21475a217b09@aspeedtech.com> <20260316-adc-v2-3-21475a217b09@aspeedtech.com> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260316-adc-v2-3-21475a217b09@aspeedtech.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Mar 16, 2026 at 11:00:48AM +0800, Billy Tsai wrote: > For controllers with battery sensing capability (AST2600/AST2700), the > last channel uses a different circuit design optimized for battery > voltage measurement. This channel should not be enabled by default > along with other channels to avoid potential interference and power > efficiency issues. > This ensures optimal power efficiency for normal ADC operations while > maintaining full functionality when battery sensing is needed. ... > + /* > + * After enable a new channel need to wait some time for adc stable ADC > + * Experiment result is 1ms. > + */ > + mdelay(1); Why atomic? If not required, use fsleep(). Otherwise explain. > + } -- With Best Regards, Andy Shevchenko