From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDF35C5DF87 for ; Fri, 21 Aug 2026 11:27:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hRJ1j2gmKz2yFK; Fri, 21 Aug 2026 21:27:21 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1787311641; cv=none; b=f0H+leVHTPOhpRsOP8JIE1MhsIK48lRnq8N8zof/6LuWg+Qp38X0hBYg0ne/WZBAGtpjTwJBWs1JXwjllEM59XbQHvoB2ojdL13pFTq+Odd5t6oy5XczfPUfIHP7KRLs7uFVCVHBP/+GbGpKF4Kazcw6OrZ+Pgw5J6bNm3uJysiTHN2V3xl6rC+gb2fBt+GmmNRZ8HPNsOTbQ/RWfP2oX41Tdjs+W3fsMUR+b1RQcO0V6/+fzcoJPUADNeDprSz2UMqU2RaJfGh6Iad5tS9kBSq/toWNDD5J99ub4dnPCSbakb4hD2FNm01ZpxTP7kbWnJ0DDKX3nHBMHStllUXhfg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1787311641; c=relaxed/relaxed; bh=uG/8EL8JXjvMDpy4SvV1rUgqb7+YvQ/1G1UwXyHqxEc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=csdfGoEHgUn1PiUu2SgYseBG8y6lX5s5MxLFwiqr6NOlaxLg9pe0wcWGhsp4tfJjCD8K+f3bWxkWqcHJou9Ri46a+Soj9kvlu8OodMggiJ/UkozPuSyfuraVjNpLyj6BSl0yqoCMFcF6v2ErPRkakG0/jVmKc2hevuZ172V+kr6llF74uZkyHhamuSPHFBUk6O+Vsh10GznlJ9T7BHUyMwbCiI+yyiv0K9k4A0/h3JuvfRvqiQ86ZVjkkkGTppwVleBpMxO2aET0vXlHl73oNIa8SxUAQQ/Xfd7r3/KCepfjALVxZRTi6AJO/WF+bT4k0tBXC9jFldEoxSYHknLjmA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=fo+v/tde; dkim-atps=neutral; spf=pass (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=liviu.dudau@arm.com; receiver=lists.ozlabs.org) smtp.mailfrom=arm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=fo+v/tde; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=liviu.dudau@arm.com; receiver=lists.ozlabs.org) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4hRJ1f1NXVz2yFl for ; Fri, 21 Aug 2026 21:27:16 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 674E922C8 for ; Fri, 21 Aug 2026 04:26:39 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0D0883F763 for ; Fri, 21 Aug 2026 04:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1787311603; bh=qAWvudYMdASPXPfSTaqms42rgycSdo6rtQ42Q6DlQlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fo+v/tdes22aawQHBX6kCyZprCoYSB4ey/xQIj3WNtaSp1LyTHvaiTCJo4tqBr1Dq /2fDFcxeazIBoKH7E3lcyi/qJC+K+3Vbv8YOf/Vrwdh7Z5sOh9jyLEjSUgu5+WkDkV sFo23YJaGs0SxR1Nj9wJty0ParZxJw1wQIu2Awgc= Date: Fri, 21 Aug 2026 12:25:30 +0100 From: Liviu Dudau To: Geert Uytterhoeven Cc: Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?utf-8?B?TMOzcGV6?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 05/45] clk: cdce925: Make sure clk_init_data is fully initialized Message-ID: References: <308a33a0e63241d94ee08a08a6de6cffa739556e.1787239813.git.geert+renesas@glider.be> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <308a33a0e63241d94ee08a08a6de6cffa739556e.1787239813.git.geert+renesas@glider.be> On Fri, Aug 21, 2026 at 10:53:15AM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Liviu Dudau Best regards, Liviu > --- > Compile-tested only. > --- > drivers/clk/clk-cdce925.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c > index 30d0493c771818ff..4d49cc1659c07be2 100644 > --- a/drivers/clk/clk-cdce925.c > +++ b/drivers/clk/clk-cdce925.c > @@ -620,7 +620,7 @@ static int cdce925_probe(struct i2c_client *client) > struct device_node *node = client->dev.of_node; > const char *parent_name; > const char *pll_clk_name[MAX_NUMBER_OF_PLLS] = {NULL,}; > - struct clk_init_data init; > + struct clk_init_data init = {}; > u32 value; > int i; > int err; > -- > 2.43.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯