From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35DDCCC6B08 for ; Tue, 13 Oct 2026 09:09:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4j3pSN15Qfz3br5; Tue, 13 Oct 2026 20:09:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1791882580; cv=none; b=MVi/VJbYq74EX38g1Ue4SH8IKHOrIuf1aZkWsF5urSojgz86u+qEc0HBXqruC+DAjdNNtUgwNQkn+cn1ZRtg0JOJnpbwmFOw9Au6V1Iauxtp/R4gem2ofTUEeA5FTcZzPO4XULUViZ40w2z88f25OOdiGz1ykWEBTcTaZTzu0yLjshyCvnd7iznYrOc/k0Us/qoFl4AaGhVRYgnyK4oofk1rF8gPT/k5pTAOr0Hc2PGjROYYiICoEGEYHIp/SGZttHEHmXqSScjG+mEIPkHvv+RXseVBGU3TZ4R/o8VTALk8xTZ0Db9A+S93U7qcNUDAMA4wwujlAfZV80ZNfD5KKw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1791882580; c=relaxed/relaxed; bh=6lw22XAqi3McYHdECP3iKpzl9Y1OVpdjtKD9ZynF7cY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ToyD3VnfykX3rc/UWXPFcY6YbHGtFVZ217fZ22RdSix6eq1Sm9AWfE95Fqm/MZvuGjE6KN5GKH3ZVqjTIOs1hJV5wae++jK+kuyMpRrM3S74tAIHqYHFTAN8hnm+nOBndNXEZh6MecHLguNg+fJFyNdHj7I3px0DsHYFAq/wEBtf6ruecuSBAdIkGdihQLtIQLvuYNiuyht9VNxVOIyjbKXfoRGRFhpjWFoyuSvybXEvGCRJx1TtYlhiw6VvJzMXpQy3wn2rV2cCklF4zwSdwrtxprEs1/0J4nP1zMh+VBPZQqdPaB/hAhDC9C3vsOijU8EsZ1S/cK30SRMzU+2qaA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=kHjNZnb5; dkim-atps=neutral; spf=pass (client-ip=198.175.65.15; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=kHjNZnb5; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com (client-ip=198.175.65.15; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4j3pSJ1GMqz3br2 for ; Tue, 13 Oct 2026 20:09:33 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791882577; x=1823418577; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IQ/UNuFHURdJ5ziTLh4qZrD8MOsGX3B11CY5vdjd4ZM=; b=kHjNZnb50E++J4yon/meJu5XlsB4Vjwe0WJVeRRJNYQuIQLdQIQCp4cx Q9f/xAqP3VqQjifq33oDsiibeA4sRooOjcvgbI+X0l6EuyssmoqNLLWWX psX4mqs8j3OhkmjubtG7BpwDbd+GKmXy+UZ1SBPZG8gedDS/JH4VOUasa KjUAladHq5p6RrkTffjHz94LxN5mZDXcw+3fun6xMfUU5utM9hkQXlIm3 /gFfIBSzE/eFyGsafo0WKGtAqq/Q9yPCGwFmFw1dRKLlHYF2SLx4BL984 Pjs9r2vfpfRmAvEKrg4H5P/i3qjeE3EdYM3cy6gHMdmJgIA5bAk4WWeV/ A==; X-CSE-ConnectionGUID: xK7HelgEQ8C6mui5ZjmmVA== X-CSE-MsgGUID: n/K3zwN0T66pzCSJJ//1WA== X-IronPort-AV: E=McAfee;i="6800,10657,11933"; a="595199" X-IronPort-AV: E=Sophos;i="6.27,155,1787036400"; d="scan'208";a="595199" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2026 02:09:30 -0700 X-CSE-ConnectionGUID: BgXYAbCpQMSPY4ai3EmgtQ== X-CSE-MsgGUID: Z+SacHifQmOu6wFBhA0rHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,155,1787036400"; d="scan'208";a="1196513" Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.48]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2026 02:09:20 -0700 Date: Tue, 13 Oct 2026 12:09:18 +0300 From: Andy Shevchenko To: Jiri Slaby Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Vadim Fedorenko , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Al Cooper , Paul Cercueil , Matthias Brugger , AngeloGioacchino Del Regno , Chaitanya Vadrevu , "James E.J. Bottomley" , Helge Deller , Kumaravel Thiagarajan , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Kees Cook , "Gustavo A. R. Silva" , Uwe =?iso-8859-1?Q?Kleine-K=F6nig_=28The_Capable_Hub=29?= , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-parisc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 6/6] serial: 8250: make port operations work on struct uart_8250_port Message-ID: References: X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Oct 13, 2026 at 09:53:26AM +0200, Jiri Slaby wrote: > On 13. 10. 26, 9:33, Andy Shevchenko wrote: > > On Tue, Oct 13, 2026 at 08:48:51AM +0200, Jiri Slaby (SUSE) wrote: ... > > > - rc = serial8250_register_8250_port(&port); > > > - if (rc < 0) > > > + struct uart_8250_port *uport = serial8250_register_8250_port(&port); > > > + if (IS_ERR(uport)) { > > > + rc = PTR_ERR(uport); > > > goto err_sysfs_remove; > > > + } > > > Also do not define > > variables in the middle of the code (it's only allowed for auto cleanup > > variables and for-loop iterators). > > Why, actually? Because it's the style. Linus also told it many times (I am tired to repeat this, I leave it to you to find his words on lore.kernel.org). > First, it is used in the kernel quite a few times already > [1]. Second, while it is sort of c++ism (and I like to use modern c++), it > makes the life of the variable a lot more obvious. > > [1] eg. see output of: rg -U -C 5 '}\n+\s+struct .*\*.*=' drivers/ (you made me to install something I haven't heard about, it's better to use `git grep` though) Note excluded __free() if I get regexp correctly $ rg -U -l '}\n+\s+struct .*\*[^)]*=' drivers/ | less drivers/ufs/host/ufs-qcom.c drivers/dma/xilinx/xilinx_dma.c drivers/dma/idxd/init.c drivers/media/platform/raspberrypi/rp1-cfe/csi2.c drivers/gpib/agilent_82357a/agilent_82357a.c drivers/gpib/ni_usb/ni_usb_gpib.c drivers/tty/serial/samsung_tty.c drivers/s390/scsi/zfcp_scsi.c drivers/gpio/gpiolib-shared.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_dmub.c drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c drivers/gpu/drm/msm/msm_gem_vma.c drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c So, less than dozen of drivers doing wrong is not an argument, try something better. But thanks, I will check and address this in some of the above. -- With Best Regards, Andy Shevchenko