From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Date: Wed, 29 May 2019 10:04:45 -0700 Subject: [PATCH v2 10/11] media: aspeed: fix an incorrect timeout checking in mode detection In-Reply-To: <50abcb27-30af-9dfc-3a53-4261832f272d@linux.vnet.ibm.com> References: <20190524231725.12320-1-jae.hyun.yoo@linux.intel.com> <20190524231725.12320-11-jae.hyun.yoo@linux.intel.com> <50abcb27-30af-9dfc-3a53-4261832f272d@linux.vnet.ibm.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 5/29/2019 7:03 AM, Eddie James wrote: > > On 5/24/19 6:17 PM, Jae Hyun Yoo wrote: >> There is an incorrect timeout checking in mode detection logic so >> it misses resolution detecting chances. This commit fixes the bug. >> >> Signed-off-by: Jae Hyun Yoo >> --- >> v1 -> v2: >> ? New. >> >> ? drivers/media/platform/aspeed-video.c | 2 +- >> ? 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/aspeed-video.c >> b/drivers/media/platform/aspeed-video.c >> index 67f476bf0a03..b05b073b63bc 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -735,7 +735,7 @@ static void aspeed_video_get_resolution(struct >> aspeed_video *video) >> ????? do { >> ????????? if (tries) { >> ????????????? set_current_state(TASK_INTERRUPTIBLE); >> -??????????? if (schedule_timeout(INVALID_RESOLUTION_DELAY)) >> +??????????? if (!schedule_timeout(INVALID_RESOLUTION_DELAY)) >> ????????????????? return; > > > schedule_timeout returns 0 when the timer has expired otherwise the > remaining time in? jiffies will be returned. So if it was interrupted > (timer did not expire and it returns non-zero) then we should return, > rather than keep trying. So I think it was correct before. Thanks, Eddie I thought that there is an explicit waking up case of this waiting before the delay expires but I checked code again that there isn't. So yes, you are right. Will drop this change from this series. Thanks for the review! Regards, Jae