From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CB92CC6B03 for ; Tue, 13 Oct 2026 09:39:15 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4j3q6T45tXz3br5; Tue, 13 Oct 2026 20:39:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1791884353; cv=none; b=oYN0iPFr6WNrKx/X84kL2+jjmhCYpBbek4xQ3YUZ7FpT4XBQ03jJ5MldPk+s0QpauUliqNoqtb9pgAmk02MZwf0l7cchOi5Y8i1pZ+1QbzsMn2NhT+SgQTzDxwOtAuEhKPZvU0jf8LI5hdl5MwHhBFLcQMkMfQDYI9fuki5SG6EVlXI4O6/N3DI40XFsc3fF7BLDd2PHAfnT6v3hmQRsKUEBsfbCApodNw3OgDnm/ZDM8DFT2FosOA1/cVFZBDcOuO2Aj1K79wHhw4ORkj9T4AlvJGjyo6dsy7cd16QCIIR3pQrMe/WtIZX0HP6EOdJhhcGZZtbTRysxV8aBL03elA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1791884353; c=relaxed/relaxed; bh=eLPwh/yQWtDaxNr2UEwq5ZW0o84R3kGQoo6l+HPSejk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FgJ5p9w1whgWG7hZUu4qxI4hTvFnxQxwkSoEBwC+MEd8An7SW3vSs58MLcOFkrrcF8OnwsbqdJHrkBAKUULup5o+5sTW3f6CswzEh70zp5DmJdTpE4SLbVD9qpiAgDGscspYE6y1JIFK28HtxhQC+AFmJVzM62prnxAqalGHmrCPSCKbvVb4ejZELOQ2R/QxEbCND3NA2oTQh0KTIB7yuqi0JoX54LjATWJjoWJSfE/+awDkDy7lyFmGIjcyGTte2WMBH4bkrEXIV/FgG48OzjGzOBfC3dsLMYyOD6jYaAhA8XRqXfavGxrhEj07jRn9bIOEQfhQ0oD1/8P7d9j7fg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dSKY8j8e; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=jirislaby@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dSKY8j8e; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=jirislaby@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4j3q6S4h9Nz30hC for ; Tue, 13 Oct 2026 20:39:12 +1100 (AEDT) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5145A60A52; Tue, 13 Oct 2026 09:39:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEB201F00893; Tue, 13 Oct 2026 09:39:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791884350; bh=eLPwh/yQWtDaxNr2UEwq5ZW0o84R3kGQoo6l+HPSejk=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=dSKY8j8ejFhnFyf/MjMoUpM2fDoiS0upsh/RlcqA63qPiiDOOVJManG46aLXMIeb6 JwgT2rvZt6HFgdLQNiBqSOsUW8j0WoTZA6GBST8Rt2mqdYdt3xLSpAotxVdl5e7kAK X+9cTaRbwZEJGErSi5SibklRXt+i4y+qNbr+ClQRvGaNwrkfOBWcJacEkmzzwDyXyW RXP6jWBISD3Nv2YwJsVxU9aHAlgEw+7k0VgMMfwUkqbqNW2FpI44X0CpULV8jl9hDo pBPIwbEKbjj5IOqwhuehO02qNopXAEQWC2XLbEiW+/NrmNccBiwu4bbJrT0Zt9xH+c ekHFx0Tf4neAg== Message-ID: Date: Tue, 13 Oct 2026 11:39:00 +0200 X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] serial: 8250: make port operations work on struct uart_8250_port To: Andy Shevchenko Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Vadim Fedorenko , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Al Cooper , Paul Cercueil , Matthias Brugger , AngeloGioacchino Del Regno , Chaitanya Vadrevu , "James E.J. Bottomley" , Helge Deller , Kumaravel Thiagarajan , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Kees Cook , "Gustavo A. R. Silva" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-parisc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-hardening@vger.kernel.org References: Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13. 10. 26, 11:09, Andy Shevchenko wrote: > On Tue, Oct 13, 2026 at 09:53:26AM +0200, Jiri Slaby wrote: >> On 13. 10. 26, 9:33, Andy Shevchenko wrote: >>> On Tue, Oct 13, 2026 at 08:48:51AM +0200, Jiri Slaby (SUSE) wrote: > > ... > >>>> - rc = serial8250_register_8250_port(&port); >>>> - if (rc < 0) >>>> + struct uart_8250_port *uport = serial8250_register_8250_port(&port); >>>> + if (IS_ERR(uport)) { >>>> + rc = PTR_ERR(uport); >>>> goto err_sysfs_remove; >>>> + } >> >>> Also do not define >>> variables in the middle of the code (it's only allowed for auto cleanup >>> variables and for-loop iterators). >> >> Why, actually? > > Because it's the style. There is no hard style though. It varies across subsystems. > Linus also told it many times Which is neither an argument. Linus is wrong at times ("Link:" use as an example). All in all, I do not insist on this at all. It's easier to read and follow the code for me. Not necessarily the case for others... >> First, it is used in the kernel quite a few times already >> [1]. Second, while it is sort of c++ism (and I like to use modern c++), it >> makes the life of the variable a lot more obvious. >> >> [1] eg. see output of: rg -U -C 5 '}\n+\s+struct .*\*.*=' drivers/ > > (you made me to install something I haven't heard about, it's better to use > `git grep` though) rg is order of magnitude faster (searches in parallel). More importantly in this case, supports multiline matches. (And respects .git ignores.) > Note excluded __free() if I get regexp correctly > > $ rg -U -l '}\n+\s+struct .*\*[^)]*=' drivers/ | less > drivers/ufs/host/ufs-qcom.c ... > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > So, less than dozen of drivers doing wrong is not an argument, try something > better. But thanks, I will check and address this in some of the above. Well, it's only an example of a declaration after a previous opening brace "{" -- this one turned out to be easy to search for. There is a lot of more, of course. kernel/ included. thanks, -- js suse labs