From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A409ACA101F for ; Mon, 15 Sep 2025 05:02:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4cQCZj2Pwyz3d7n; Mon, 15 Sep 2025 15:02:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=203.29.241.158 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1757912557; cv=none; b=Wy6hWm8ahLXStIC7eijeEfObliBFw+xPXnXtRVukLvoFbwabPGQjIscj0ZSZXFsK/RelSn/v0rr9U6g5SPUvdQGZKnHEA4MtaAIpmHWmFGmTzpI8zBCwuhDw2tUmhNHt6NZbevFRvXp6p9VDSZbJHWGyMc2wCPDr4rJ2VpvdVpwmXCkobyl0JBHjUwho8akHmYiOeahnoQnMZ1Vx+avwvfOEIZWEA2bePFNjRYm5RN+6dCieEYaogdBbXapS3BSnmmj7HdMKkPPHGfTqM3dqQaEM3Y8WotTCr4aWBkRLuH5UNVBv+bKsogJ5+jZPPk+gUENf92gzJlr5YOZoxl9I1Q== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1757912557; c=relaxed/relaxed; bh=13NPlfGbvgDFw8RrLUwVeJRg6pjNha4obGTNg9Fzl5w=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=bu1KgeYo2xrVM7/fMuYTIkbABRvt1lkrnjuYYrq0NDQMC1eGGSawsO6mi4SrX+jcsedCezLk6261PYe3CnGVWMlnsGSLyK4EthMqfV/AsS2s3UbAI2+Ymnm7iY3IqECmgyxP8PmU40cuYT8IchAy12umBU7EzL5/EL4M+y+yz6UTuDmKR6CkO6FQFp3wO8PC/5QoMKXIeui1oIOL3trIZR4qc40sn4ilQg+HsHmDEvJu67cGHdNWfWK98cO8bPocBQdXTZ5Xo+VjIKalRk+yz/CBHvkHqzP6v2UCY6fBk6nMx1M1ey0k4bNLHOEv4um+pu0kpPB5JEO+k9eQBxnzJA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; dkim=pass (2048-bit key; unprotected) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.a=rsa-sha256 header.s=2022a header.b=htf09HkZ; dkim-atps=neutral; spf=pass (client-ip=203.29.241.158; helo=codeconstruct.com.au; envelope-from=andrew@codeconstruct.com.au; receiver=lists.ozlabs.org) smtp.mailfrom=codeconstruct.com.au Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.a=rsa-sha256 header.s=2022a header.b=htf09HkZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=codeconstruct.com.au (client-ip=203.29.241.158; helo=codeconstruct.com.au; envelope-from=andrew@codeconstruct.com.au; receiver=lists.ozlabs.org) Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4cQCZh5x7xz3d44 for ; Mon, 15 Sep 2025 15:02:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1757912556; bh=13NPlfGbvgDFw8RrLUwVeJRg6pjNha4obGTNg9Fzl5w=; h=Subject:From:To:Date:In-Reply-To:References; b=htf09HkZFncGYF0Rk8VAKDviUA7EafLlMxtWRN/F0fsy/5RzAISL02kbcEX+N3Hpf gmYX+/6Ugp/r+8NcNHWSJJ57fuGIVId3f/v9GNVSx+Thn7pSlRSiOaM4n38n6kp9+a ZTAv/UH4ezzW3W//f6WHKC3Hg56oOsdoknqCzWvaX7MgsgexrA6Pbvso0IN+Lz+0GK 9w/a1w7hH57eD7+hD+/VwuUX51By8eHIP5/BO3Neo2XdCnsdjCKjQUCPEx2DEwHxEf 41+nNknmci6emz4/Uema0AIslKYe5kNKmEpyLCXa1rgQ4z7ADlg+30GHu2GU3JwFpO Pga+GDAX/L9KA== Received: from [IPv6:2405:6e00:2430:fb15:b2b4:1872:3690:c682] (unknown [120.20.190.44]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 04C2364CF0; Mon, 15 Sep 2025 13:02:33 +0800 (AWST) Message-ID: Subject: Re: [PATCH 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC From: Andrew Jeffery To: Rebecca Cran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 15 Sep 2025 14:32:32 +0930 In-Reply-To: <20250911051009.4044609-3-rebecca@bsdio.com> References: <20250911051009.4044609-1-rebecca@bsdio.com> <20250911051009.4044609-3-rebecca@bsdio.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1 X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 On Wed, 2025-09-10 at 23:10 -0600, Rebecca Cran wrote: > The ALTRAD8 BMC is an Aspeed AST2500-based BMC for the ASRock Rack > ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q boards. >=20 > Signed-off-by: Rebecca Cran > --- > =C2=A0arch/arm/boot/dts/aspeed/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 + > =C2=A0arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts | 647 > ++++++++++++++++++++ > =C2=A02 files changed, 648 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/aspeed/Makefile > b/arch/arm/boot/dts/aspeed/Makefile > index aba7451ab749..6bffb7130839 100644 > --- a/arch/arm/boot/dts/aspeed/Makefile > +++ b/arch/arm/boot/dts/aspeed/Makefile > @@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_ASPEED) +=3D \ > =C2=A0 aspeed-bmc-ampere-mtjefferson.dtb \ > =C2=A0 aspeed-bmc-ampere-mtmitchell.dtb \ > =C2=A0 aspeed-bmc-arm-stardragon4800-rep2.dtb \ > + aspeed-bmc-asrock-altrad8.dtb \ > =C2=A0 aspeed-bmc-asrock-e3c246d4i.dtb \ > =C2=A0 aspeed-bmc-asrock-e3c256d4i.dtb \ > =C2=A0 aspeed-bmc-asrock-romed8hm3.dtb \ > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts > b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts > new file mode 100644 > index 000000000000..61f6cf8018c0 > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts > @@ -0,0 +1,647 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/dts-v1/; > +#include "aspeed-g5.dtsi" > +#include > +#include > +#include > + > +/ { > + model =3D "ASRock ALTRAD8 BMC"; > + compatible =3D "asrock,altrad8-bmc", "aspeed,ast2500"; > + *snip* > +}; > + > +&uart1 { > + status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_txd1_default > + &pinctrl_rxd1_default > + &pinctrl_ncts1_default > + &pinctrl_nrts1_default>; > +}; > + > +&uart2 { > + status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_txd2_default > + &pinctrl_rxd2_default>; > +}; > + > +&uart3 { > + status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_txd3_default > + &pinctrl_rxd3_default>; > +}; > + > +&uart4 { > + status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_txd4_default > + &pinctrl_rxd4_default>; > +}; > + > +/* The BMC's uart */ > +&uart5 { > + status =3D "okay"; > +}; > + > +&mac0 { Recently I've decided that I'd like the "usual" node references here in the DTS to be ordered alphabetically. The style guide gives us two ordering options, either by ascending unit address or alphabetically: https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-= nodes Without the unit address being visible it's hard to verify the former, hence the preference for the latter. Can you please sort these accordingly? > + status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_rmii1_default>; > + clocks =3D <&syscon ASPEED_CLK_GATE_MAC1CLK>, > + <&syscon ASPEED_CLK_MAC1RCLK>; > + clock-names =3D "MACCLK", "RCLK"; > + use-ncsi; > + > + nvmem-cells =3D <ð0_macaddress>; > + nvmem-cell-names =3D "mac-address"; > +}; >=20 *snip* > + > +&i2c3 { > + status =3D "okay"; > + > + power-supply@3c { > + compatible =3D "pmbus"; Devicetrees describe the hardware and not abstract protocols like PMBus, so the compatible string must refer to a specific manufacturer,model here. Cheers, Andrew