From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v4 17/17] fsi: scom: Update compatible string to match documentation
Date: Tue, 30 Apr 2024 09:37:30 +0200 [thread overview]
Message-ID: <c722d3d6-2acb-4669-b541-eebaf71b3a04@kernel.org> (raw)
In-Reply-To: <20240429210131.373487-18-eajames@linux.ibm.com>
On 29/04/2024 23:01, Eddie James wrote:
> Use p9-scom instead of fsi2pib.
Why? Commits must *always* say why you are doing it. What is easy to see.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> drivers/fsi/fsi-scom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> index 61dbda9dbe2b..18ca213fdc7e 100644
> --- a/drivers/fsi/fsi-scom.c
> +++ b/drivers/fsi/fsi-scom.c
> @@ -589,7 +589,7 @@ static int scom_remove(struct device *dev)
> }
>
> static const struct of_device_id scom_of_ids[] = {
> - { .compatible = "ibm,fsi2pib" },
> + { .compatible = "ibm,p9-scom" },
This breaks all users without any explanation in the commit!
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-30 7:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 21:01 [PATCH v4 00/17] ARM: dts: aspeed: Add IBM P11 BMC Boards Eddie James
2024-04-29 21:01 ` [PATCH v4 01/17] spi: dt-bindings: Document the IBM FSI-attached SPI controller Eddie James
2024-04-30 6:50 ` Krzysztof Kozlowski
2024-04-29 21:01 ` [PATCH v4 02/17] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-04-30 6:51 ` Krzysztof Kozlowski
2024-04-29 21:01 ` [PATCH v4 03/17] dt-bindings: fsi: Document the IBM SCOM engine Eddie James
2024-04-29 21:01 ` [PATCH v4 04/17] dt-bindings: fsi: p9-occ: Convert to json-schema Eddie James
2024-04-30 6:53 ` Krzysztof Kozlowski
2024-05-01 15:59 ` Eddie James
2024-05-04 11:50 ` Krzysztof Kozlowski
2024-04-29 21:01 ` [PATCH v4 05/17] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-30 6:54 ` Krzysztof Kozlowski
2024-05-01 16:03 ` Eddie James
2024-04-29 21:01 ` [PATCH v4 06/17] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-04-30 7:01 ` Krzysztof Kozlowski
2024-05-01 16:06 ` Eddie James
2024-04-29 21:01 ` [PATCH v4 07/17] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-04-30 7:02 ` Krzysztof Kozlowski
2024-04-29 21:01 ` [PATCH v4 08/17] dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema Eddie James
2024-04-30 7:04 ` Krzysztof Kozlowski
2024-05-01 16:12 ` Eddie James
2024-05-04 11:55 ` Krzysztof Kozlowski
2024-05-14 15:38 ` Eddie James
2024-04-29 21:01 ` [PATCH v4 09/17] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
2024-04-30 7:31 ` Krzysztof Kozlowski
2024-04-29 21:01 ` [PATCH v4 10/17] dt-bindings: i2c: i2c-fsi: Convert to json-schema Eddie James
2024-04-30 7:35 ` Krzysztof Kozlowski
2024-05-01 16:16 ` Eddie James
2024-05-02 12:58 ` Krzysztof Kozlowski
2024-04-29 21:01 ` [PATCH v4 11/17] dt-bindings: arm: aspeed: add IBM P11 BMC boards Eddie James
2024-04-30 7:35 ` Krzysztof Kozlowski
2024-04-29 21:01 ` [PATCH v4 12/17] ARM: dts: aspeed: Add IBM P11 FSI devices Eddie James
2024-04-29 21:01 ` [PATCH v4 13/17] ARM: dts: aspeed: Add IBM P11 Blueridge BMC system Eddie James
2024-04-29 21:01 ` [PATCH v4 15/17] fsi: occ: Get device number from FSI minor number API Eddie James
2024-04-29 21:01 ` [PATCH v4 16/17] fsi: occ: Find next available child rather than node name match Eddie James
2024-04-29 21:01 ` [PATCH v4 17/17] fsi: scom: Update compatible string to match documentation Eddie James
2024-04-30 7:37 ` Krzysztof Kozlowski [this message]
2024-04-29 21:02 ` [PATCH v4 14/17] ARM: dts: aspeed: Add IBM P11 Fuji BMC system Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c722d3d6-2acb-4669-b541-eebaf71b3a04@kernel.org \
--to=krzk@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).