From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable
Date: Mon, 29 Jul 2019 12:20:30 +1000 [thread overview]
Message-ID: <cd7e4eacb7c6572e58ed5fdc2286082367520e9e.camel@kernel.crashing.org> (raw)
In-Reply-To: <6b31627a8c5a2616c83783550517961b7ed8f3cb.camel@ozlabs.org>
On Mon, 2019-07-29 at 08:51 +0800, Jeremy Kerr wrote:
> Hi Oskar,
>
> > For LPC, the polarity should be set to 1, for eSPI the default of 0 is
> > correct.
>
> Would there ever be a case where different SIRQs need different
> polarities? If not, we may want this to be global, rather than for each
> device (the VUART being one...)
Leave it per device. The way to configure this is completely device
dependent. In fact for most devices it can only be done by the host via
SIO.
Cheers,
Ben.
next prev parent reply other threads:[~2019-07-29 2:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 13:42 [PATCH] drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable Oskar Senft
2019-07-28 1:30 ` Benjamin Herrenschmidt
2019-07-28 4:00 ` Oskar Senft
2019-07-28 17:23 ` Oskar Senft
2019-07-29 0:51 ` Jeremy Kerr
2019-07-29 1:14 ` Oskar Senft
2019-07-29 2:02 ` Jeremy Kerr
2019-07-29 2:21 ` Oskar Senft
2019-07-29 3:02 ` Andrew Jeffery
2019-07-31 1:36 ` Oskar Senft
2019-07-29 2:20 ` Benjamin Herrenschmidt [this message]
2019-07-29 2:23 ` Oskar Senft
2019-07-29 2:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd7e4eacb7c6572e58ed5fdc2286082367520e9e.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).