From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Mon, 29 Jul 2019 12:20:30 +1000 Subject: [PATCH] drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable In-Reply-To: <6b31627a8c5a2616c83783550517961b7ed8f3cb.camel@ozlabs.org> References: <20190727134242.49847-1-osk@google.com> <9fb8c99449cebd68fb5975890dedaa06ce7808ae.camel@kernel.crashing.org> <6b31627a8c5a2616c83783550517961b7ed8f3cb.camel@ozlabs.org> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, 2019-07-29 at 08:51 +0800, Jeremy Kerr wrote: > Hi Oskar, > > > For LPC, the polarity should be set to 1, for eSPI the default of 0 is > > correct. > > Would there ever be a case where different SIRQs need different > polarities? If not, we may want this to be global, rather than for each > device (the VUART being one...) Leave it per device. The way to configure this is completely device dependent. In fact for most devices it can only be done by the host via SIO. Cheers, Ben.