From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Willie Thai <wthai@nvidia.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
joel@jms.id.au, kees@kernel.org, tony.luck@intel.com,
gpiccoli@igalia.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, openbmc@lists.ozlabs.org
Cc: leohu@nvidia.com, tingkaic@nvidia.com, dkodihalli@nvidia.com
Subject: Re: [PATCH v4 2/3] dt-bindings: pinctrl: aspeed,ast2600-pinctrl
Date: Fri, 28 Mar 2025 11:16:49 +1030 [thread overview]
Message-ID: <d0f7003c22e19c8fc7617610043edc7be925a180.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250324175926.222473-3-wthai@nvidia.com>
On Mon, 2025-03-24 at 17:59 +0000, Willie Thai wrote:
> Add EMMCG5 enum to compatible list of pinctrl binding for emmc
> enabling.
>
> Cc: Andrew Jeffery <andrew@codeconstruct.com.au>
> Signed-off-by: Willie Thai <wthai@nvidia.com>
> ---
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-
> pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-
> pinctrl.yaml
> index 80974c46f3ef..cb75e979f5e0 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-
> pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-
> pinctrl.yaml
> @@ -276,6 +276,7 @@ additionalProperties:
> - BMCINT
> - EMMCG1
> - EMMCG4
> + - EMMCG5
What pin configuration does this correspond to for the eMMC controller?
These groups aren't arbitrary, they correspond to the 1, 4 and 8-bit
bus modes.
You may have added this squash a warning, but I suspect the pinctrl
configuration in your devicetree is incorrect.
Andrew
> - EMMCG8
> - ESPI
> - ESPIALT
next prev parent reply other threads:[~2025-03-28 0:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 17:59 [PATCH v4 0/3] Add device tree for Nvidia's GB200NVL BMC Willie Thai
2025-03-24 17:59 ` [PATCH v4 1/3] dt-bindings: arm: aspeed: add " Willie Thai
2025-03-25 7:17 ` Krzysztof Kozlowski
2025-03-24 17:59 ` [PATCH v4 2/3] dt-bindings: pinctrl: aspeed,ast2600-pinctrl Willie Thai
2025-03-25 7:17 ` Krzysztof Kozlowski
2025-03-28 0:46 ` Andrew Jeffery [this message]
2025-03-31 17:18 ` Willie Thai
2025-04-01 0:52 ` Andrew Jeffery
2025-03-24 17:59 ` [PATCH v4 3/3] ARM: dts: aspeed: Add device tree for Nvidia's GB200NVL BMC Willie Thai
2025-03-25 3:13 ` [PATCH v4 0/3] " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0f7003c22e19c8fc7617610043edc7be925a180.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkodihalli@nvidia.com \
--cc=gpiccoli@igalia.com \
--cc=joel@jms.id.au \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=leohu@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=tingkaic@nvidia.com \
--cc=tony.luck@intel.com \
--cc=wthai@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).