From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rebecca Cran <rebecca@bsdio.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Tan Siewert <tan.siewert@hetzner.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Billy Tsai <billy_tsai@aspeedtech.com>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board
Date: Thu, 18 Dec 2025 20:31:31 +0100 [thread overview]
Message-ID: <d215c5dd-b402-4cd2-b4c6-48358b5b2491@kernel.org> (raw)
In-Reply-To: <4eff8506-8049-46e9-997e-a41edff32bbc@bsdio.com>
On 18/12/2025 19:34, Rebecca Cran wrote:
> On 12/18/25 09:21, Krzysztof Kozlowski wrote:
>> On 18/12/2025 17:18, Rebecca Cran wrote:
>>> Document ASRock Rack ALTRAD8 (ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q)
>>> compatibles.
>>>
>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Tested-by: Tan Siewert <tan.siewert@hetzner.com>
>> How was the binding tested?
>
> I ran "make ARCH=arm CHECK_DTBS=y aspeed/aspeed-bmc-asrock-altrad8.dtb"
> to check for errors
That's a build check for DTS, not binding. I compiled this code - so it
is also Tested-by?
>
> and have used the dts file in an ASRock Rack ALTRAD8UD-1L2T system with
> Linux 6.12.61 running OpenBMC.
This does not test anything from the binding.
Please don't add fake tests... Building instructions are not testing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-18 19:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 16:18 [PATCH v6 0/2] Add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran
2025-12-18 16:18 ` [PATCH v6 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board Rebecca Cran
2025-12-18 16:21 ` Krzysztof Kozlowski
2025-12-18 16:44 ` Tan Siewert
2025-12-18 19:32 ` Krzysztof Kozlowski
2026-01-08 5:48 ` Andrew Jeffery
2025-12-18 18:34 ` Rebecca Cran
2025-12-18 19:31 ` Krzysztof Kozlowski [this message]
2025-12-18 22:26 ` Rebecca Cran
2025-12-18 16:18 ` [PATCH v6 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d215c5dd-b402-4cd2-b4c6-48358b5b2491@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rebecca@bsdio.com \
--cc=robh@kernel.org \
--cc=tan.siewert@hetzner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox