From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range
Date: Mon, 20 Oct 2025 08:44:57 +0200 [thread overview]
Message-ID: <e7fec714-aa68-49a1-85e5-356115843307@kernel.org> (raw)
In-Reply-To: <6b30c646-cc52-4552-8311-86974c1459e7@kernel.org>
On 20/10/2025 08:39, Krzysztof Kozlowski wrote:
> On 20/10/2025 08:31, Ryan Chen wrote:
>>> Subject: Re: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells
>>> range
>>>
>>> On 20/10/2025 04:07, Ryan Chen wrote:
>>>> The #size-cells property in the Aspeed SCU binding is currently fixed
>>>> to a constant value of 1. However, newer SoCs (ex. AST2700) may
>>>> require two size cells to describe certain subregions or
>>>
>>> "may"? So there is no issue yet?
>>
>> while I submit ast2700 platform,
>
> So there is no warning currently? Then don't mention. You cannot use
> argument of possible future warning as there is a warning needing to be
> fixed. This makes no sense. Like you add bug in your patchset and then
> send *different* patch claiming you are fixing a bug.
>
>
>> These warnings appear when validating the AST2700 EVB device tree.
>> The SCU nodes on AST2700 have subdevices (such as clock and reset controllers)
>> that require two address cells, which is not allowed by the current `const: 1`
>> constraint in the schema.
>>
>> Here is the related report:
>> https://lkml.org/lkml/2025/9/2/1165
>
> This must be together, so we can review entire picture, not pieces by
> pieces. Organize your work correctly, so reviewing will be easy.
>
Anyway, I managed to find your original work and there is no need for
this patch at all. You don't have 64-bit sizes there.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-20 6:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 2:07 [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range Ryan Chen
2025-10-20 6:17 ` Krzysztof Kozlowski
2025-10-20 6:31 ` Ryan Chen
2025-10-20 6:39 ` Krzysztof Kozlowski
2025-10-20 6:44 ` Krzysztof Kozlowski [this message]
2025-10-20 7:05 ` Ryan Chen
2025-10-20 8:18 ` Ryan Chen
2025-10-20 8:46 ` Krzysztof Kozlowski
2025-10-20 8:50 ` Ryan Chen
2025-10-20 9:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7fec714-aa68-49a1-85e5-356115843307@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox