Re: [PATCH v2] ARM: dts: aspeed: anacapa: Add eeprom device node for NFC adaptor board

[Andrew Jeffery <andrew@codeconstruct.com.au>]

Hi Carl,

Sorry for the delayed in review.

On Mon, 2026-03-09 at 11:46 +0800, Carl Lee via B4 Relay wrote:
> From: Carl Lee <carl.lee@amd.com>
> 
> Add eeprom device node for NFC adaptor board FRU.
> 
> Signed-off-by: Carl Lee <carl.lee@amd.com>
> ---
> Add eeprom device nodes used to store FRU data for the PRoT
> module and NFC adapter board on Anacapa platform.

This patch note seems inaccurate for the purpose of v2?

Doesn't matter too much in this instance, but should be fixed for any
subsequent revision. Which, speaking of ...

> ---
> Changes in v2:
> - Remove PRoT module eeprom commit since it is already included in another series under review.
> - Only include NFC adapter board eeprom node.
> - Link to v1: https://lore.kernel.org/r/20260309-arm-dts-aspeed-anacapa-add-eeprom-device-v1-0-45092310e0e6@amd.com
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> index 2cb7bd128d24..69c41532fdfb 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> @@ -815,6 +815,11 @@ i2c13mux0ch7: i2c@7 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  
> +			eeprom@50 {
> +				compatible = "atmel,24c128";
> +				reg = <0x50>;
> +			};
> +
>  			nfc@28 {

... these nodes are out of order.

Can you please order them by ascending unit address, as per the DTS
coding style?

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

Andrew

>  				compatible = "nxp,nxp-nci-i2c";
>  				reg = <0x28>;
> 
> ---
> base-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f
> change-id: 20260309-arm-dts-aspeed-anacapa-add-eeprom-device-a1aabe06a35b
> 
> Best regards,