From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Date: Wed, 10 Jan 2024 16:37:32 +0100 Subject: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings In-Reply-To: <2dd37d2b-28da-4e73-9047-61ec5d64bdb5@linux.ibm.com> References: <20231212164004.1683589-1-ninad@linux.ibm.com> <20231212164004.1683589-8-ninad@linux.ibm.com> <20231212-avid-grill-dbead068fac8@spud> <73381bb0-7fa7-4a9e-88df-ab0063058e26@roeck-us.net> <20231212-mouth-choice-40a83caa34ec@spud> <2946fbb1-2a47-4d21-83dc-8e45bf6ba5a9@roeck-us.net> <60c8bbdb-4e08-44f0-88d4-ab164d4843b5@linux.ibm.com> <20240109-pep-coerce-2a86ae88753d@spud> <01974929-dfbf-4989-ba39-369e521827d0@linux.ibm.com> <3d194e84-bf1a-48e4-a376-e5c327c6508d@linaro.org> <2dd37d2b-28da-4e73-9047-61ec5d64bdb5@linux.ibm.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 10/01/2024 15:31, Ninad Palsule wrote: > Hello Krzysztof, > > > >>>>> I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ninad at linux.ibm.com/ >>>> Why did you do that? It now just adds undocumented compatibles to the >>>> driver. Please, as Rob requested, work with Lukas on his series to make >>>> sure that these devices are documented. >>> I think krzysztof kozlowski suggested to send these patches separately: >>> https://lore.kernel.org/linux-kernel/1c5ace65-2fd8-4503-b22f-e0f564d1c83f at linaro.org/ >>> >>> Did I misunderstood it? Do you guys want me to include that commit again? >> My comment was in DTS thread under specific DTS patch. How did you >> figure out it applies to driver and bindings? This does not make sense. > > Sorry for the misunderstanding. Where do you want me to add driver > patch? Before all DTS patches or after all DTS patches? Does not matter, why do you insist on combining them with DTS? Drivers and bindings are going together. DTS better separate, although depending on the case can be together. Best regards, Krzysztof