From: Jeremy Kerr <jk@codeconstruct.com.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v4 3/5] clk: ast2600: Add full configs for I3C clocks
Date: Wed, 01 Mar 2023 16:17:39 +0800 [thread overview]
Message-ID: <f5c9ecb7b1a850b196dfd3a5207f03226f514721.camel@codeconstruct.com.au> (raw)
In-Reply-To: <1024ddf2c4047e5a6cd516809d4d15ea5e0349b6.camel@codeconstruct.com.au>
Hi Joel,
> > > @@ -15,7 +16,7 @@
> > >
> > > ?#include "clk-aspeed.h"
> > >
> > > -#define ASPEED_G6_NUM_CLKS???????????? 71
> > > +#define ASPEED_G6_NUM_CLKS???????????? 72
> >
> > NUM_CLKS seems dangerous. Should we instead use
> > ARRAY_SIZE(aspeed_g6_gates)?
>
> Yep, that would have saved me some time debugging. That would suit as
> a separate change though, would you like it in the same series?
No wait, it's not just ARRAY_SIZE(aspeed_g6_gates), there's a bunch of
manually-configured clocks in the aspeed_g6_clk_data->hws[] array too.
This might require a bit more of a restructure if we want to get rid of
the NUM_CLKS definitions...
Cheers,
Jeremy
next prev parent reply other threads:[~2023-03-01 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 9:16 [PATCH v4 0/5] Add definitions for AST2600 i3c clocks and resets Jeremy Kerr
2023-02-28 9:16 ` [PATCH v4 1/5] clk: ast2600: allow empty entries in aspeed_g6_gates Jeremy Kerr
2023-03-01 0:50 ` Joel Stanley
2023-02-28 9:16 ` [PATCH v4 2/5] dt-bindings: clock: ast2600: Add top-level I3C clock Jeremy Kerr
2023-02-28 10:07 ` Krzysztof Kozlowski
2023-03-01 0:51 ` Joel Stanley
2023-02-28 9:16 ` [PATCH v4 3/5] clk: ast2600: Add full configs for I3C clocks Jeremy Kerr
2023-03-01 0:48 ` Joel Stanley
2023-03-01 0:58 ` Jeremy Kerr
2023-03-01 1:06 ` Joel Stanley
2023-03-01 8:17 ` Jeremy Kerr [this message]
2023-02-28 9:16 ` [PATCH v4 4/5] dt-bindings: clock: ast2600: remove IC36 & I3C7 clock definitions Jeremy Kerr
2023-03-01 0:48 ` Joel Stanley
2023-02-28 9:16 ` [PATCH v4 5/5] dt-bindings: clock: ast2600: Add reset config for I3C Jeremy Kerr
2023-03-01 0:49 ` Joel Stanley
2023-03-01 6:28 ` Jeremy Kerr
2023-03-01 6:48 ` Joel Stanley
2023-03-01 6:54 ` Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5c9ecb7b1a850b196dfd3a5207f03226f514721.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox