From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH 1/3] Don't ignore the return value of asprintf()
Date: Sat, 09 Feb 2013 11:50:49 -0500
Message-ID: <10014568.HifH6x9ZRN@x2>
References: <1360379555-1910-1-git-send-email-tyhicks@canonical.com>
	<1360379555-1910-2-git-send-email-tyhicks@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <1360379555-1910-2-git-send-email-tyhicks@canonical.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Tyler Hicks <tyhicks@canonical.com>
Cc: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Friday, February 08, 2013 07:12:33 PM Tyler Hicks wrote:
> If an error occurs in asprintf(), the contents of the strp variable are
> undefined. asprintf()'s return value must be checked and the parameter
> passed into asprintf() should be set to NULL upon error.

Applied. I think there are a couple places where it will obviously segfault in 
auditctl.c. But the patch does clean up a bunch of warnings.

-Steve